Tx insights fixes (#12988)

* Ensure that function representation on hex and data tabs are consistent

* Don't show redundant hex tab when deploying contract

* Show standard pointer cursor on error messages in tx-decoder component

* Don't show activity log for incoming transactions

* Update localization

* Fix error message

app/_locales/en/messages.json

@@ -3209,6 +3209,9 @@
   "twelveHrTitle": {
     "message": "12hr:"
   },
+  "txInsightsNotSupported": {
+    "message": "Transaction insights not supported for this contract at this time."
+  },
   "typePassword": {
     "message": "Type your MetaMask password"
   },

ui/components/app/confirm-page-container/confirm-page-container-content/confirm-page-container-content.component.js

@@ -68,12 +68,14 @@ export default class ConfirmPageContainerContent extends Component {
         <Tab className="confirm-page-container-content__tab" name={t('data')}>
           {dataComponent}
         </Tab>
-        <Tab
+        {dataHexComponent && (
-          className="confirm-page-container-content__tab"
+          <Tab
-          name={t('dataHex')}
+            className="confirm-page-container-content__tab"
-        >
+            name={t('dataHex')}
-          {dataHexComponent}
+          >
-        </Tab>
+            {dataHexComponent}
+          </Tab>
+        )}
       </Tabs>
     );
   }

ui/components/app/transaction-decoding/index.scss

@@ -37,7 +37,9 @@
     }
   }
 
-
+  &-error {
+    cursor: auto;
+  }
 
   .tx-insight-content {
     &__tree-component {

ui/components/app/transaction-decoding/transaction-decoding.component.js

@@ -79,7 +79,11 @@ export default function TransactionDecoding({ to = '', inputData: data = '' }) {
       } catch (error) {
         setLoading(false);
         setError(true);
-        setErrorMessage(error?.message);
+        if (error?.message.match('400')) {
+          setErrorMessage(t('txInsightsNotSupported'));
+        } else {
+          setErrorMessage(error?.message);
+        }
       }
     })();
   }, [t, from, to, network, data]);

ui/components/app/transaction-list-item-details/transaction-list-item-details.component.js

@@ -252,15 +252,18 @@ export default class TransactionListItemDetails extends PureComponent {
                 primaryCurrency={primaryCurrency}
                 className="transaction-list-item-details__transaction-breakdown"
               />
-              <Disclosure title="Activity log" size="small">
+              {transactionGroup.initialTransaction.type !==
-                <TransactionActivityLog
+                TRANSACTION_TYPES.INCOMING && (
-                  transactionGroup={transactionGroup}
+                <Disclosure title={t('activityLog')} size="small">
-                  className="transaction-list-item-details__transaction-activity-log"
+                  <TransactionActivityLog
-                  onCancel={this.handleCancel}
+                    transactionGroup={transactionGroup}
-                  onRetry={this.handleRetry}
+                    className="transaction-list-item-details__transaction-activity-log"
-                  isEarliestNonce={isEarliestNonce}
+                    onCancel={this.handleCancel}
-                />
+                    onRetry={this.handleRetry}
-              </Disclosure>
+                    isEarliestNonce={isEarliestNonce}
+                  />
+                </Disclosure>
+              )}
               {transactionGroup.initialTransaction?.txParams?.data ? (
                 <Disclosure title="Transaction data" size="small">
                   <TransactionDecoding

ui/pages/confirm-transaction-base/confirm-transaction-base.component.js

@@ -635,19 +635,28 @@ export default class ConfirmTransactionBase extends Component {
 
   renderData(functionType) {
     const { t } = this.context;
-    const { txData: { txParams } = {}, hideData, dataComponent } = this.props;
+    const {
+      txData: { txParams } = {},
+      methodData: { params } = {},
+      hideData,
+      dataComponent,
+    } = this.props;
 
     if (hideData) {
       return null;
     }
 
+    const functionParams = params?.length
+      ? `(${params.map(({ type }) => type).join(', ')})`
+      : '';
+
     return (
       dataComponent || (
         <div className="confirm-page-container-content__data">
           <div className="confirm-page-container-content__data-box-label">
             {`${t('functionType')}:`}
             <span className="confirm-page-container-content__function-type">
-              {functionType}
+              {`${functionType} ${functionParams}`}
             </span>
           </div>
           <Disclosure>
@@ -667,12 +676,12 @@ export default class ConfirmTransactionBase extends Component {
       dataHexComponent,
     } = this.props;
 
-    if (hideData) {
+    if (hideData || !txParams.to) {
       return null;
     }
 
-    const functionParams = params
+    const functionParams = params?.length
-      ? `(${params.map(({ type }) => type).join(', ')}`
+      ? `(${params.map(({ type }) => type).join(', ')})`
       : '';
 
     return (