m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00
Code

Remove snapshot update from release process (#20546)

Browse Source 
The Sentry e2e state snapshots now mask the application version and
migration version, ensuring that the snapshots don't need a extra
update in each release candidate branch and post-release sync branch.

The values are masked rather than removed so that the test still shows
they are present in error reports, where they can be quite useful for
diagnostic purposes.
This commit is contained in:
Mark Stacey 2023-08-21 12:53:04 -02:30 committed by GitHub
parent a712298f18
commit 702ee233e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/tests/errors.spec.js
View File

@ -9,9 +9,17 @@ const FixtureBuilder = require('../fixture-builder');
const maskedBackgroundFields = [ const maskedBackgroundFields = [
'CurrencyController.conversionDate', // This is a timestamp that changes each run 'CurrencyController.conversionDate', // This is a timestamp that changes each run
// App metadata is masked so that we don't have to update the snapshot as
// part of the release process
'AppMetadataController.currentAppVersion',
'AppMetadataController.currentMigrationVersion',
]; ];
const maskedUiFields = [ const maskedUiFields = [
'metamask.conversionDate', // This is a timestamp that changes each run 'metamask.conversionDate', // This is a timestamp that changes each run
// App metadata is masked so that we don't have to update the snapshot as
// part of the release process
'metamask.currentAppVersion',
'metamask.currentMigrationVersion',
]; ];
const removedBackgroundFields = [ const removedBackgroundFields = [

4
test/e2e/tests/state-snapshots/errors-after-init-opt-in-background-state.json
View File

@ -8,10 +8,10 @@
}, },
"AnnouncementController": "object", "AnnouncementController": "object",
"AppMetadataController": { "AppMetadataController": {
"currentAppVersion": "10.34.5", "currentAppVersion": "string",
"previousAppVersion": "", "previousAppVersion": "",
"previousMigrationVersion": 0, "previousMigrationVersion": 0,
"currentMigrationVersion": 94 "currentMigrationVersion": "number"
}, },
"AppStateController": { "AppStateController": {
"connectedStatusPopoverHasBeenShown": true, "connectedStatusPopoverHasBeenShown": true,

4
test/e2e/tests/state-snapshots/errors-after-init-opt-in-ui-state.json
View File

@ -57,10 +57,10 @@
"usedNetworks": "object", "usedNetworks": "object",
"snapsInstallPrivacyWarningShown": "boolean", "snapsInstallPrivacyWarningShown": "boolean",
"serviceWorkerLastActiveTime": "number", "serviceWorkerLastActiveTime": "number",
"currentAppVersion": "10.34.5", "currentAppVersion": "string",
"previousAppVersion": "", "previousAppVersion": "",
"previousMigrationVersion": 0, "previousMigrationVersion": 0,
"currentMigrationVersion": 94, "currentMigrationVersion": "number",
"selectedNetworkClientId": "string", "selectedNetworkClientId": "string",
"networkId": "1337", "networkId": "1337",
"providerConfig": { "providerConfig": {