m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix menu-droppo external click handler (#10311)

Browse Source 
The `menu-droppo` external click handler would fail to update when the
prop changed while the menu wasn't shown. This bug isn't exposed
anywhere yet as far as I know, but I ran into it when working on a
different bug fix.
This commit is contained in:
Mark Stacey 2021-01-29 17:04:15 -03:30 committed by GitHub
parent d7d2de04bd
commit 6f46253e62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ui/app/components/app/menu-droppo.js
View File

@ -31,14 +31,6 @@ export default class MenuDroppoComponent extends Component {
) )
} }
manageListeners() {
const { isOpen, onClickOutside } = this.props
if (isOpen) {
this.outsideClickHandler = onClickOutside
}
}
globalClickOccurred = (event) => { globalClickOccurred = (event) => {
const { target } = event const { target } = event
// eslint-disable-next-line react/no-find-dom-node // eslint-disable-next-line react/no-find-dom-node
@ -47,9 +39,9 @@ export default class MenuDroppoComponent extends Component {
if ( if (
target !== container && target !== container &&
!isDescendant(this.container, event.target) && !isDescendant(this.container, event.target) &&
this.outsideClickHandler this.props.onClickOutside
) { ) {
this.outsideClickHandler(event) this.props.onClickOutside(event)
} }
} }
@ -74,8 +66,6 @@ export default class MenuDroppoComponent extends Component {
const { useCssTransition } = this.props const { useCssTransition } = this.props
const zIndex = 'zIndex' in this.props ? this.props.zIndex : 0 const zIndex = 'zIndex' in this.props ? this.props.zIndex : 0
this.manageListeners()
const baseStyle = { const baseStyle = {
position: 'fixed', position: 'fixed',
...style, ...style,