m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix accessor-pairs issues (#9680)

Browse Source 
Refs #9663

See [`accessor-pairs`][1] for more information.

This change enables `accessor-pairs` and fixes the issues raised by the rule.

  [1]:https://eslint.org/docs/rules/accessor-pairs
This commit is contained in:
Whymarrh Whitby 2020-10-22 14:36:44 -02:30 committed by GitHub
parent e46c063fed
commit 6df17dc90e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -89,7 +89,6 @@ module.exports = {
'node/no-process-env': 'off',
// TODO: re-enable these rules
'accessor-pairs': 'off',
'node/no-sync': 'off',
'node/no-unpublished-import': 'off',
'node/no-unpublished-require': 'off',

2
app/scripts/controllers/detect-tokens.js
View File

@ -86,6 +86,7 @@ export default class DetectTokensController {
this.interval = DEFAULT_INTERVAL
}
/* eslint-disable accessor-pairs */
/**
* @type {Number}
*/
@ -162,4 +163,5 @@ export default class DetectTokensController {
get isActive () {
return this.isOpen && this.isUnlocked
}
/* eslint-enable accessor-pairs */
}

2
app/scripts/controllers/token-rates.js
View File

@ -46,6 +46,7 @@ export default class TokenRatesController {
this.store.putState({ contractExchangeRates })
}
/* eslint-disable accessor-pairs */
/**
* @type {Object}
*/
@ -68,6 +69,7 @@ export default class TokenRatesController {
this._tokens = tokens
this.updateExchangeRates()
}
/* eslint-enable accessor-pairs */
start (interval = DEFAULT_INTERVAL) {
this._handle && clearInterval(this._handle)

2
app/scripts/metamask-controller.js
View File

@ -2163,6 +2163,7 @@ export default class MetamaskController extends EventEmitter {
}
// TODO: Replace isClientOpen methods with `controllerConnectionChanged` events.
/* eslint-disable accessor-pairs */
/**
* A method for recording whether the MetaMask user interface is open or not.
* @private
@ -2172,6 +2173,7 @@ export default class MetamaskController extends EventEmitter {
this._isClientOpen = open
this.detectTokensController.isOpen = open
}
/* eslint-enable accessor-pairs */
/**
* Creates RPC engine middleware for processing eth_signTypedData requests