m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Merge pull request #242 from MetaMask/HashFix

Browse Source 
provider-engine hooked wallet - checkSum addresses not recognized
This commit is contained in:
kumavis 2016-06-02 19:06:46 -07:00
commit 6dec937c2a
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/unit/util_test.js
View File

@ -77,6 +77,13 @@ describe('util', function() {
assert.ok(!result) assert.ok(!result)
}) })
it('should recognize this sample hashed address', function() {
const address = '0x5Fda30Bb72B8Dfe20e48A00dFc108d0915BE9Bb0'
const result = util.isValidAddress(address)
const hashed = ethUtil.toChecksumAddress(address.toLowerCase())
assert.equal(hashed, address, 'example is hashed correctly')
assert.ok(result, 'is valid by our check')
})
}) })
describe('numericBalance', function() { describe('numericBalance', function() {

2
ui/app/util.js
View File

@ -52,7 +52,7 @@ function addressSummary(address) {
function isValidAddress(address) { function isValidAddress(address) {
var prefixed = ethUtil.addHexPrefix(address) var prefixed = ethUtil.addHexPrefix(address)
return isAllOneCase(prefixed) && ethUtil.isValidAddress(prefixed) || ethUtil.isValidChecksumAddress(prefixed) return (isAllOneCase(prefixed) && ethUtil.isValidAddress(prefixed)) || ethUtil.isValidChecksumAddress(prefixed)
} }
function isAllOneCase(address) { function isAllOneCase(address) {