From 68259ee3e261986f24261bff37b1fb298ac7aea9 Mon Sep 17 00:00:00 2001
From: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Date: Tue, 5 Oct 2021 15:20:42 -0400
Subject: [PATCH] UX Papercuts Epic: Create a consistent representation of the
Buttons (#12096)
---
test/e2e/metamask-ui.spec.js | 2 +-
test/e2e/tests/custom-rpc-history.spec.js | 6 +++---
test/e2e/tests/from-import-ui.spec.js | 2 +-
test/e2e/tests/incremental-security.spec.js | 2 +-
.../app/account-menu/account-menu.component.js | 5 +++--
ui/components/app/account-menu/account-menu.test.js | 3 ++-
ui/components/app/account-menu/index.scss | 6 +++---
.../invalid-custom-network-alert.scss | 1 -
.../unconnected-account-alert.js | 1 -
.../unconnected-account-alert.scss | 1 -
ui/components/app/app-components.scss | 1 +
ui/components/app/cancel-button/cancel-button.js | 5 ++---
.../confirm-page-container-content.component.js | 1 -
.../confirm-page-container.component.js | 1 -
ui/components/app/home-notification/index.scss | 2 --
ui/components/app/loading-network-screen/index.scss | 6 ++++++
.../loading-network-screen.component.js | 2 +-
.../metamask-template-renderer.stories.js | 2 --
ui/components/app/modal/modal.component.js | 9 ++-------
ui/components/app/modal/modal.component.test.js | 10 +++++-----
.../cancel-transaction/cancel-transaction.component.js | 1 -
.../confirm-delete-network.component.js | 2 +-
.../confirm-delete-network.test.js | 4 ++--
.../confirm-remove-account.component.js | 1 -
.../confirm-remove-account.test.js | 4 ++--
.../confirm-reset-account.component.js | 2 +-
.../confirm-reset-account.test.js | 6 ++++--
.../customize-nonce/customize-nonce.component.js | 3 ---
.../edit-approval-permission.component.js | 1 -
.../export-private-key-modal.component.js | 6 +++---
.../hide-token-confirmation-modal.js | 4 ++--
.../metametrics-opt-in-modal.component.js | 1 -
.../metametrics-opt-in-modal.test.js | 4 +++-
.../app/modals/qr-scanner/qr-scanner.component.js | 1 -
.../reject-transactions.component.js | 1 -
.../reject-transactions/reject-transactions.test.js | 4 ++--
.../transaction-confirmed.test.js | 4 +---
.../permission-page-container.component.js | 1 -
.../recovery-phrase-reminder.js | 2 +-
.../signature-request-original.component.js | 4 ++--
.../signature-request-footer/index.scss | 1 -
.../signature-request-footer.component.js | 2 +-
.../signature-request.container.test.js | 2 +-
.../app/transaction-list-item-details/index.scss | 7 ++++++-
.../transaction-list-item-details.component.js | 4 ++--
.../transaction-list-item.component.js | 3 +--
.../app/transaction-list/transaction-list.component.js | 1 -
ui/components/app/whats-new-popup/whats-new-popup.js | 1 -
ui/components/ui/button/button.component.js | 6 +++---
.../page-container-footer.component.js | 4 ++--
.../page-container-footer.component.test.js | 2 +-
.../ui/page-container/page-container.component.js | 1 -
.../truncated-definition-list.js | 1 -
ui/css/itcss/components/send.scss | 3 ++-
.../confirm-add-suggested-token.component.js | 4 ++--
.../confirm-decrypt-message.component.js | 4 ++--
.../confirm-encryption-public-key.component.js | 4 ++--
.../confirm-import-token.component.js | 4 ++--
.../confirmation-footer/confirmation-footer.js | 4 ++--
.../create-account/connect-hardware/account-list.js | 2 +-
ui/pages/create-account/import-account/json.js | 4 ++--
ui/pages/create-account/import-account/private-key.js | 4 ++--
ui/pages/create-account/new-account.component.js | 4 ++--
.../metametrics-opt-in/metametrics-opt-in.component.js | 1 -
.../metametrics-opt-in/metametrics-opt-in.test.js | 2 +-
ui/pages/keychains/index.scss | 5 +++++
ui/pages/keychains/restore-vault.js | 2 +-
ui/pages/keychains/reveal-seed.js | 8 ++++----
ui/pages/mobile-sync/mobile-sync.component.js | 8 ++++----
ui/pages/onboarding-flow/new-account/new-account.js | 1 -
.../recovery-phrase/confirm-recovery-phrase.js | 1 -
.../recovery-phrase/review-recovery-phrase.js | 2 --
.../choose-account/choose-account.component.js | 2 +-
ui/pages/permissions-connect/choose-account/index.scss | 2 +-
.../permissions-connect/permissions-connect.stories.js | 1 -
.../add-contact/add-contact.component.js | 1 -
.../contact-list-tab/contact-list-tab.component.js | 1 -
.../edit-contact/edit-contact.component.js | 1 -
ui/pages/settings/contact-list-tab/index.scss | 1 -
ui/pages/settings/networks-tab/index.scss | 4 ++--
.../network-form/network-form.component.js | 4 ++--
.../settings/networks-tab/networks-tab.component.js | 2 +-
ui/pages/swaps/import-token/import-token.js | 4 +---
.../item-list/item-list.component.js | 2 +-
ui/pages/swaps/select-quote-popover/index.scss | 1 -
.../swaps/select-quote-popover/select-quote-popover.js | 4 ++--
.../__snapshots__/swaps-footer.test.js.snap | 4 ++--
ui/pages/swaps/swaps-footer/swaps-footer.js | 1 -
ui/pages/unlock-page/index.scss | 1 +
ui/pages/unlock-page/unlock-page.component.js | 4 ++--
90 files changed, 122 insertions(+), 144 deletions(-)
create mode 100644 ui/components/app/loading-network-screen/index.scss
diff --git a/test/e2e/metamask-ui.spec.js b/test/e2e/metamask-ui.spec.js
index 74ea431f2..3f57d00ae 100644
--- a/test/e2e/metamask-ui.spec.js
+++ b/test/e2e/metamask-ui.spec.js
@@ -100,7 +100,7 @@ describe('MetaMask', function () {
});
it('clicks the "No thanks" option on the metametrics opt-in screen', async function () {
- await driver.clickElement('.btn-default');
+ await driver.clickElement('.btn-secondary');
await driver.delay(largeDelayMs);
});
diff --git a/test/e2e/tests/custom-rpc-history.spec.js b/test/e2e/tests/custom-rpc-history.spec.js
index 08a2bdd31..078cb124f 100644
--- a/test/e2e/tests/custom-rpc-history.spec.js
+++ b/test/e2e/tests/custom-rpc-history.spec.js
@@ -48,7 +48,7 @@ describe('Stores custom RPC history', function () {
await chainIdInput.clear();
await chainIdInput.sendKeys(chainId.toString());
- await driver.clickElement('.network-form__footer .btn-secondary');
+ await driver.clickElement('.network-form__footer .btn-primary');
await driver.findElement({ text: networkName, tag: 'span' });
},
);
@@ -192,7 +192,7 @@ describe('Stores custom RPC history', function () {
await driver.clickElement({ text: 'Custom RPC', tag: 'span' });
// cancel new custom rpc
- await driver.clickElement('.network-form__footer button.btn-default');
+ await driver.clickElement('.network-form__footer button.btn-secondary');
const networkListItems = await driver.findClickableElements(
'.networks-tab__networks-list-name',
@@ -209,7 +209,7 @@ describe('Stores custom RPC history', function () {
);
await driver.clickElement(
- '.button.btn-danger.modal-container__footer-button',
+ '.button.btn-danger-primary.modal-container__footer-button',
);
// wait for confirm delete modal to be removed from DOM.
diff --git a/test/e2e/tests/from-import-ui.spec.js b/test/e2e/tests/from-import-ui.spec.js
index 176b51e48..a7fba5982 100644
--- a/test/e2e/tests/from-import-ui.spec.js
+++ b/test/e2e/tests/from-import-ui.spec.js
@@ -38,7 +38,7 @@ describe('Metamask Import UI', function () {
await driver.clickElement({ text: 'Import wallet', tag: 'button' });
// clicks the "No thanks" option on the metametrics opt-in screen
- await driver.clickElement('.btn-default');
+ await driver.clickElement('.btn-secondary');
// Import Secret Recovery Phrase
await driver.fill(
diff --git a/test/e2e/tests/incremental-security.spec.js b/test/e2e/tests/incremental-security.spec.js
index 185a0d8c0..f6e5e5066 100644
--- a/test/e2e/tests/incremental-security.spec.js
+++ b/test/e2e/tests/incremental-security.spec.js
@@ -42,7 +42,7 @@ describe('Incremental Security', function () {
await driver.clickElement({ text: 'Create a Wallet', tag: 'button' });
// clicks the "No thanks" option on the metametrics opt-in screen
- await driver.clickElement('.btn-default');
+ await driver.clickElement('.btn-secondary');
// accepts a secure password
await driver.fill(
diff --git a/ui/components/app/account-menu/account-menu.component.js b/ui/components/app/account-menu/account-menu.component.js
index 41c809be8..c391a08aa 100644
--- a/ui/components/app/account-menu/account-menu.component.js
+++ b/ui/components/app/account-menu/account-menu.component.js
@@ -19,6 +19,7 @@ import {
} from '../../../helpers/constants/routes';
import TextField from '../../ui/text-field';
import SearchIcon from '../../ui/search-icon';
+import Button from '../../ui/button';
import { isBeta } from '../../../helpers/utils/build-types';
@@ -324,7 +325,7 @@ export default class AccountMenu extends Component {
{t('myAccounts')}
-
+
diff --git a/ui/components/app/account-menu/account-menu.test.js b/ui/components/app/account-menu/account-menu.test.js
index fc715ead1..501c187dd 100644
--- a/ui/components/app/account-menu/account-menu.test.js
+++ b/ui/components/app/account-menu/account-menu.test.js
@@ -3,6 +3,7 @@ import sinon from 'sinon';
import configureMockStore from 'redux-mock-store';
import { Provider } from 'react-redux';
import { mountWithRouter } from '../../../../test/lib/render-helpers';
+import Button from '../../ui/button';
import AccountMenu from '.';
describe('Account Menu', () => {
@@ -103,7 +104,7 @@ describe('Account Menu', () => {
let logout;
it('logout', () => {
- logout = wrapper.find('.account-menu__lock-button');
+ logout = wrapper.find(Button);
expect(logout).toHaveLength(1);
});
diff --git a/ui/components/app/account-menu/index.scss b/ui/components/app/account-menu/index.scss
index 8f1f5c8c8..18059a7e8 100644
--- a/ui/components/app/account-menu/index.scss
+++ b/ui/components/app/account-menu/index.scss
@@ -97,14 +97,14 @@
align-items: center;
}
- &__lock-button {
+ & &__lock-button {
@include H7;
- border: 1px solid $dusty-gray;
+ border: 1px solid $ui-white;
background-color: transparent;
color: $white;
- border-radius: 4px;
padding: 3.5px 24px;
+ width: 59px;
}
&__item-icon {
diff --git a/ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.scss b/ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.scss
index de7010883..a1a170466 100644
--- a/ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.scss
+++ b/ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.scss
@@ -37,7 +37,6 @@
& &-button {
height: 40px;
width: 50%;
- border-radius: 100px;
margin-right: 24px;
&:last-of-type {
diff --git a/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js b/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js
index 1b887bba4..cbcac50eb 100644
--- a/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js
+++ b/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js
@@ -76,7 +76,6 @@ const UnconnectedAccountAlert = () => {
disabled={alertState === LOADING}
onClick={onClose}
type="primary"
- rounded
className="unconnected-account-alert__dismiss-button"
>
{t('dismiss')}
diff --git a/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss b/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss
index 11c12f420..cedd14617 100644
--- a/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss
+++ b/ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss
@@ -22,7 +22,6 @@
height: 40px;
width: 100px;
border: 0;
- border-radius: 100px;
}
&__error {
diff --git a/ui/components/app/app-components.scss b/ui/components/app/app-components.scss
index aabadf245..d76c2998f 100644
--- a/ui/components/app/app-components.scss
+++ b/ui/components/app/app-components.scss
@@ -46,3 +46,4 @@
@import 'transaction-total-banner/index';
@import 'wallet-overview/index';
@import 'whats-new-popup/index';
+@import 'loading-network-screen/index'
diff --git a/ui/components/app/cancel-button/cancel-button.js b/ui/components/app/cancel-button/cancel-button.js
index bef23f98c..0efce2212 100644
--- a/ui/components/app/cancel-button/cancel-button.js
+++ b/ui/components/app/cancel-button/cancel-button.js
@@ -33,11 +33,10 @@ export default function CancelButton({
const btn = (