m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix PropType warning about quoteDataRows[0].rawNetworkFees (#9842)

Browse Source 
The property `quoteDataRows[0]rawNetworkFees` was described as a number
rather than a string. In practice it is a string in all cases. The
PropType and the tests have both been updated to expect it to be a
string.
This commit is contained in:
Mark Stacey 2020-11-10 14:17:55 -03:30 committed by GitHub
parent bcd5f2a7c1
commit 65fb18e1aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui/app/pages/swaps/select-quote-popover/mock-quote-data.js
View File

@ -8,7 +8,7 @@ const quoteDataRows = [
isBestQuote: false, isBestQuote: false,
networkFees: '$15.25', networkFees: '$15.25',
quoteSource: 'AGG', quoteSource: 'AGG',
rawNetworkFees: 10.25, rawNetworkFees: '10.25',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',
@ -23,7 +23,7 @@ const quoteDataRows = [
isBestQuote: false, isBestQuote: false,
networkFees: '$14.26', networkFees: '$14.26',
quoteSource: 'RFQ', quoteSource: 'RFQ',
rawNetworkFees: 10.26, rawNetworkFees: '10.26',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',
@ -38,7 +38,7 @@ const quoteDataRows = [
isBestQuote: false, isBestQuote: false,
networkFees: '$13.27', networkFees: '$13.27',
quoteSource: 'DEX', quoteSource: 'DEX',
rawNetworkFees: 10.27, rawNetworkFees: '10.27',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',
@ -53,7 +53,7 @@ const quoteDataRows = [
isBestQuote: true, isBestQuote: true,
networkFees: '$12.28', networkFees: '$12.28',
quoteSource: 'AGG', quoteSource: 'AGG',
rawNetworkFees: 10.28, rawNetworkFees: '10.28',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',
@ -68,7 +68,7 @@ const quoteDataRows = [
isBestQuote: false, isBestQuote: false,
networkFees: '$11.29', networkFees: '$11.29',
quoteSource: 'RFQ', quoteSource: 'RFQ',
rawNetworkFees: 10.29, rawNetworkFees: '10.29',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',
@ -83,7 +83,7 @@ const quoteDataRows = [
isBestQuote: false, isBestQuote: false,
networkFees: '$10.30', networkFees: '$10.30',
quoteSource: 'DEX', quoteSource: 'DEX',
rawNetworkFees: 10.3, rawNetworkFees: '10.3',
slippage: '1%', slippage: '1%',
sourceTokenDecimals: 18, sourceTokenDecimals: 18,
sourceTokenSymbol: 'ETH', sourceTokenSymbol: 'ETH',

2
ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js
View File

@ -9,7 +9,7 @@ export const QUOTE_DATA_ROWS_PROPTYPES_SHAPE = PropTypes.shape({
isBestQuote: PropTypes.bool, isBestQuote: PropTypes.bool,
networkFees: PropTypes.string.isRequired, networkFees: PropTypes.string.isRequired,
quoteSource: PropTypes.string.isRequired, quoteSource: PropTypes.string.isRequired,
rawNetworkFees: PropTypes.number.isRequired, rawNetworkFees: PropTypes.string.isRequired,
slippage: PropTypes.string.isRequired, slippage: PropTypes.string.isRequired,
sourceTokenDecimals: PropTypes.number.isRequired, sourceTokenDecimals: PropTypes.number.isRequired,
sourceTokenSymbol: PropTypes.string.isRequired, sourceTokenSymbol: PropTypes.string.isRequired,