m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Warn the user of insufficient funds when approving a token (#12496)

Browse Source 
* Warn the user of insufficient funds (ETH for gas) when approving a token

* Fixing code lines while run yarn lint:fix

* Fixing test-e2e-chrome

* Fixing e2e tests

* Create shouldDisplayWarning variable
This commit is contained in:
VSaric 2021-11-03 16:13:31 +01:00 committed by GitHub
parent 5f0fd9d1c2
commit 64e45c801d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ui/components/app/confirm-page-container/confirm-page-container.component.js
View File

@ -4,6 +4,7 @@ import SenderToRecipient from '../../ui/sender-to-recipient';
import { PageContainerFooter } from '../../ui/page-container'; import { PageContainerFooter } from '../../ui/page-container';
import EditGasPopover from '../edit-gas-popover'; import EditGasPopover from '../edit-gas-popover';
import { EDIT_GAS_MODES } from '../../../../shared/constants/gas'; import { EDIT_GAS_MODES } from '../../../../shared/constants/gas';
import ErrorMessage from '../../ui/error-message';
import Dialog from '../../ui/dialog'; import Dialog from '../../ui/dialog';
import { import {
ConfirmPageContainerHeader, ConfirmPageContainerHeader,
@ -124,6 +125,9 @@ export default class ConfirmPageContainer extends Component {
const showAddToAddressDialog = const showAddToAddressDialog =
!contact.name && toAddress && !isOwnedAccount && !hideSenderToRecipient; !contact.name && toAddress && !isOwnedAccount && !hideSenderToRecipient;
const shouldDisplayWarning =
contentComponent && disabled && (errorKey || errorMessage);
return ( return (
<div className="page-container"> <div className="page-container">
<ConfirmPageContainerNavigation <ConfirmPageContainerNavigation
@ -192,6 +196,11 @@ export default class ConfirmPageContainer extends Component {
ethGasPriceWarning={ethGasPriceWarning} ethGasPriceWarning={ethGasPriceWarning}
/> />
)} )}
{shouldDisplayWarning && (
<div className="confirm-approve-content__warning">
<ErrorMessage errorKey={errorKey} />
</div>
)}
{contentComponent && ( {contentComponent && (
<PageContainerFooter <PageContainerFooter
onCancel={onCancel} onCancel={onCancel}

4
ui/pages/confirm-approve/confirm-approve-content/index.scss
View File

@ -5,6 +5,10 @@
width: 100%; width: 100%;
font-style: normal; font-style: normal;
&__warning {
padding: 0 24px 16px 24px;
}
&__icon-display-content { &__icon-display-content {
display: flex; display: flex;
height: 51px; height: 51px;