m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00
Code

reducing logic gates in tx metrics (#15329)

Browse Source
This commit is contained in:
Brad Decker 2022-07-25 11:26:02 -05:00 committed by GitHub
parent 8536c86ed5
commit 6246f02932
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/scripts/controllers/transactions/index.js
View File

@ -1007,7 +1007,7 @@ export default class TransactionController extends EventEmitter {
* *
* @param {Object} txMeta - The txMeta object * @param {Object} txMeta - The txMeta object
* @param {string} getCodeResponse - The transaction category code response, used for debugging purposes * @param {string} getCodeResponse - The transaction category code response, used for debugging purposes
* @returns {Promise<Object>} Object containing the default gas limit, or the simulation failure object * @returns {Promise<object>} Object containing the default gas limit, or the simulation failure object
*/ */
async _getDefaultGasLimit(txMeta, getCodeResponse) { async _getDefaultGasLimit(txMeta, getCodeResponse) {
const chainId = this._getCurrentChainId(); const chainId = this._getCurrentChainId();
@ -2096,6 +2096,7 @@ export default class TransactionController extends EventEmitter {
].includes(type); ].includes(type);
let transactionType = TRANSACTION_TYPES.SIMPLE_SEND; let transactionType = TRANSACTION_TYPES.SIMPLE_SEND;
let transactionContractMethod;
if (type === TRANSACTION_TYPES.CANCEL) { if (type === TRANSACTION_TYPES.CANCEL) {
transactionType = TRANSACTION_TYPES.CANCEL; transactionType = TRANSACTION_TYPES.CANCEL;
} else if (type === TRANSACTION_TYPES.RETRY) { } else if (type === TRANSACTION_TYPES.RETRY) {
@ -2104,10 +2105,6 @@ export default class TransactionController extends EventEmitter {
transactionType = TRANSACTION_TYPES.DEPLOY_CONTRACT; transactionType = TRANSACTION_TYPES.DEPLOY_CONTRACT;
} else if (contractInteractionTypes) { } else if (contractInteractionTypes) {
transactionType = TRANSACTION_TYPES.CONTRACT_INTERACTION; transactionType = TRANSACTION_TYPES.CONTRACT_INTERACTION;
}
let transactionContractMethod;
if (transactionType === TRANSACTION_TYPES.CONTRACT_INTERACTION) {
transactionContractMethod = transactions[id]?.contractMethodName; transactionContractMethod = transactions[id]?.contractMethodName;
} }