m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Update eth_accounts permission description (#8693)

Browse Source 
* update eth_accounts permission description

* make it easier to find permission name locale message

* handle longer permissions descriptions in UI
This commit is contained in:
Erik Marks 2020-05-28 15:53:11 -07:00 committed by GitHub
parent 7ff3b4c928
commit 606618ee28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/_locales/en/messages.json
View File

@ -1,6 +1,6 @@
{ {
"eth_accounts": { "eth_accounts": {
"message": "View your public address (required)", "message": "View the addresses of your permitted accounts (required)",
"description": "The description for the `eth_accounts` permission" "description": "The description for the `eth_accounts` permission"
}, },
"connectedSites": { "connectedSites": {

6
ui/app/components/app/connected-accounts-list/connected-accounts-list-permissions/connected-accounts-list-permissions.component.js
View File

@ -55,9 +55,9 @@ export default class ConnectedAccountsListPermissions extends PureComponent {
> >
<p>{t('authorizedPermissions')}:</p> <p>{t('authorizedPermissions')}:</p>
<ul className="connected-accounts-permissions__list"> <ul className="connected-accounts-permissions__list">
{permissions.map(({ key }) => ( {permissions.map(({ key: permissionName }) => (
<li key={key} className="connected-accounts-permissions__list-item"> <li key={permissionName} className="connected-accounts-permissions__list-item">
<i className="fas fa-check-square" />&nbsp;{t(key)} <i className="fas fa-check-square" />{t(permissionName)}
</li> </li>
))} ))}
</ul> </ul>

3
ui/app/components/app/connected-accounts-list/index.scss
View File

@ -113,7 +113,10 @@
} }
&__list-item { &__list-item {
display: flex;
i { i {
display: block;
padding-right: 8px; padding-right: 8px;
font-size: 18px; font-size: 18px;
color: $Grey-800; color: $Grey-800;

12
ui/app/components/app/permission-page-container/permission-page-container-content/permission-page-container-content.component.js
View File

@ -67,23 +67,23 @@ export default class PermissionPageContainerContent extends PureComponent {
} = this.props } = this.props
const { t } = this.context const { t } = this.context
const items = Object.keys(selectedPermissions).map((methodName) => { const items = Object.keys(selectedPermissions).map((permissionName) => {
const description = t(methodName) const description = t(permissionName)
// don't allow deselecting eth_accounts // don't allow deselecting eth_accounts
const isDisabled = methodName === 'eth_accounts' const isDisabled = permissionName === 'eth_accounts'
return ( return (
<div <div
className="permission-approval-container__content__permission" className="permission-approval-container__content__permission"
key={methodName} key={permissionName}
onClick={() => { onClick={() => {
if (!isDisabled) { if (!isDisabled) {
onPermissionToggle(methodName) onPermissionToggle(permissionName)
} }
}} }}
> >
{ selectedPermissions[methodName] { selectedPermissions[permissionName]
? <i title={t('permissionCheckedIconDescription')} className="fa fa-check-square" /> ? <i title={t('permissionCheckedIconDescription')} className="fa fa-check-square" />
: <i title={t('permissionUncheckedIconDescription')} className="fa fa-square" /> : <i title={t('permissionUncheckedIconDescription')} className="fa fa-square" />
} }