m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Code

Improve slippage input validation in Swaps (#13914)

Browse Source 
* Improve client-side validation for the slippage input

* Improve validation of the slippage input field

* Use Number instead of toNumber
This commit is contained in:
Daniel 2022-03-14 15:41:03 +01:00 committed by GitHub
parent 466379b325
commit 5aff1863ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui/pages/swaps/slippage-buttons/slippage-buttons.js
View File

@ -166,11 +166,15 @@ export default function SlippageButtons({
> >
<input <input
onChange={(event) => { onChange={(event) => {
setCustomValue(event.target.value); const { value } = event.target;
onSelect(Number(event.target.value)); const isValueNumeric = !isNaN(Number(value));
if (isValueNumeric) {
setCustomValue(value);
onSelect(Number(value));
}
}} }}
type="number" type="text"
step="0.1" maxLength="4"
ref={setInputRef} ref={setInputRef}
onBlur={() => { onBlur={() => {
setEnteringCustomValue(false); setEnteringCustomValue(false);