m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

add back error when password is too short (#16876)

Browse Source
This commit is contained in:
Alex Donesky 2022-12-14 19:20:55 -06:00 committed by seaona
parent 3859c25cac
commit 5accaf88b9
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui/pages/onboarding-flow/create-password/create-password.js
View File

@ -85,13 +85,14 @@ export default function CreatePassword({
const handlePasswordChange = (passwordInput) => { const handlePasswordChange = (passwordInput) => {
let confirmError = ''; let confirmError = '';
let passwordInputError = '';
const passwordEvaluation = zxcvbn(passwordInput); const passwordEvaluation = zxcvbn(passwordInput);
const passwordStrengthLabel = getPasswordStrengthLabel( const passwordStrengthLabel = getPasswordStrengthLabel(
passwordEvaluation.score, passwordEvaluation.score,
t, t,
); );
const passwordStrengthDescription = passwordStrengthLabel.description; let passwordStrengthDescription = passwordStrengthLabel.description;
const passwordStrengthInput = t('passwordStrength', [ let passwordStrengthInput = t('passwordStrength', [
<span <span
key={passwordEvaluation.score} key={passwordEvaluation.score}
className={passwordStrengthLabel.className} className={passwordStrengthLabel.className}
@ -100,11 +101,20 @@ export default function CreatePassword({
</span>, </span>,
]); ]);
if (passwordInput.length < 8) {
passwordInputError = passwordInput.length
? t('passwordNotLongEnough')
: '';
passwordStrengthInput = null;
passwordStrengthDescription = '';
}
if (confirmPassword && passwordInput !== confirmPassword) { if (confirmPassword && passwordInput !== confirmPassword) {
confirmError = t('passwordsDontMatch'); confirmError = t('passwordsDontMatch');
} }
setPassword(passwordInput); setPassword(passwordInput);
setPasswordError(passwordInputError);
setPasswordStrength(passwordStrengthInput); setPasswordStrength(passwordStrengthInput);
setPasswordStrengthText(passwordStrengthDescription); setPasswordStrengthText(passwordStrengthDescription);
setConfirmPasswordError(confirmError); setConfirmPasswordError(confirmError);
@ -175,6 +185,7 @@ export default function CreatePassword({
<FormField <FormField
dataTestId="create-password-new" dataTestId="create-password-new"
autoFocus autoFocus
error={passwordError}
passwordStrength={passwordStrength} passwordStrength={passwordStrength}
passwordStrengthText={passwordStrengthText} passwordStrengthText={passwordStrengthText}
onChange={handlePasswordChange} onChange={handlePasswordChange}