diff --git a/app/scripts/background.js b/app/scripts/background.js index 99242f871..c57710bd2 100644 --- a/app/scripts/background.js +++ b/app/scripts/background.js @@ -225,10 +225,7 @@ function setupController(initState, initLangCode) { const controller = new MetamaskController({ infuraProjectId: process.env.INFURA_PROJECT_ID, // User confirmation callbacks: - showUnconfirmedMessage: triggerUi, - showUnapprovedTx: triggerUi, - showPermissionRequest: triggerUi, - showUnlockRequest: triggerUi, + showUserConfirmation: triggerUi, openPopup, // initial state initState, diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 41cb53d75..e6678054d 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -150,7 +150,7 @@ export default class MetamaskController extends EventEmitter { isUnlocked: this.isUnlocked.bind(this), initState: initState.AppStateController, onInactiveTimeout: () => this.setLocked(), - showUnlockRequest: opts.showUnlockRequest, + showUnlockRequest: opts.showUserConfirmation, preferencesStore: this.preferencesController.store, }) @@ -247,7 +247,7 @@ export default class MetamaskController extends EventEmitter { notifyDomain: this.notifyConnections.bind(this), notifyAllDomains: this.notifyAllConnections.bind(this), preferences: this.preferencesController.store, - showPermissionRequest: opts.showPermissionRequest, + showPermissionRequest: opts.showUserConfirmation, }, initState.PermissionsController, initState.PermissionsMetadata, @@ -302,7 +302,7 @@ export default class MetamaskController extends EventEmitter { getParticipateInMetrics: () => this.preferencesController.getParticipateInMetaMetrics(), }) - this.txController.on('newUnapprovedTx', () => opts.showUnapprovedTx()) + this.txController.on('newUnapprovedTx', () => opts.showUserConfirmation()) this.txController.on(`tx:status-update`, async (txId, status) => { if ( @@ -1376,7 +1376,7 @@ export default class MetamaskController extends EventEmitter { req, ) this.sendUpdate() - this.opts.showUnconfirmedMessage() + this.opts.showUserConfirmation() return promise } @@ -1439,7 +1439,7 @@ export default class MetamaskController extends EventEmitter { req, ) this.sendUpdate() - this.opts.showUnconfirmedMessage() + this.opts.showUserConfirmation() return promise } @@ -1498,7 +1498,7 @@ export default class MetamaskController extends EventEmitter { req, ) this.sendUpdate() - this.opts.showUnconfirmedMessage() + this.opts.showUserConfirmation() return promise } @@ -1590,7 +1590,7 @@ export default class MetamaskController extends EventEmitter { req, ) this.sendUpdate() - this.opts.showUnconfirmedMessage() + this.opts.showUserConfirmation() return promise } @@ -1655,7 +1655,7 @@ export default class MetamaskController extends EventEmitter { version, ) this.sendUpdate() - this.opts.showUnconfirmedMessage() + this.opts.showUserConfirmation() return promise } diff --git a/test/unit/app/controllers/metamask-controller-test.js b/test/unit/app/controllers/metamask-controller-test.js index 2a7978293..09b8ffac7 100644 --- a/test/unit/app/controllers/metamask-controller-test.js +++ b/test/unit/app/controllers/metamask-controller-test.js @@ -97,8 +97,7 @@ describe('MetaMaskController', function () { .reply(200, '{"JPY":12415.9}') metamaskController = new MetaMaskController({ - showUnapprovedTx: noop, - showUnconfirmedMessage: noop, + showUserConfirmation: noop, encryptor: { encrypt(_, object) { this.object = object diff --git a/test/unit/ui/app/actions.spec.js b/test/unit/ui/app/actions.spec.js index 928bf2012..d487d825e 100644 --- a/test/unit/ui/app/actions.spec.js +++ b/test/unit/ui/app/actions.spec.js @@ -44,8 +44,7 @@ describe('Actions', function () { platform: { getVersion: () => 'foo' }, provider, keyringController: new KeyringController({}), - showUnapprovedTx: noop, - showUnconfirmedMessage: noop, + showUserConfirmation: noop, encryptor: { encrypt(_, object) { this.object = object