From 583b404e02192f87d33b1bb81358ca4e24295354 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Mon, 27 Jan 2020 12:45:48 -0400 Subject: [PATCH] Switch to full lodash package, and update lodash (#7907) * Update lodash All versions of the full `lodash` package have been updated to 4.17.15. The only exception is v4.17.14 which is pinned by `ganache-core`. * Switch to using `lodash` instead of per-method packages We have the full lodash package _ten times_ as a production transitive dependency, so including per-method packages is not saving space (it might instead result in slightly more space being used). --- gulpfile.js | 2 +- package.json | 6 ++---- .../app/account-menu/account-menu.component.js | 2 +- .../advanced-gas-inputs.component.js | 2 +- .../confirm-seed-phrase.component.js | 2 +- .../send-amount-row/send-amount-row.component.js | 2 +- ui/app/pages/send/send.component.js | 2 +- .../add-contact/add-contact.component.js | 2 +- yarn.lock | 11 +++-------- 9 files changed, 12 insertions(+), 19 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index b21eecda9..4a7c3a471 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -9,7 +9,7 @@ const watch = require('gulp-watch') const sourcemaps = require('gulp-sourcemaps') const jsoneditor = require('gulp-json-editor') const zip = require('gulp-zip') -const assign = require('lodash.assign') +const { assign } = require('lodash') const livereload = require('gulp-livereload') const del = require('del') const manifest = require('./app/manifest.json') diff --git a/package.json b/package.json index 2c28f734a..9d9bdd9d9 100644 --- a/package.json +++ b/package.json @@ -60,7 +60,7 @@ "generate:migration": "./development/generate-migration.sh" }, "resolutions": { - "3box/ipfs/ipld-zcash/zcash-bitcore-lib/lodash": "^4.17.12", + "3box/ipfs/ipld-zcash/zcash-bitcore-lib/lodash": "^4.17.15", "pubnub/superagent-proxy": "^2.0.0" }, "dependencies": { @@ -127,8 +127,7 @@ "json-rpc-engine": "^5.1.6", "json-rpc-middleware-stream": "^2.1.1", "jsonschema": "^1.2.4", - "lodash.debounce": "^4.0.8", - "lodash.shuffle": "^4.2.0", + "lodash": "^4.17.15", "loglevel": "^1.4.1", "luxon": "^1.8.2", "metamask-inpage-provider": "^4.0.3", @@ -267,7 +266,6 @@ "karma-qunit": "^1.2.1", "koa": "^2.7.0", "lockfile-lint": "^3.0.5", - "lodash.assign": "^4.0.6", "mocha": "^5.0.0", "mocha-eslint": "^4.0.0", "mocha-jsdom": "^1.1.0", diff --git a/ui/app/components/app/account-menu/account-menu.component.js b/ui/app/components/app/account-menu/account-menu.component.js index 5ac9814de..523aaea9d 100644 --- a/ui/app/components/app/account-menu/account-menu.component.js +++ b/ui/app/components/app/account-menu/account-menu.component.js @@ -1,6 +1,6 @@ import React, { Component } from 'react' import PropTypes from 'prop-types' -import debounce from 'lodash.debounce' +import { debounce } from 'lodash' import Fuse from 'fuse.js' import InputAdornment from '@material-ui/core/InputAdornment' diff --git a/ui/app/components/app/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js b/ui/app/components/app/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js index b881db6e5..9c3432e5c 100644 --- a/ui/app/components/app/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js +++ b/ui/app/components/app/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js @@ -1,7 +1,7 @@ import React, { Component } from 'react' import PropTypes from 'prop-types' import classnames from 'classnames' -import debounce from 'lodash.debounce' +import { debounce } from 'lodash' export default class AdvancedGasInputs extends Component { static contextTypes = { diff --git a/ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/confirm-seed-phrase.component.js b/ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/confirm-seed-phrase.component.js index 6642e1e7d..2b6d5ceee 100644 --- a/ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/confirm-seed-phrase.component.js +++ b/ui/app/pages/first-time-flow/seed-phrase/confirm-seed-phrase/confirm-seed-phrase.component.js @@ -1,7 +1,7 @@ import React, { PureComponent } from 'react' import PropTypes from 'prop-types' import classnames from 'classnames' -import shuffle from 'lodash.shuffle' +import { shuffle } from 'lodash' import Button from '../../../../components/ui/button' import { INITIALIZE_END_OF_FLOW_ROUTE, diff --git a/ui/app/pages/send/send-content/send-amount-row/send-amount-row.component.js b/ui/app/pages/send/send-content/send-amount-row/send-amount-row.component.js index d6fd5f02d..bc4eea6af 100644 --- a/ui/app/pages/send/send-content/send-amount-row/send-amount-row.component.js +++ b/ui/app/pages/send/send-content/send-amount-row/send-amount-row.component.js @@ -1,6 +1,6 @@ import React, { Component } from 'react' import PropTypes from 'prop-types' -import debounce from 'lodash.debounce' +import { debounce } from 'lodash' import SendRowWrapper from '../send-row-wrapper' import AmountMaxButton from './amount-max-button' import UserPreferencedCurrencyInput from '../../../../components/app/user-preferenced-currency-input' diff --git a/ui/app/pages/send/send.component.js b/ui/app/pages/send/send.component.js index 3507c1cf1..f9e2e0643 100644 --- a/ui/app/pages/send/send.component.js +++ b/ui/app/pages/send/send.component.js @@ -6,7 +6,7 @@ import { getToAddressForGasUpdate, doesAmountErrorRequireUpdate, } from './send.utils' -import debounce from 'lodash.debounce' +import { debounce } from 'lodash' import { getToWarningObject, getToErrorObject } from './send-content/add-recipient/add-recipient' import SendHeader from './send-header' import AddRecipient from './send-content/add-recipient' diff --git a/ui/app/pages/settings/contact-list-tab/add-contact/add-contact.component.js b/ui/app/pages/settings/contact-list-tab/add-contact/add-contact.component.js index 6411883c3..cd55eb656 100644 --- a/ui/app/pages/settings/contact-list-tab/add-contact/add-contact.component.js +++ b/ui/app/pages/settings/contact-list-tab/add-contact/add-contact.component.js @@ -6,7 +6,7 @@ import { CONTACT_LIST_ROUTE } from '../../../../helpers/constants/routes' import { isValidAddress, isValidENSAddress } from '../../../../helpers/utils/util' import EnsInput from '../../../send/send-content/add-recipient/ens-input' import PageContainerFooter from '../../../../components/ui/page-container/page-container-footer' -import debounce from 'lodash.debounce' +import { debounce } from 'lodash' export default class AddContact extends PureComponent { diff --git a/yarn.lock b/yarn.lock index 8cd3bdc6a..f67d4ef5a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -18734,7 +18734,7 @@ lodash.assign@^3.0.0: lodash._createassigner "^3.0.0" lodash.keys "^3.0.0" -lodash.assign@^4.0.1, lodash.assign@^4.0.6, lodash.assign@^4.2.0: +lodash.assign@^4.0.1, lodash.assign@^4.2.0: version "4.2.0" resolved "https://registry.yarnpkg.com/lodash.assign/-/lodash.assign-4.2.0.tgz#0d99f3ccd7a6d261d19bdaeb9245005d285808e7" integrity sha1-DZnzzNem0mHRm9rrkkUAXShYCOc= @@ -18913,11 +18913,6 @@ lodash.restparam@^3.0.0: resolved "https://registry.yarnpkg.com/lodash.restparam/-/lodash.restparam-3.6.1.tgz#936a4e309ef330a7645ed4145986c85ae5b20805" integrity sha1-k2pOMJ7zMKdkXtQUWYbIWuWyCAU= -lodash.shuffle@^4.2.0: - version "4.2.0" - resolved "https://registry.yarnpkg.com/lodash.shuffle/-/lodash.shuffle-4.2.0.tgz#145b5053cf875f6f5c2a33f48b6e9948c6ec7b4b" - integrity sha1-FFtQU8+HX29cKjP0i26ZSMbse0s= - lodash.some@^4.6.0: version "4.6.0" resolved "https://registry.yarnpkg.com/lodash.some/-/lodash.some-4.6.0.tgz#1bb9f314ef6b8baded13b549169b2a945eb68e4d" @@ -18966,12 +18961,12 @@ lodash.uniqby@^4.7.0: resolved "https://registry.yarnpkg.com/lodash.uniqby/-/lodash.uniqby-4.7.0.tgz#d99c07a669e9e6d24e1362dfe266c67616af1302" integrity sha1-2ZwHpmnp5tJOE2Lf4mbGdhavEwI= -lodash@4.17.14, lodash@^4.0.0, lodash@^4.0.1, lodash@^4.13.1, lodash@^4.14.0, lodash@^4.15.0, lodash@^4.17.4, lodash@^4.17.5, lodash@^4.2.0, lodash@^4.2.1, lodash@^4.3.0, lodash@^4.8.0, lodash@~4.17.10, lodash@~4.17.2, lodash@~4.17.4: +lodash@4.17.14: version "4.17.14" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.14.tgz#9ce487ae66c96254fe20b599f21b6816028078ba" integrity sha512-mmKYbW3GLuJeX+iGP+Y7Gp1AiGHGbXHCOh/jZmrawMmsE7MS4znI3RL2FsjbqOyMayHInjOeykW7PEajUk1/xw== -lodash@=3.10.1, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.12, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15: +lodash@=3.10.1, lodash@^4.0.0, lodash@^4.0.1, lodash@^4.13.1, lodash@^4.14.0, lodash@^4.15.0, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.4, lodash@^4.17.5, lodash@^4.2.0, lodash@^4.2.1, lodash@^4.3.0, lodash@^4.8.0, lodash@~4.17.10, lodash@~4.17.2, lodash@~4.17.4: version "4.17.15" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz#b447f6670a0455bbfeedd11392eff330ea097548" integrity sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==