m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Merge pull request #4139 from MetaMask/sentry-enhancements

Browse Source 
Sentry enhancements
This commit is contained in:
Thomas Huang 2018-04-30 13:19:45 -07:00 committed by GitHub
commit 5736a1f46d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
app/scripts/lib/setupRaven.js
View File

@ -23,23 +23,16 @@ function setupRaven(opts) {
release, release,
transport: function(opts) { transport: function(opts) {
const report = opts.data const report = opts.data
// simplify certain complex error messages try {
if (report.exception && report.exception.values) { // handle error-like non-error exceptions
report.exception.values.forEach(item => { nonErrorException(report)
let errorMessage = item.value // simplify certain complex error messages (e.g. Ethjs)
// simplify ethjs error messages simplifyErrorMessages(report)
errorMessage = extractEthjsErrorMessage(errorMessage) // modify report urls
// simplify 'Transaction Failed: known transaction' rewriteReportUrls(report)
if (errorMessage.indexOf('Transaction Failed: known transaction') === 0) { } catch (err) {
// cut the hash from the error message console.warn(err)
errorMessage = 'Transaction Failed: known transaction'
}
// finalize
item.value = errorMessage
})
} }
// modify report urls
rewriteReportUrls(report)
// make request normally // make request normally
client._makeRequest(opts) client._makeRequest(opts)
}, },
@ -49,6 +42,31 @@ function setupRaven(opts) {
return Raven return Raven
} }
function nonErrorException(report) {
// handle errors that lost their error-ness in serialization
if (report.message.includes('Non-Error exception captured with keys: message')) {
if (!(report.extra && report.extra.__serialized__)) return
report.message = `Non-Error Exception: ${report.extra.__serialized__.message}`
}
}
function simplifyErrorMessages(report) {
if (report.exception && report.exception.values) {
report.exception.values.forEach(item => {
let errorMessage = item.value
// simplify ethjs error messages
errorMessage = extractEthjsErrorMessage(errorMessage)
// simplify 'Transaction Failed: known transaction'
if (errorMessage.indexOf('Transaction Failed: known transaction') === 0) {
// cut the hash from the error message
errorMessage = 'Transaction Failed: known transaction'
}
// finalize
item.value = errorMessage
})
}
}
function rewriteReportUrls(report) { function rewriteReportUrls(report) {
// update request url // update request url
report.request.url = toMetamaskUrl(report.request.url) report.request.url = toMetamaskUrl(report.request.url)