m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Revert "Added "What's New" Notification for Improved token allowance experience (#16465)"

Browse Source 
This reverts commit f9ed4a560b.
This commit is contained in:
Dan J Miller 2022-12-06 07:16:10 -03:30
parent e3533878f4
commit 5678becb5c
5 changed files with 6 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/_locales/en/messages.json generated
View File

@ -2395,15 +2395,6 @@
"notifications15Title": { "notifications15Title": {
"message": "The Ethereum Merge is here!" "message": "The Ethereum Merge is here!"
}, },
"notifications16ActionText": {
"message": "Try it out here"
},
"notifications16Description": {
"message": "We redesigned our token allowance confirmation to help you make more informed decisions."
},
"notifications16Title": {
"message": "Improved token allowance experience"
},
"notifications1Description": { "notifications1Description": {
"message": "MetaMask Mobile users can now swap tokens inside their mobile wallet. Scan the QR code to get the mobile app and start swapping.", "message": "MetaMask Mobile users can now swap tokens inside their mobile wallet. Scan the QR code to get the mobile app and start swapping.",
"description": "Description of a notification in the 'See What's New' popup. Describes the swapping on mobile feature." "description": "Description of a notification in the 'See What's New' popup. Describes the swapping on mobile feature."

15
shared/notifications/index.js
View File

@ -78,10 +78,6 @@ export const UI_NOTIFICATIONS = {
id: 15, id: 15,
date: '2022-09-15', date: '2022-09-15',
}, },
16: {
id: 16,
date: null,
},
}; };
export const getTranslatedUINotifications = (t, locale) => { export const getTranslatedUINotifications = (t, locale) => {
@ -228,16 +224,5 @@ export const getTranslatedUINotifications = (t, locale) => {
) )
: '', : '',
}, },
16: {
...UI_NOTIFICATIONS[16],
title: t('notifications16Title'),
description: t('notifications16Description'),
actionText: t('notifications16ActionText'),
date: UI_NOTIFICATIONS[16].date
? new Intl.DateTimeFormat(formattedLocale).format(
new Date(UI_NOTIFICATIONS[16].date),
)
: '',
},
}; };
}; };

11
test/e2e/fixture-builder.js
View File

@ -74,12 +74,12 @@ function defaultFixture() {
src: 'images/token-detection.svg', src: 'images/token-detection.svg',
width: '100%', width: '100%',
}, },
isShown: false, isShown: true,
}, },
11: { 11: {
date: '2022-09-15', date: '2022-09-15',
id: 11, id: 11,
isShown: false, isShown: true,
}, },
12: { 12: {
date: '2022-05-18', date: '2022-05-18',
@ -98,16 +98,11 @@ function defaultFixture() {
14: { 14: {
date: '2022-09-15', date: '2022-09-15',
id: 14, id: 14,
isShown: false, isShown: true,
}, },
15: { 15: {
date: '2022-09-15', date: '2022-09-15',
id: 15, id: 15,
isShown: false,
},
16: {
date: null,
id: 16,
isShown: true, isShown: true,
}, },
}, },

4
ui/components/app/whats-new-popup/whats-new-popup.js
View File

@ -58,10 +58,6 @@ function getActionFunctionById(id, history) {
updateViewedNotifications({ 14: true }); updateViewedNotifications({ 14: true });
history.push(`${ADVANCED_ROUTE}#backup-userdata`); history.push(`${ADVANCED_ROUTE}#backup-userdata`);
}, },
16: () => {
updateViewedNotifications({ 16: true });
history.push(EXPERIMENTAL_ROUTE);
},
}; };
return actionFunctions[id]; return actionFunctions[id];

7
ui/selectors/selectors.js
View File

@ -956,13 +956,12 @@ function getAllowedAnnouncementIds(state) {
7: false, 7: false,
8: supportsWebHid && currentKeyringIsLedger && currentlyUsingLedgerLive, 8: supportsWebHid && currentKeyringIsLedger && currentlyUsingLedgerLive,
9: false, 9: false,
10: false, 10: true,
11: false, 11: true,
12: false, 12: false,
13: false, 13: false,
14: false, 14: false,
15: false, 15: true,
16: true,
}; };
} }