1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 11:22:43 +02:00

Use better value for average savings analytics (#9733)

This commit is contained in:
Dan J Miller 2020-10-27 16:42:06 -02:30 committed by GitHub
parent a4f817e171
commit 557f9550d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -23,7 +23,7 @@ import {
import { AWAITING_SWAP_ROUTE, BUILD_QUOTE_ROUTE, LOADING_QUOTES_ROUTE, SWAPS_ERROR_ROUTE, SWAPS_MAINTENANCE_ROUTE } from '../../helpers/constants/routes'
import { fetchSwapsFeatureLiveness } from '../../pages/swaps/swaps.util'
import { calcGasTotal } from '../../pages/send/send.utils'
import { decimalToHex, getValueFromWeiHex, hexMax, decGWEIToHexWEI, hexToDecimal, decEthToConvertedCurrency, hexWEIToDecGWEI } from '../../helpers/utils/conversions.util'
import { decimalToHex, getValueFromWeiHex, hexMax, decGWEIToHexWEI, hexToDecimal, hexWEIToDecGWEI } from '../../helpers/utils/conversions.util'
import { calcTokenAmount } from '../../helpers/utils/token-util'
import {
getFastPriceEstimateInHexWEI,
@ -462,13 +462,7 @@ export const signAndSendTransactions = (history, metaMetricsEvent) => {
conversionRate,
numberOfDecimals: 6,
})
const averageSavings = usedQuote.isBestQuote
? decEthToConvertedCurrency(
usedQuote.savings?.total,
'usd',
conversionRate,
)
: null
const swapMetaData = {
token_from: sourceTokenInfo.symbol,
token_from_amount: String(swapTokenValue),
@ -484,7 +478,7 @@ export const signAndSendTransactions = (history, metaMetricsEvent) => {
estimated_gas: estimatedGasLimit.toString(10),
suggested_gas_price: hexWEIToDecGWEI(usedGasPrice),
used_gas_price: hexWEIToDecGWEI(fastGasEstimate),
average_savings: averageSavings,
average_savings: usedQuote.savings?.performance,
}
const metaMetricsConfig = {