m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix 787 gas buffer bug

Browse Source
This commit is contained in:
Dan Finlay 2016-11-07 12:00:14 -08:00
parent fc26a0a899
commit 553a6da011
2 changed files with 25 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/scripts/keyring-controller.js
View File

@ -533,11 +533,11 @@ module.exports = class KeyringController extends EventEmitter {
} }
} }
addGasBuffer(gasHex) { addGasBuffer(gas) {
var gas = new BN(gasHex, 16) const gasBuffer = new BN('100000', 10)
var buffer = new BN('100000', 10) const bnGas = new BN(ethUtil.stripHexPrefix(gas), 16)
var result = gas.add(buffer) const correct = bnGas.add(gasBuffer)
return normalize(result.toString(16)) return ethUtil.addHexPrefix(correct.toString(16))
} }
clearSeedWordCache(cb) { clearSeedWordCache(cb) {

24
test/unit/keyring-controller-test.js
View File

@ -147,9 +147,25 @@ describe('KeyringController', function() {
}) })
}) })
describe('#addGasBuffer', function() {
it('adds 100k gas buffer to estimates', function() {
const gas = '0x04ee59' // Actual estimated gas example
const tooBigOutput = '0x80674f9' // Actual bad output
const bnGas = new BN(ethUtil.stripHexPrefix(gas), 16)
const correctBuffer = new BN('100000', 10)
const correct = bnGas.add(correctBuffer)
const tooBig = new BN(tooBigOutput, 16)
const result = keyringController.addGasBuffer(gas)
const bnResult = new BN(ethUtil.stripHexPrefix(result), 16)
assert.equal(result.indexOf('0x'), 0, 'included hex prefix')
assert(bnResult.gt(bnGas), 'Estimate increased in value.')
assert.equal(bnResult.sub(bnGas).toString(10), '100000', 'added 100k gas')
assert.equal(result, '0x' + correct.toString(16), 'Added the right amount')
assert.notEqual(result, tooBigOutput, 'not that bad estimate')
})
})
}) })