m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

NFTs: Hide detail when no thumbnail available (#17693)

Browse Source
This commit is contained in:
David Walsh 2023-02-10 08:05:51 -06:00 committed by GitHub
parent e269790ff4
commit 50937dcfde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ui/components/app/nft-details/__snapshots__/nft-details.test.js.snap
View File

@ -96,25 +96,6 @@ exports[`Collectible Details should match minimal props and state snapshot 1`] =
</a> </a>
</h6> </h6>
</div> </div>
<div
class="box box--display-flex box--flex-direction-row"
>
<h6
class="box box--margin-top-1 box--margin-right-2 box--margin-bottom-4 box--flex-direction-row typography collectible-details__link-title typography--h6 typography--weight-bold typography--style-normal typography--color-text-default"
>
Link
</h6>
<h6
class="box box--margin-top-1 box--margin-bottom-4 box--flex-direction-row typography collectible-details__image-source typography--h6 typography--weight-normal typography--style-normal typography--color-primary-default"
>
<a
href="https://bafybeiclzx7zfjvuiuwobn5ip3ogc236bjqfjzoblumf4pau4ep6dqramu.ipfs.dweb.link"
rel="noopener noreferrer"
target="_blank"
title="https://bafybeiclzx7zfjvuiuwobn5ip3ogc236bjqfjzoblumf4pau4ep6dqramu.ipfs.dweb.link"
/>
</h6>
</div>
<div <div
class="box box--display-flex box--flex-direction-row" class="box box--display-flex box--flex-direction-row"
> >

70
ui/components/app/nft-details/nft-details.js
View File

@ -344,41 +344,43 @@ export default function CollectibleDetails({ collectible }) {
)} )}
</Typography> </Typography>
</Box> </Box>
<Box display={DISPLAY.FLEX} flexDirection={FLEX_DIRECTION.ROW}> {imageThumbnail ? (
<Typography <Box display={DISPLAY.FLEX} flexDirection={FLEX_DIRECTION.ROW}>
color={TextColor.textDefault} <Typography
variant={TypographyVariant.H6} color={TextColor.textDefault}
fontWeight={FONT_WEIGHT.BOLD} variant={TypographyVariant.H6}
boxProps={{ fontWeight={FONT_WEIGHT.BOLD}
margin: 0, boxProps={{
marginBottom: 4, margin: 0,
marginRight: 2, marginBottom: 4,
}} marginRight: 2,
className="collectible-details__link-title" }}
> className="collectible-details__link-title"
{t('link')}
</Typography>
<Typography
variant={TypographyVariant.H6}
boxProps={{
margin: 0,
marginBottom: 4,
}}
className="collectible-details__image-source"
color={
isDataURI ? TextColor.textDefault : TextColor.primaryDefault
}
>
<a
target="_blank"
rel="noopener noreferrer"
href={collectibleImageURL}
title={collectibleImageURL}
> >
{imageThumbnail} {t('link')}
</a> </Typography>
</Typography> <Typography
</Box> variant={TypographyVariant.H6}
boxProps={{
margin: 0,
marginBottom: 4,
}}
className="collectible-details__image-source"
color={
isDataURI ? TextColor.textDefault : TextColor.primaryDefault
}
>
<a
target="_blank"
rel="noopener noreferrer"
href={collectibleImageURL}
title={collectibleImageURL}
>
{imageThumbnail}
</a>
</Typography>
</Box>
) : null}
<Box display={DISPLAY.FLEX} flexDirection={FLEX_DIRECTION.ROW}> <Box display={DISPLAY.FLEX} flexDirection={FLEX_DIRECTION.ROW}>
<Typography <Typography
color={TextColor.textDefault} color={TextColor.textDefault}