m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Update "NFT Added" events (#19796)

Browse Source 
* Update NFT events

* remove uneeded toString()

* source_connection_method to source for TokenAdded events

* redelete add-nft

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
This commit is contained in:
jiexi 2023-07-21 08:17:56 -07:00 committed by GitHub
parent ba001b597c
commit 4c881f70fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/scripts/metamask-controller.js
View File

@ -495,16 +495,14 @@ export default class MetamaskController extends EventEmitter {
this.metaMetricsController.trackEvent({ this.metaMetricsController.trackEvent({
event: MetaMetricsEventName.NftAdded, event: MetaMetricsEventName.NftAdded,
category: MetaMetricsEventCategory.Wallet, category: MetaMetricsEventCategory.Wallet,
properties: { sensitiveProperties: {
token_contract_address: address, token_contract_address: address,
token_symbol: symbol, token_symbol: symbol,
asset_type: AssetType.NFT, token_id: tokenId,
token_standard: standard, token_standard: standard,
asset_type: AssetType.NFT,
source, source,
}, },
sensitiveProperties: {
tokenId,
},
}), }),
}, },
{}, {},

2
ui/components/app/detected-token/detected-token.js
View File

@ -73,7 +73,7 @@ const DetectedToken = ({ setShowDetectedTokens }) => {
token_symbol: importedToken.symbol, token_symbol: importedToken.symbol,
token_contract_address: importedToken.address, token_contract_address: importedToken.address,
token_decimal_precision: importedToken.decimals, token_decimal_precision: importedToken.decimals,
source_connection_method: MetaMetricsTokenEventSource.Detected, source: MetaMetricsTokenEventSource.Detected,
token_standard: TokenStandard.ERC20, token_standard: TokenStandard.ERC20,
asset_type: AssetType.token, asset_type: AssetType.token,
token_added_type: 'detected', token_added_type: 'detected',

4
ui/pages/confirm-add-suggested-nft/confirm-add-suggested-nft.js
View File

@ -69,12 +69,12 @@ const ConfirmAddSuggestedNFT = () => {
event: MetaMetricsEventName.NftAdded, event: MetaMetricsEventName.NftAdded,
category: MetaMetricsEventCategory.Wallet, category: MetaMetricsEventCategory.Wallet,
sensitiveProperties: { sensitiveProperties: {
token_contract_address: asset.address,
token_symbol: asset.symbol, token_symbol: asset.symbol,
token_id: asset.tokenId, token_id: asset.tokenId,
token_contract_address: asset.address,
source_connection_method: MetaMetricsTokenEventSource.Dapp,
token_standard: asset.standard, token_standard: asset.standard,
asset_type: AssetType.NFT, asset_type: AssetType.NFT,
source: MetaMetricsTokenEventSource.Dapp,
}, },
}); });
}), }),

2
ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.js
View File

@ -132,7 +132,7 @@ const ConfirmAddSuggestedToken = () => {
token_contract_address: asset.address, token_contract_address: asset.address,
token_decimal_precision: asset.decimals, token_decimal_precision: asset.decimals,
unlisted: asset.unlisted, unlisted: asset.unlisted,
source_connection_method: MetaMetricsTokenEventSource.Dapp, source: MetaMetricsTokenEventSource.Dapp,
token_standard: TokenStandard.ERC20, token_standard: TokenStandard.ERC20,
asset_type: AssetType.token, asset_type: AssetType.token,
}, },

2
ui/pages/confirm-import-token/confirm-import-token.js
View File

@ -51,7 +51,7 @@ const ConfirmImportToken = () => {
token_contract_address: pendingToken.address, token_contract_address: pendingToken.address,
token_decimal_precision: pendingToken.decimals, token_decimal_precision: pendingToken.decimals,
unlisted: pendingToken.unlisted, unlisted: pendingToken.unlisted,
source_connection_method: pendingToken.isCustom source: pendingToken.isCustom
? MetaMetricsTokenEventSource.Custom ? MetaMetricsTokenEventSource.Custom
: MetaMetricsTokenEventSource.List, : MetaMetricsTokenEventSource.List,
token_standard: TokenStandard.ERC20, token_standard: TokenStandard.ERC20,