m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

feature(17901): fix failing network error and remove duplicated e2e for mv3 (#19292)

Browse Source 
* feature(17901): fix failing network error e2e for mv3

* feature(17901): remove dapp interaction for duplication

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
This commit is contained in:
Danica Shen 2023-05-30 14:48:43 +01:00 committed by GitHub
parent 8dc6bf1111
commit 49f8052b15
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
test/e2e/mv3/dapp-interactions.spec.js
View File

@ -1,72 +0,0 @@
const { strict: assert } = require('assert');
const {
convertToHexValue,
withFixtures,
openDapp,
SERVICE_WORKER_URL,
} = require('../helpers');
const FixtureBuilder = require('../fixture-builder');
describe('MV3 - Dapp interactions', function () {
let windowHandles;
const ganacheOptions = {
accounts: [
{
secretKey:
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
balance: convertToHexValue(25000000000000000000),
},
],
concurrent: { port: 8546, chainId: 1338 },
};
it('should continue to support dapp interactions after service worker re-start', async function () {
await withFixtures(
{
dapp: true,
fixtures: new FixtureBuilder()
.withPermissionControllerConnectedToTestDapp()
.build(),
ganacheOptions: {
...ganacheOptions,
},
title: this.test.title,
},
async ({ driver }) => {
await driver.navigate();
await driver.fill('#password', 'correct horse battery staple');
await driver.press('#password', driver.Key.ENTER);
await openDapp(driver);
// Terminate Service Worker
await driver.openNewPage(SERVICE_WORKER_URL);
await driver.clickElement({
text: 'Service workers',
tag: 'button',
});
await driver.clickElement({
text: 'terminate',
tag: 'span',
});
// Trigger Notification
windowHandles = await driver.getAllWindowHandles();
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
await driver.clickElement('#addEthereumChain');
await driver.waitUntilXWindowHandles(4);
await driver.switchToWindowWithTitle(
'MetaMask Notification',
windowHandles,
);
const notification = await driver.isElementPresent({
text: 'Allow this site to add a network?',
tag: 'h3',
});
assert.ok(notification, 'Dapp action does not appear in Metamask');
},
);
});
});

9
test/e2e/tests/network-error.spec.js
View File

@ -1,5 +1,9 @@
const { strict: assert } = require('assert'); const { strict: assert } = require('assert');
const { convertToHexValue, withFixtures } = require('../helpers'); const {
convertToHexValue,
withFixtures,
regularDelayMs,
} = require('../helpers');
const FixtureBuilder = require('../fixture-builder'); const FixtureBuilder = require('../fixture-builder');
describe('Gas API fallback', function () { describe('Gas API fallback', function () {
@ -79,6 +83,9 @@ describe('Gas API fallback', function () {
await driver.clickElement({ text: 'Next', tag: 'button' }); await driver.clickElement({ text: 'Next', tag: 'button' });
await driver.delay(regularDelayMs);
await driver.findElement('.transaction-alerts');
const error = await driver.isElementPresent({ const error = await driver.isElementPresent({
text: 'Network is busy. Gas prices are high and estimates are less accurate.', text: 'Network is busy. Gas prices are high and estimates are less accurate.',
}); });