m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-29 23:58:06 +01:00
Code

Add additional prop validation to Tabs component (#8267)

Browse Source 
The Tabs component expects the `children` prop to be either a single
Tab component or an array of Tab components, and the internal tab index
should always map onto one of these components. However, if an invalid
tab index was set, it was just returning the first tab contents.

Instead it will now validate that the tab being asked for does exist,
and throw an error otherwise.
This commit is contained in:
Mark Stacey 2020-04-01 11:29:33 -03:00 committed by GitHub
parent 6ba3b7e282
commit 3f2bf36f6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ui/app/components/ui/tabs/tabs.component.js
View File

@ -42,6 +42,13 @@ export default class Tabs extends Component {
const { children } = this.props const { children } = this.props
const { activeTabIndex } = this.state const { activeTabIndex } = this.state
if (
(Array.isArray(children) && !children[activeTabIndex]) ||
(!Array.isArray(children) && activeTabIndex !== 0)
) {
throw new Error(`Tab at index '${activeTabIndex}' does not exist`)
}
return children[activeTabIndex] return children[activeTabIndex]
? children[activeTabIndex].props.children ? children[activeTabIndex].props.children
: children.props.children : children.props.children