m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 20:39:08 +01:00
Code

Fail pending txs with low balance or invalid nonce

Browse Source
This commit is contained in:
Dan Finlay 2017-07-05 22:06:39 -07:00
parent 8aab5d965b
commit 3abceac55d
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
app/scripts/controllers/transactions.js
View File

@ -428,10 +428,28 @@ module.exports = class TransactionController extends EventEmitter {
const gtBalance = Number.parseInt(txMeta.txParams.value) > Number.parseInt(balance)
if (!('retryCount' in txMeta)) txMeta.retryCount = 0
// if the value of the transaction is greater then the balance
// or the nonce of the transaction is lower then the accounts nonce
// dont resubmit the tx
if (gtBalance || txNonce < nonce) return cb()
// if the value of the transaction is greater then the balance, fail.
if (gtBalance) {
txMeta.err = {
isWarning: true,
message: 'Insufficient balance.',
}
this.updateTx(txMeta)
cb()
return log.error(txMeta.err.message)
}
// if the nonce of the transaction is lower then the accounts nonce, fail.
if (txNonce < nonce) {
txMeta.err = {
isWarning: true,
message: 'Invalid nonce.',
}
this.updateTx(txMeta)
cb()
return log.error(txMeta.err.message)
}
// Only auto-submit already-signed txs:
if (!('rawTx' in txMeta)) return cb()