From 9fcf07db6b2aa63f54d813cc194eb13d7f05c079 Mon Sep 17 00:00:00 2001 From: kumavis Date: Fri, 29 Apr 2016 15:38:24 -0700 Subject: [PATCH 1/2] inpage - add and remove 'define' from global context. updates #126 --- app/scripts/inpage.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/app/scripts/inpage.js b/app/scripts/inpage.js index e6684cbd4..54470220f 100644 --- a/app/scripts/inpage.js +++ b/app/scripts/inpage.js @@ -1,9 +1,11 @@ +cleanContextForImports() const createPayload = require('web3-provider-engine/util/create-payload') const StreamProvider = require('./lib/stream-provider.js') const LocalMessageDuplexStream = require('./lib/local-message-stream.js') const setupMultiplex = require('./lib/stream-utils.js').setupMultiplex const RemoteStore = require('./lib/remote-store.js').RemoteStore const Web3 = require('web3') +restoreContextAfterImports() // rename on window delete window.Web3 @@ -102,3 +104,16 @@ remoteProvider.send = function(payload){ } } +// need to make sure we aren't affected by overlapping namespaces +// and that we dont affect the app with our namespace +// mostly a fix for web3's BigNumber if AMD's "define" is defined... +var __define = undefined + +function cleanContextForImports(){ + __define = global.define + delete global.define +} + +function restoreContextAfterImports(){ + global.define = __define +} \ No newline at end of file From 62e4cc8e67d369d2d3fd4930201cd88db7a9b540 Mon Sep 17 00:00:00 2001 From: kumavis Date: Fri, 29 Apr 2016 15:42:48 -0700 Subject: [PATCH 2/2] add changelog note for inpage context guard --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba591dfa1..a2e9e1afa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - Selected account is now persisted between sessions, so the current account stays selected. - Account icons are now "identicons" (deterministically generated from the address). - Fixed link to Slack channel. +- Added a context guard for "define" to avoid UMD's exporting themselves to the wrong module system # 1.6.0 2016-04-22