From 39e033ea0071bb606f5d4c89606e38de65d4e9df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ant=C3=B3nio=20Regadas?= <apregadas@gmail.com>
Date: Thu, 15 Jun 2023 23:33:28 +0100
Subject: [PATCH] [MMI] renames method for better understanding (#19622)

* better naming

* better naming

* undo change
---
 app/scripts/controllers/preferences.js                    | 4 ++--
 .../handlers/institutional/mmi-portfolio.js               | 8 ++++----
 app/scripts/metamask-controller.js                        | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/scripts/controllers/preferences.js b/app/scripts/controllers/preferences.js
index 9a7e9cdba..e2bf8025b 100644
--- a/app/scripts/controllers/preferences.js
+++ b/app/scripts/controllers/preferences.js
@@ -80,7 +80,7 @@ export default class PreferencesController {
     this.tokenListController = opts.tokenListController;
 
     ///: BEGIN:ONLY_INCLUDE_IN(build-mmi)
-    this.handleMmiPortfolio = opts.handleMmiPortfolio;
+    this.handleMmiDashboardData = opts.handleMmiDashboardData;
 
     if (!process.env.IN_TEST) {
       this.mmiConfigurationStore = opts.mmiConfigurationStore.getState();
@@ -534,7 +534,7 @@ export default class PreferencesController {
   async prepareMmiPortfolio() {
     if (!process.env.IN_TEST) {
       try {
-        const mmiDashboardData = await this.handleMmiPortfolio();
+        const mmiDashboardData = await this.handleMmiDashboardData();
         const cookieSetUrls =
           this.mmiConfigurationStore.mmiConfiguration?.portfolio?.cookieSetUrls;
         setDashboardCookie(mmiDashboardData, cookieSetUrls);
diff --git a/app/scripts/lib/rpc-method-middleware/handlers/institutional/mmi-portfolio.js b/app/scripts/lib/rpc-method-middleware/handlers/institutional/mmi-portfolio.js
index eb449c3b1..e52599ee9 100644
--- a/app/scripts/lib/rpc-method-middleware/handlers/institutional/mmi-portfolio.js
+++ b/app/scripts/lib/rpc-method-middleware/handlers/institutional/mmi-portfolio.js
@@ -5,14 +5,14 @@ const mmiPortfolio = {
   methodNames: [MESSAGE_TYPE.MMI_PORTFOLIO],
   implementation: mmiPortfolioHandler,
   hookNames: {
-    handleMmiPortfolio: true,
+    handleMmiDashboardData: true,
   },
 };
 export default mmiPortfolio;
 
 /**
  * @typedef {object} MmiPortfolioOptions
- * @property {Function} handleMmiportfolio - The metmaskinsititutional_portfolio method implementation.
+ * @property {Function} handleMmiDashboardData - The metmaskinsititutional_portfolio method implementation.
  */
 
 /**
@@ -33,7 +33,7 @@ async function mmiPortfolioHandler(
   res,
   _next,
   end,
-  { handleMmiPortfolio },
+  { handleMmiDashboardData },
 ) {
   try {
     let validUrl = false;
@@ -47,7 +47,7 @@ async function mmiPortfolioHandler(
     if (!validUrl) {
       throw new Error('Unauthorized');
     } else {
-      res.result = await handleMmiPortfolio(req);
+      res.result = await handleMmiDashboardData(req);
       return end();
     }
   } catch (error) {
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
index 1ae038534..22a1da813 100644
--- a/app/scripts/metamask-controller.js
+++ b/app/scripts/metamask-controller.js
@@ -355,7 +355,7 @@ export default class MetamaskController extends EventEmitter {
       tokenListController: this.tokenListController,
       provider: this.provider,
       ///: BEGIN:ONLY_INCLUDE_IN(build-mmi)
-      handleMmiPortfolio: this.setMmiPortfolioCookie.bind(this),
+      handleMmiDashboardData: this.handleMmiDashboardData.bind(this),
       mmiConfigurationStore: this.mmiConfigurationController.store,
       ///: END:ONLY_INCLUDE_IN
     });
@@ -3910,7 +3910,7 @@ export default class MetamaskController extends EventEmitter {
           ),
         handleMmiCheckIfTokenIsPresent:
           this.mmiController.handleMmiCheckIfTokenIsPresent.bind(this),
-        handleMmiPortfolio: this.setMmiPortfolioCookie.bind(this),
+        handleMmiDashboardData: this.handleMmiDashboardData.bind(this),
         handleMmiOpenSwaps: this.mmiController.handleMmiOpenSwaps.bind(this),
         handleMmiSetAccountAndNetwork:
           this.mmiController.setAccountAndNetwork.bind(this),
@@ -3975,7 +3975,7 @@ export default class MetamaskController extends EventEmitter {
    * so it needs to be here and not in our controller because
    * preferences controllers is initiated first
    */
-  async setMmiPortfolioCookie() {
+  async handleMmiDashboardData() {
     await this.appStateController.getUnlockPromise(true);
     const keyringAccounts = await this.keyringController.getAccounts();
     const { identities } = this.preferencesController.store.getState();