From 3859c25cac6963d306bb7bd2c0435132da405cf5 Mon Sep 17 00:00:00 2001 From: seaona <54408225+seaona@users.noreply.github.com> Date: Thu, 15 Dec 2022 09:49:54 +0100 Subject: [PATCH] Changelog for 10.24.0 (#16888) * Changelog for 10.24.0 * Update FLASK snaps-monorepo entry Co-authored-by: Frederik Bolding * Flask entries Co-authored-by: Frederik Bolding * Small fixes on changelog entries * Updated Flask entries classification * Add new cherry-picked entries * Small fix for reject tx entry * Update CHANGELOG.md [FLASK] Fix usage of wrong `ethereum` global for `ethereum` endowment Co-authored-by: Frederik Bolding Co-authored-by: Frederik Bolding --- CHANGELOG.md | 177 +++++++++++++++------------------------------------ 1 file changed, 53 insertions(+), 124 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index da1ac63ae..04d3fcfd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,135 +7,64 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ## [10.24.0] -### Uncategorized -- Master sync PR following v10.23.0 ([#16827](https://github.com/MetaMask/metamask-extension/pull/16827)) -- Merge remote-tracking branch 'origin/develop' into master-sync -- Revert "Use new assets contrller package to fix 0 decimal token bug ([#16685](https://github.com/MetaMask/metamask-extension/pull/16685)) -- Revert "Revert "Added "What's New" Notification for Improved token allowance experience ([#16465](https://github.com/MetaMask/metamask-extension/pull/16465)) -- Revert "Revert "Add improved token allowance experience toggle ([#16291](https://github.com/MetaMask/metamask-extension/pull/16291)) -- NFT setApprovalForAll warning popover ([#16195](https://github.com/MetaMask/metamask-extension/pull/16195)) -- `TextField` house keeping 🧹 ([#16668](https://github.com/MetaMask/metamask-extension/pull/16668)) -- `TextFieldBase` house keeping 🧹 ([#16667](https://github.com/MetaMask/metamask-extension/pull/16667)) -- Update qs via yarn.lock to 6.5.3 ([#16823](https://github.com/MetaMask/metamask-extension/pull/16823)) -- Continue converting tests from enzyme to @testing-library/react ([#16753](https://github.com/MetaMask/metamask-extension/pull/16753)) -- Fixed NumericInput Storybook Components (#16734) ([#16734](https://github.com/MetaMask/metamask-extension/pull/16734)) -- Ensure 0% slippage on Arbitrum for wrapping / unwrapping ([#16778](https://github.com/MetaMask/metamask-extension/pull/16778)) -- Upgrade Snow to new version 1.3.0 in MetaMask ([#16815](https://github.com/MetaMask/metamask-extension/pull/16815)) -- Transaction security provider feature flag ([#16776](https://github.com/MetaMask/metamask-extension/pull/16776)) -- Fix getFullTxData so that customTxParamsData is not lost ([#16805](https://github.com/MetaMask/metamask-extension/pull/16805)) -- Updated secondary copy and removed the address component from SetApprovalForAll and NFT Approve screens ([#16292](https://github.com/MetaMask/metamask-extension/pull/16292)) -- Removed Confirm and Cancel events as they are not triggered anymore ([#16777](https://github.com/MetaMask/metamask-extension/pull/16777)) -- remove network name from analytics ([#16781](https://github.com/MetaMask/metamask-extension/pull/16781)) -- Allow adding networks with the same chainId as a preloaded/default network via `wallet_AddEthereumChain` API ([#16733](https://github.com/MetaMask/metamask-extension/pull/16733)) -- Add security & privacy "What's New" message ([#16783](https://github.com/MetaMask/metamask-extension/pull/16783)) -- Bump @metamask/design-tokens from 1.11.0 to 1.11.1 ([#16764](https://github.com/MetaMask/metamask-extension/pull/16764)) -- Network request in background should not start until onboarding is completed ([#16773](https://github.com/MetaMask/metamask-extension/pull/16773)) -- Adding middleware to filter out duplicate requests from DAPP ([#16730](https://github.com/MetaMask/metamask-extension/pull/16730)) -- Updating keyring controller ([#16762](https://github.com/MetaMask/metamask-extension/pull/16762)) -- Add user guidance on signature request screen ([#16600](https://github.com/MetaMask/metamask-extension/pull/16600)) -- TextFieldSearch house keeping updates ([#16669](https://github.com/MetaMask/metamask-extension/pull/16669)) -- Give the user ability to opt out of get balance batch request for all loaded accounts ([#16746](https://github.com/MetaMask/metamask-extension/pull/16746)) -- Feat/16634/buttonicon housekeeping ([#16666](https://github.com/MetaMask/metamask-extension/pull/16666)) -- Feat/16187/text housekeeping ([#16589](https://github.com/MetaMask/metamask-extension/pull/16589)) +### Added +- Add NFT setApprovalForAll warning popover when approving the NFT Colleciton ([#16195](https://github.com/MetaMask/metamask-extension/pull/16195)) +- Add "What's New" notification for Security & Privacy ([#16783](https://github.com/MetaMask/metamask-extension/pull/16783)) +- Add informational message on Signature request screen as a user guidance ([#16600](https://github.com/MetaMask/metamask-extension/pull/16600)) +- Add ability to opt out from getting balances as a batch request for all loaded accounts ([#16746](https://github.com/MetaMask/metamask-extension/pull/16746)) +- Add Signature request warning modal ([#16225](https://github.com/MetaMask/metamask-extension/pull/16225)) +- Add Improved Token Allowance experience toggle under Experimental Settings ([#16291](https://github.com/MetaMask/metamask-extension/pull/16291)) +- Add "What's New" Notification for Improved token Allowance Experience ([#16465](https://github.com/MetaMask/metamask-extension/pull/16465)) +- Add new IT translations ([#15748](https://github.com/MetaMask/metamask-extension/pull/15748)) +- Add new zh_TW translations and apply a variety of fixes ([#11212](https://github.com/MetaMask/metamask-extension/pull/11212)) +- Add ES translations for getting Ethereum Accounts permission message ([#15660](https://github.com/MetaMask/metamask-extension/pull/15660)) +- Add "Verify contract details" link to SetApprovalForAll confirmation screens ([#15756](https://github.com/MetaMask/metamask-extension/pull/15756)) +- Add Reject Transactions modal to be present in the footer of the Approve screen ([#16832](https://github.com/MetaMask/metamask-extension/pull/16832)) - [FLASK] Add snap alerts and prompts via `snap_dialog` RPC method ([#16048](https://github.com/MetaMask/metamask-extension/pull/16048)) -- Use NETWORK_EVENTS.NETWORK_DID_CHANGE to trigger network change callback in assetsContractController ([#16760](https://github.com/MetaMask/metamask-extension/pull/16760)) - [FLASK] Expose transaction origin to transaction insight snaps ([#16671](https://github.com/MetaMask/metamask-extension/pull/16671)) -- Fix production builds for Flask ([#16757](https://github.com/MetaMask/metamask-extension/pull/16757)) + +### Changed +- Update secondary copy and remove the Address component from SetApprovalForAll and NFT Approve screens ([#16292](https://github.com/MetaMask/metamask-extension/pull/16292)) +- Update background color for picker network ([#16466](https://github.com/MetaMask/metamask-extension/pull/16466)) +- Update network colors with design tokens ([#16543](https://github.com/MetaMask/metamask-extension/pull/16543)) +- Update all background-default hovers colors ([#16519](https://github.com/MetaMask/metamask-extension/pull/16519)) - Update signature request screens ([#15776](https://github.com/MetaMask/metamask-extension/pull/15776)) -- remove rpc urls from metrics ([#16710](https://github.com/MetaMask/metamask-extension/pull/16710)) -- Add signature request warning modal ([#16225](https://github.com/MetaMask/metamask-extension/pull/16225)) -- Show account name when qr scan in send screen ([#16204](https://github.com/MetaMask/metamask-extension/pull/16204)) -- Fixes 'yarn start' on Windows - LavaPack is not defined (#13318) ([#13318](https://github.com/MetaMask/metamask-extension/pull/13318)) -- Remove fenced code in TypeScript files ([#16742](https://github.com/MetaMask/metamask-extension/pull/16742)) -- [FLASK] Create E2E test for snap management ([#16628](https://github.com/MetaMask/metamask-extension/pull/16628)) -- [FLASK] `snaps-monorepo@0.25.0` ([#16673](https://github.com/MetaMask/metamask-extension/pull/16673)) -- Fix: multiple reject on the signature request screen ([#16199](https://github.com/MetaMask/metamask-extension/pull/16199)) -- Label house keeping updates ([#16680](https://github.com/MetaMask/metamask-extension/pull/16680)) -- HelpText house keeping updates ([#16681](https://github.com/MetaMask/metamask-extension/pull/16681)) -- Update codeowners to reflect importance of review ([#16665](https://github.com/MetaMask/metamask-extension/pull/16665)) -- Use Webpack 5 for Storybook ([#16678](https://github.com/MetaMask/metamask-extension/pull/16678)) -- Not use hardware keyring classes when initializing KeyringController in extension MV3 version ([#16684](https://github.com/MetaMask/metamask-extension/pull/16684)) -- DAPP action replay improvements ([#16250](https://github.com/MetaMask/metamask-extension/pull/16250)) -- fix issue preventing switching to localhost ([#16707](https://github.com/MetaMask/metamask-extension/pull/16707)) -- Continue converting tests from enzyme to @testing-library/react ([#16458](https://github.com/MetaMask/metamask-extension/pull/16458)) -- Restore open api usage fully by snow ([#16722](https://github.com/MetaMask/metamask-extension/pull/16722)) -- Unable to proceed with tx bc of inaccurate/overly aggressive "Insufficient funds for gas" warning #13087 ([#14634](https://github.com/MetaMask/metamask-extension/pull/14634)) -- [e2e] Setup MV3 specific test folder and add 1 simple testcase introducing Service Worker re-start ([#16606](https://github.com/MetaMask/metamask-extension/pull/16606)) -- Token allowance i18n interpolation system ([#16347](https://github.com/MetaMask/metamask-extension/pull/16347)) -- Migrate to new controller packages ([#16547](https://github.com/MetaMask/metamask-extension/pull/16547)) -- Resetting spending cap value to empty when a token allowance request is rejected. ([#16659](https://github.com/MetaMask/metamask-extension/pull/16659)) -- Mitigate flaky test with the use of new function ([#16655](https://github.com/MetaMask/metamask-extension/pull/16655)) -- [e2e] [MV3] Fix Add Account e2e flaky test for MV3 build ([#16603](https://github.com/MetaMask/metamask-extension/pull/16603)) -- Master sync following v10.22.3 ([#16650](https://github.com/MetaMask/metamask-extension/pull/16650)) -- Simplify MV3 initialization ([#16559](https://github.com/MetaMask/metamask-extension/pull/16559)) -- Fix #15050 - MV3: Keep the user logged in when service worker restarts ([#15558](https://github.com/MetaMask/metamask-extension/pull/15558)) -- Integrating snow into metamask ([#15580](https://github.com/MetaMask/metamask-extension/pull/15580)) -- fix infura rpc detection ([#16585](https://github.com/MetaMask/metamask-extension/pull/16585)) -- Remove callback from being saved in controller state ([#16627](https://github.com/MetaMask/metamask-extension/pull/16627)) -- Icon house keeping updates ([#16621](https://github.com/MetaMask/metamask-extension/pull/16621)) -- Fix bundle size diff message ([#16576](https://github.com/MetaMask/metamask-extension/pull/16576)) -- avatar base component housekeeping ([#16583](https://github.com/MetaMask/metamask-extension/pull/16583)) -- Disabled save button on add contact form if input fields are empty ([#16233](https://github.com/MetaMask/metamask-extension/pull/16233)) -- Fix E2E chunking ([#16653](https://github.com/MetaMask/metamask-extension/pull/16653)) -- Fix develop conflicts -- fixed console warning for labelProps ([#16629](https://github.com/MetaMask/metamask-extension/pull/16629)) -- Adding `FormTextField` component ([#16497](https://github.com/MetaMask/metamask-extension/pull/16497)) -- Fix/16620/button href prop ([#16633](https://github.com/MetaMask/metamask-extension/pull/16633)) -- Keep memstore contents after service worker restarts ([#15913](https://github.com/MetaMask/metamask-extension/pull/15913)) -- Adding ITA translations ([#15748](https://github.com/MetaMask/metamask-extension/pull/15748)) +- Remove network name from analytics ([#16781](https://github.com/MetaMask/metamask-extension/pull/16781)) +- Remove RPC urls from metrics ([#16710](https://github.com/MetaMask/metamask-extension/pull/16710)) +- Allow adding networks with the same chainId as a preloaded/default network via `wallet_AddEthereumChain` API ([#16733](https://github.com/MetaMask/metamask-extension/pull/16733)) +- Network request in background should not start until onboarding is completed ([#16773](https://github.com/MetaMask/metamask-extension/pull/16773)) +- Replace the address in SignTypedData_v4 signatures with a 'Verify contract details' link ([#16191](https://github.com/MetaMask/metamask-extension/pull/16191)) +- Bump `@metamask/design-tokens` from `1.11.0` to `1.11.1` ([#16764](https://github.com/MetaMask/metamask-extension/pull/16764)) +- Bump `@metamask/design-tokens` from `1.9.0` to `1.11.0` ([#16515](https://github.com/MetaMask/metamask-extension/pull/16515)) +- Update `@metamask/controllers` to `v33` ([#16493](https://github.com/MetaMask/metamask-extension/pull/16493)) +- Migrate from deprecated `@metamask/controllers`to the new controller packages ([#16547](https://github.com/MetaMask/metamask-extension/pull/16547)) +- Swaps: ensure 0% slippage on Arbitrum for wrapping/unwrapping ETH (ETH -> WETH or WETH -> ETH) ([#16778](https://github.com/MetaMask/metamask-extension/pull/16778)) +- [Beta] Update `BETA` to sentence case ([#16590](https://github.com/MetaMask/metamask-extension/pull/16590)) +- [Beta] Update text on the Welcome screen ([#16489](https://github.com/MetaMask/metamask-extension/pull/16489)) +- [FLASK] **BREAKING:** Snaps are now required to request the `endowment:rpc` permission to receive RPC requests on `onRpcRequest` ([#16673](https://github.com/MetaMask/metamask-extension/pull/16673)) + - Snaps must specify if they want to receive RPC requests from dapps or snaps using the following permission `endowment:rpc: { dapps: true, snaps: true }` +- [FLASK] **BREAKING:** Removed `wallet_enable` and `wallet_installSnaps` in favor of `wallet_requestSnaps` ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) +- [FLASK] **BREAKING:** The `wallet` global exposed to Snaps has been replaced with two new globals: `snap` and `ethereum` ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) + - `ethereum` is an EIP-1193 provider and can be accessed by requesting the `endowment:ethereum-provider` permission + - `snap` is always exposed and can be used to access snap specific functions using `snap.request()` +- [FLASK] **BREAKING:** Named parameters are now required in all Snaps RPC methods ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) + +### Removed +- [FLASK] **BREAKING:** Removed `snap_getAppKey` ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) + - Snaps that need snap-specific entropy can use `snap_getEntropy` instead + +### Fixed +- Fix resolving to the Account nickname or contact name when scanning the QR code in the Send screen ([#16204](https://github.com/MetaMask/metamask-extension/pull/16204)) +- Fix not being able to reject multiple Signature requests ([#16199](https://github.com/MetaMask/metamask-extension/pull/16199)) +- Fix issue that prevents switching to localhost using the API ([#16707](https://github.com/MetaMask/metamask-extension/pull/16707)) +- Fix unable to proceed with tx when there is "Insufficient funds for gas", by adding the estimated gas fee section on the Send screen ([#14634](https://github.com/MetaMask/metamask-extension/pull/14634)) +- Fix Add Contact by disabling the Save button if the input fields are empty ([#16233](https://github.com/MetaMask/metamask-extension/pull/16233)) +- Fix Token Detection displaying a token without balance, by updating the user state `tokensChainsCache` from array to object ([#16535](https://github.com/MetaMask/metamask-extension/pull/16535)) +- Fix message not rendering properly on Sign Typed Data v4 screen, by supporting nested arrays and arrays with defined length ([#16552](https://github.com/MetaMask/metamask-extension/pull/16552)) +- Fix German translation for `lightTheme` ([#16517](https://github.com/MetaMask/metamask-extension/pull/16517)) - [FLASK] Clear notification state on restore ([#16503](https://github.com/MetaMask/metamask-extension/pull/16503)) - [FLASK] Fix a crash that happens after snap install ([#16526](https://github.com/MetaMask/metamask-extension/pull/16526)) -- [FLASK] `snaps-monorepo@0.24.1` ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) -- added sm border radius ([#16611](https://github.com/MetaMask/metamask-extension/pull/16611)) -- [e2e] [MV3] Fix Custom RPC e2e test failures for MV3 build ([#16599](https://github.com/MetaMask/metamask-extension/pull/16599)) -- Replace the address in SignTypedData_v4 signatures with a 'Verify contract details' link ([#16191](https://github.com/MetaMask/metamask-extension/pull/16191)) -- Expanded permission_ethereumAccounts spanish translation ([#15660](https://github.com/MetaMask/metamask-extension/pull/15660)) -- Make ENS named elements domain generic ([#16166](https://github.com/MetaMask/metamask-extension/pull/16166)) -- Use async/await for extension functions ([#15722](https://github.com/MetaMask/metamask-extension/pull/15722)) -- BETA - Update to sentence case ([#16590](https://github.com/MetaMask/metamask-extension/pull/16590)) -- Create constants for all keyring types ([#16575](https://github.com/MetaMask/metamask-extension/pull/16575)) -- [FLASK] Improve Snaps E2E stability ([#16597](https://github.com/MetaMask/metamask-extension/pull/16597)) -- updated responsive props for border radius ([#16510](https://github.com/MetaMask/metamask-extension/pull/16510)) -- Feat/16507/button link housekeeping ([#16518](https://github.com/MetaMask/metamask-extension/pull/16518)) -- Updating tokensChainsCache[chainId].data to object from array in user state ([#16535](https://github.com/MetaMask/metamask-extension/pull/16535)) -- updated background color for picker network ([#16466](https://github.com/MetaMask/metamask-extension/pull/16466)) -- Adding static icon names to test env file ([#16078](https://github.com/MetaMask/metamask-extension/pull/16078)) -- Fix message on sign typed data v4 screen ([#16552](https://github.com/MetaMask/metamask-extension/pull/16552)) -- Removing storybook tests ([#16577](https://github.com/MetaMask/metamask-extension/pull/16577)) -- Minor scripts/ui.js file cleanup ([#16566](https://github.com/MetaMask/metamask-extension/pull/16566)) -- Updated Text style in Tag Url ([#16570](https://github.com/MetaMask/metamask-extension/pull/16570)) -- Updating network colors with design tokens ([#16543](https://github.com/MetaMask/metamask-extension/pull/16543)) -- Updating all background-default hovers colors ([#16519](https://github.com/MetaMask/metamask-extension/pull/16519)) -- Ensure prod beta build is created when merging to master ([#16557](https://github.com/MetaMask/metamask-extension/pull/16557)) -- MV3: support Service Worker restart for phishing warning pages ([#16488](https://github.com/MetaMask/metamask-extension/pull/16488)) -- Fix crash on e2e test failure ([#16556](https://github.com/MetaMask/metamask-extension/pull/16556)) -- Add transaction security check toggle ([#16271](https://github.com/MetaMask/metamask-extension/pull/16271)) -- Skip the first token allowance screen if dapp proposing spending cap is 0 ([#16502](https://github.com/MetaMask/metamask-extension/pull/16502)) -- Master sync following v10.22.2 ([#16548](https://github.com/MetaMask/metamask-extension/pull/16548)) -- Merge remote-tracking branch 'origin/develop' into master-sync -- Component library adding global index and other housekeeping ([#16441](https://github.com/MetaMask/metamask-extension/pull/16441)) -- fix(i18n): de lightTheme translation ([#16517](https://github.com/MetaMask/metamask-extension/pull/16517)) -- [FLASK] Update e2e tests for new react test-snaps page ([#16324](https://github.com/MetaMask/metamask-extension/pull/16324)) -- [e2e] Fix RPC flaky test ([#16530](https://github.com/MetaMask/metamask-extension/pull/16530)) -- BETA - Updating welcome message ([#16489](https://github.com/MetaMask/metamask-extension/pull/16489)) -- Bump @metamask/design-tokens from 1.9.0 to 1.11.0 ([#16515](https://github.com/MetaMask/metamask-extension/pull/16515)) -- Add mocks for E2E tests ([#16527](https://github.com/MetaMask/metamask-extension/pull/16527)) -- Modified chain_id value(MetaMetrics), in the Custom Network Added event ([#16426](https://github.com/MetaMask/metamask-extension/pull/16426)) -- Remove unnecessary await ([#16482](https://github.com/MetaMask/metamask-extension/pull/16482)) -- persist user traits for comparison ([#16506](https://github.com/MetaMask/metamask-extension/pull/16506)) -- Configure smart transactions controller to support goerli ([#16500](https://github.com/MetaMask/metamask-extension/pull/16500)) -- button secondary housekeeping ([#16495](https://github.com/MetaMask/metamask-extension/pull/16495)) -- Added "What's New" Notification for Improved token allowance experience ([#16465](https://github.com/MetaMask/metamask-extension/pull/16465)) -- Update `@metamask/controllers` to v33 ([#16493](https://github.com/MetaMask/metamask-extension/pull/16493)) -- Jest: Add browser.runtime (webextension-polyfill) utils tests ([#16483](https://github.com/MetaMask/metamask-extension/pull/16483)) -- Adding some propType fixes to `TextFieldBase` ([#16508](https://github.com/MetaMask/metamask-extension/pull/16508)) -- Adding `TextFieldSearch` component ([#16296](https://github.com/MetaMask/metamask-extension/pull/16296)) -- upgrade gulp-autoprefixer ([#16439](https://github.com/MetaMask/metamask-extension/pull/16439)) -- Feat/16185/button primary housekeeping ([#16457](https://github.com/MetaMask/metamask-extension/pull/16457)) -- added 50% border radius support to the Box component ([#16486](https://github.com/MetaMask/metamask-extension/pull/16486)) -- [i18n:zh_tw] Sync and update translation for zh_TW ([#11212](https://github.com/MetaMask/metamask-extension/pull/11212)) -- Added a 'Verify contract details' link to SetApprovalForAll confirmation screens ([#15756](https://github.com/MetaMask/metamask-extension/pull/15756)) -- MV3: Update service worker restart logic and keep-alive logic for dapp support ([#16075](https://github.com/MetaMask/metamask-extension/pull/16075)) +- [FLASK] Fix usage of wrong `ethereum` global for `ethereum` endowment ([#16932](https://github.com/MetaMask/metamask-extension/pull/16932)) ## [10.23.0] ### Added