m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Code

transactions - remove unnecessary keys on txParams

Browse Source
This commit is contained in:
frankiebee 2018-04-04 20:18:44 -07:00
parent 1153120fe8
commit 343f0e9e80
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/scripts/controllers/transactions.js
View File

@ -315,6 +315,18 @@ module.exports = class TransactionController extends EventEmitter {
//
_normalizeTxParams (txParams) {
const acceptableKeys = [
'from',
'to',
'nonce',
'value',
'data',
'gas',
'gasPrice',
]
Object.keys(txParams).forEach((key) => {
if (!acceptableKeys.includes(key)) delete txParams[key]
})
delete txParams.chainId
if ( !txParams.to ) {

3
test/unit/tx-controller-test.js
View File

@ -239,6 +239,7 @@ describe('Transaction Controller', function () {
from: 'a7df1beDBF813f57096dF77FCd515f0B3900e402',
to: null,
data: '68656c6c6f20776f726c64',
random: 'hello world',
}
txController._normalizeTxParams(txParams)
@ -247,7 +248,7 @@ describe('Transaction Controller', function () {
assert(!txParams.to, 'their should be no to address if null')
assert.equal(txParams.from.slice(0, 2), '0x', 'from should be hexPrefixd')
assert.equal(txParams.data.slice(0, 2), '0x', 'data should be hexPrefixd')
assert(!('random' in txParams), 'their should be no random key in txParams')
txParams.to = 'a7df1beDBF813f57096dF77FCd515f0B3900e402'
txController._normalizeTxParams(txParams)