m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Code

Fix issue with chainId comparison in sign typed message param validation (#11900)

Browse Source
This commit is contained in:
Alex Donesky 2021-08-24 11:23:29 -05:00 committed by GitHub
parent 0d63aa0402
commit 33849bfec6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/scripts/lib/typed-message-manager.js
View File

@ -204,7 +204,7 @@ export default class TypedMessageManager extends EventEmitter {
`Cannot sign messages for chainId "${chainId}", because MetaMask is switching networks.`, `Cannot sign messages for chainId "${chainId}", because MetaMask is switching networks.`,
); );
if (typeof chainId === 'string') { if (typeof chainId === 'string') {
chainId = parseInt(chainId, 16); chainId = parseInt(chainId, chainId.startsWith('0x') ? 16 : 10);
} }
assert.equal( assert.equal(
chainId, chainId,