m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

tx-gas-util - set error message when invalidating tx based on tx data but no contract code

Browse Source
This commit is contained in:
kumavis 2018-10-21 01:01:21 -04:00
parent 17a856cfd3
commit 31e5cad1e3
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/scripts/controllers/transactions/tx-gas-utils.js
View File

@ -62,20 +62,21 @@ class TxGasUtil {
const recipient = txParams.to const recipient = txParams.to
const hasRecipient = Boolean(recipient) const hasRecipient = Boolean(recipient)
// see if we can set the gas based on the recipient // see if we can set the gas based on the recipient
if (hasRecipient) { if (hasRecipient) {
const code = await this.query.getCode(recipient) const code = await this.query.getCode(recipient)
// For an address with no code, geth will return '0x', and ganache-core v2.2.1 will return '0x0' // For an address with no code, geth will return '0x', and ganache-core v2.2.1 will return '0x0'
const codeIsEmpty = !code || code === '0x' || code === '0x0' const codeIsEmpty = !code || code === '0x' || code === '0x0'
if (codeIsEmpty) { if (codeIsEmpty) {
// if there's data in the params, but there's no contract code, it's not a valid transaction // if there's data in the params, but there's no contract code, it's not a valid transaction
if (txParams.data) { if (txParams.data) {
const err = new Error() const err = new Error('TxGasUtil - Trying to call a function on a non-contract address')
// set error key so ui can display localized error message
err.errorKey = TRANSACTION_NO_CONTRACT_ERROR_KEY err.errorKey = TRANSACTION_NO_CONTRACT_ERROR_KEY
throw err throw err
} }
// This is a standard ether simple send, gas requirement is exactly 21k // This is a standard ether simple send, gas requirement is exactly 21k
txParams.gas = SIMPLE_GAS_COST txParams.gas = SIMPLE_GAS_COST
// prevents buffer addition // prevents buffer addition