m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Code

moving some properties to identifiable payload (#11506)

Browse Source
This commit is contained in:
Brad Decker 2021-07-12 17:30:35 -05:00 committed by GitHub
parent 07601f4a90
commit 2edd44e1c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/scripts/controllers/transactions/index.js
View File

@ -1243,13 +1243,15 @@ export default class TransactionController extends EventEmitter {
this._trackMetaMetricsEvent({
event,
category: 'Transactions',
sensitiveProperties: {
type,
status,
properties: {
chain_id: chainId,
referrer,
source,
network,
chain_id: chainId,
type,
},
sensitiveProperties: {
status,
transaction_envelope_type: isEIP1559Transaction(txMeta)
? 'fee-market'
: 'legacy',

48
app/scripts/controllers/transactions/index.test.js
View File

@ -1270,17 +1270,19 @@ describe('Transaction Controller', function () {
const expectedPayload = {
event: 'Transaction Added',
category: 'Transactions',
sensitiveProperties: {
properties: {
chain_id: '0x2a',
network: '42',
referrer: 'metamask',
source: 'user',
type: 'sentEther',
},
sensitiveProperties: {
gas_price: '2',
gas_limit: '0x7b0d',
first_seen: 1624408066355,
transaction_envelope_type: 'legacy',
network: '42',
referrer: 'metamask',
source: 'user',
status: 'unapproved',
type: 'sentEther',
},
};
@ -1315,17 +1317,19 @@ describe('Transaction Controller', function () {
const expectedPayload = {
event: 'Transaction Added',
category: 'Transactions',
sensitiveProperties: {
properties: {
chain_id: '0x2a',
network: '42',
referrer: 'other',
source: 'dapp',
type: 'sentEther',
},
sensitiveProperties: {
gas_price: '2',
gas_limit: '0x7b0d',
first_seen: 1624408066355,
transaction_envelope_type: 'legacy',
network: '42',
referrer: 'other',
source: 'dapp',
status: 'unapproved',
type: 'sentEther',
},
};
@ -1360,19 +1364,21 @@ describe('Transaction Controller', function () {
const expectedPayload = {
event: 'Transaction Added',
category: 'Transactions',
properties: {
network: '42',
referrer: 'other',
source: 'dapp',
type: 'sentEther',
chain_id: '0x2a',
},
sensitiveProperties: {
baz: 3.0,
foo: 'bar',
chain_id: '0x2a',
gas_price: '2',
gas_limit: '0x7b0d',
first_seen: 1624408066355,
transaction_envelope_type: 'legacy',
network: '42',
referrer: 'other',
source: 'dapp',
status: 'unapproved',
type: 'sentEther',
},
};
@ -1412,20 +1418,22 @@ describe('Transaction Controller', function () {
const expectedPayload = {
event: 'Transaction Added',
category: 'Transactions',
properties: {
chain_id: '0x2a',
network: '42',
referrer: 'other',
source: 'dapp',
type: 'sentEther',
},
sensitiveProperties: {
baz: 3.0,
foo: 'bar',
chain_id: '0x2a',
max_fee_per_gas: '2',
max_priority_fee_per_gas: '2',
gas_limit: '0x7b0d',
first_seen: 1624408066355,
transaction_envelope_type: 'fee-market',
network: '42',
referrer: 'other',
source: 'dapp',
status: 'unapproved',
type: 'sentEther',
},
};