1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00

Restore version missing from certain build steps (#14344)

Certain build steps accidentally omitted the `version` variable. It has
now been restored to all steps, ensuring that all environment variables
are correctly injected into all bundles.

A check has been added to the Sentry setup module to ensure the release
is not omitted in the future.
This commit is contained in:
Mark Stacey 2022-04-04 16:44:32 -02:30 committed by GitHub
parent 0556feb142
commit 2d08fe35e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 4 deletions

View File

@ -68,9 +68,9 @@ export const SENTRY_STATE = {
};
export default function setupSentry({ release, getState }) {
let sentryTarget;
if (METAMASK_DEBUG) {
if (!release) {
throw new Error('Missing release');
} else if (METAMASK_DEBUG) {
return undefined;
}
@ -79,6 +79,7 @@ export default function setupSentry({ release, getState }) {
? METAMASK_ENVIRONMENT
: `${METAMASK_ENVIRONMENT}-${METAMASK_BUILD_TYPE}`;
let sentryTarget;
if (METAMASK_ENVIRONMENT === 'production') {
if (!process.env.SENTRY_DSN) {
throw new Error(

View File

@ -269,6 +269,7 @@ function createScriptTasks({
testing,
policyOnly,
shouldLintFenceFiles,
version,
});
}
@ -285,6 +286,7 @@ function createScriptTasks({
testing,
policyOnly,
shouldLintFenceFiles,
version,
});
}
@ -301,6 +303,7 @@ function createScriptTasks({
testing,
policyOnly,
shouldLintFenceFiles,
version,
});
}
@ -320,6 +323,7 @@ function createScriptTasks({
policyOnly,
shouldLintFenceFiles,
testing,
version,
}),
createNormalBundle({
buildType,
@ -332,6 +336,7 @@ function createScriptTasks({
policyOnly,
shouldLintFenceFiles,
testing,
version,
}),
);
}
@ -532,6 +537,7 @@ function createNormalBundle({
modulesToExpose,
shouldLintFenceFiles,
testing,
version,
}) {
return async function () {
// create bundler setup and apply defaults
@ -543,7 +549,12 @@ function createNormalBundle({
const reloadOnChange = Boolean(devMode);
const minify = Boolean(devMode) === false;
const envVars = getEnvironmentVariables({ buildType, devMode, testing });
const envVars = getEnvironmentVariables({
buildType,
devMode,
testing,
version,
});
setupBundlerDefaults(buildConfiguration, {
buildType,
devMode,