m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Merge pull request #5402 from whymarrh/fix-e2e-tests

Browse Source 
Fix e2e tests for adding custom RPC endpoints
This commit is contained in:
Whymarrh Whitby 2018-10-01 12:52:13 -02:30 committed by GitHub
commit 23aabcca6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/e2e/beta/helpers.js
View File

@ -126,10 +126,7 @@ async function assertElementNotPresent (webdriver, driver, by) {
try { try {
dataTab = await findElement(driver, by, 4000) dataTab = await findElement(driver, by, 4000)
} catch (err) { } catch (err) {
console.log(err)
assert(err instanceof webdriver.error.NoSuchElementError || err instanceof webdriver.error.TimeoutError) assert(err instanceof webdriver.error.NoSuchElementError || err instanceof webdriver.error.TimeoutError)
} }
if (dataTab) { assert.ok(!dataTab, 'Found element that should not be present')
assert(false, 'Data tab should not be present')
}
} }

16
test/e2e/beta/metamask-beta-ui.spec.js
View File

@ -1030,7 +1030,7 @@ describe('MetaMask', function () {
] ]
customRpcUrls.forEach(customRpcUrl => { customRpcUrls.forEach(customRpcUrl => {
it('creates custom RPC: ' + customRpcUrl, async () => { it(`creates custom RPC: ${customRpcUrl}`, async () => {
const networkDropdown = await findElement(driver, By.css('.network-name')) const networkDropdown = await findElement(driver, By.css('.network-name'))
await networkDropdown.click() await networkDropdown.click()
await delay(regularDelayMs) await delay(regularDelayMs)
@ -1059,25 +1059,15 @@ describe('MetaMask', function () {
await delay(largeDelayMs * 2) await delay(largeDelayMs * 2)
}) })
it('finds 3 recent RPCs in history', async () => { it('finds all recent RPCs in history', async () => {
const networkDropdown = await findElement(driver, By.css('.network-name')) const networkDropdown = await findElement(driver, By.css('.network-name'))
await networkDropdown.click() await networkDropdown.click()
await delay(regularDelayMs) await delay(regularDelayMs)
// oldest selected RPC is not found
await assertElementNotPresent(webdriver, driver, By.xpath(`//span[contains(text(), '${customRpcUrls[0]}')]`))
// only recent 3 are found and in correct order (most recent at the top) // only recent 3 are found and in correct order (most recent at the top)
const customRpcs = await findElements(driver, By.xpath(`//span[contains(text(), 'https://mainnet.infura.io/')]`)) const customRpcs = await findElements(driver, By.xpath(`//span[contains(text(), 'https://mainnet.infura.io/')]`))
assert.equal(customRpcs.length, 3) assert.equal(customRpcs.length, customRpcUrls.length)
for (let i = 0; i < customRpcs.length; i++) {
const linkText = await customRpcs[i].getText()
const rpcUrl = customRpcUrls[customRpcUrls.length - i - 1]
assert.notEqual(linkText.indexOf(rpcUrl), -1)
}
}) })
}) })
}) })