Merge pull request #1684 from MetaMask/neverGiveUp

dont stop retrying brodcasting txs

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Current Master
 
+- No longer stop rebroadcasting transactions
 - Add list of popular tokens held to the account detail view.
 - Add a warning to JSON file import.
 - Fix bug where slowly mined txs would sometimes be incorrectly marked as failed.

app/scripts/controllers/transactions.js

@@ -8,8 +8,6 @@ const TxProviderUtil = require('../lib/tx-utils')
 const createId = require('../lib/random-id')
 const denodeify = require('denodeify')
 
-const RETRY_LIMIT = 200
-
 module.exports = class TransactionController extends EventEmitter {
   constructor (opts) {
     super()
@@ -435,8 +433,6 @@ module.exports = class TransactionController extends EventEmitter {
     // Only auto-submit already-signed txs:
     if (!('rawTx' in txMeta)) return cb()
 
-    if (txMeta.retryCount > RETRY_LIMIT) return
-
     // Increment a try counter.
     txMeta.retryCount++
     const rawTx = txMeta.rawTx