m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00
Code

Fix LavaMoat config check (#10514)

Browse Source 
The CI script to ensure no LavaMoat policy changes are required has
been failing despite there being no changes. It turns out that the
command used to check for changes (`git diff-index`) was failing
despite the lack of changes because the file was written again by
`yarn lavamoat:auto` but git hadn't gotten around to updating its index
since the write occurred, so it was considering it as changed until it
verified it wasn't [1].

The command has been replaced by `git diff --exit-code --quiet`, which
should do exactly the same thing except that it forces git to update
its internal cache to verify whether changes are present.

[1]: https://stackoverflow.com/questions/34807971/why-does-git-diff-index-head-result-change-for-touched-files-after-git-diff-or-g
This commit is contained in:
Mark Stacey 2021-02-25 11:13:47 -03:30 committed by GitHub
parent 15d78b8158
commit 20b2c5f004
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/scripts/validate-allow-scripts.sh
View File

@ -6,7 +6,7 @@ set -o pipefail
yarn allow-scripts auto
if git diff-index --quiet HEAD
if git diff --exit-code --quiet
then
echo "allow-scripts configuration is up-to-date"
else

2
.circleci/scripts/validate-lavamoat-policy.sh
View File

@ -6,7 +6,7 @@ set -o pipefail
yarn lavamoat:auto
if git diff-index --quiet HEAD
if git diff --exit-code --quiet
then
echo "LavaMoat policy is up-to-date"
else