From 1eb102fd964952d5d2b9a53070b0c868cbfe59bd Mon Sep 17 00:00:00 2001
From: Danica Shen <zhaodanica@gmail.com>
Date: Wed, 22 Mar 2023 15:43:03 +0000
Subject: [PATCH] Fix(18190): add tabs to permission when initializing app
 (#18218)

---
 app/manifest/v2/_base.json   | 14 --------------
 app/manifest/v2/chrome.json  | 16 +++++++++++++++-
 app/manifest/v2/firefox.json | 17 ++++++++++++++++-
 app/manifest/v3/_base.json   | 10 ----------
 app/manifest/v3/chrome.json  | 16 +++++++++++++++-
 app/manifest/v3/firefox.json | 17 ++++++++++++++++-
 6 files changed, 62 insertions(+), 28 deletions(-)

diff --git a/app/manifest/v2/_base.json b/app/manifest/v2/_base.json
index f962de618..39b289197 100644
--- a/app/manifest/v2/_base.json
+++ b/app/manifest/v2/_base.json
@@ -60,19 +60,5 @@
   },
   "manifest_version": 2,
   "name": "__MSG_appName__",
-  "permissions": [
-    "storage",
-    "unlimitedStorage",
-    "clipboardWrite",
-    "http://localhost:8545/",
-    "https://*.infura.io/",
-    "https://*.codefi.network/",
-    "https://chainid.network/chains.json",
-    "https://lattice.gridplus.io/*",
-    "activeTab",
-    "webRequest",
-    "*://*.eth/",
-    "notifications"
-  ],
   "short_name": "__MSG_appName__"
 }
diff --git a/app/manifest/v2/chrome.json b/app/manifest/v2/chrome.json
index a152130d8..9c0e95ec5 100644
--- a/app/manifest/v2/chrome.json
+++ b/app/manifest/v2/chrome.json
@@ -4,5 +4,19 @@
     "matches": ["https://metamask.io/*"],
     "ids": ["*"]
   },
-  "minimum_chrome_version": "80"
+  "minimum_chrome_version": "80",
+  "permissions": [
+    "storage",
+    "unlimitedStorage",
+    "clipboardWrite",
+    "http://localhost:8545/",
+    "https://*.infura.io/",
+    "https://*.codefi.network/",
+    "https://chainid.network/chains.json",
+    "https://lattice.gridplus.io/*",
+    "activeTab",
+    "webRequest",
+    "*://*.eth/",
+    "notifications"
+  ]
 }
diff --git a/app/manifest/v2/firefox.json b/app/manifest/v2/firefox.json
index d50b26a27..5adf04713 100644
--- a/app/manifest/v2/firefox.json
+++ b/app/manifest/v2/firefox.json
@@ -4,5 +4,20 @@
       "id": "webextension@metamask.io",
       "strict_min_version": "78.0"
     }
-  }
+  },
+  "permissions": [
+    "storage",
+    "unlimitedStorage",
+    "clipboardWrite",
+    "http://localhost:8545/",
+    "https://*.infura.io/",
+    "https://*.codefi.network/",
+    "https://chainid.network/chains.json",
+    "https://lattice.gridplus.io/*",
+    "activeTab",
+    "tabs",
+    "webRequest",
+    "*://*.eth/",
+    "notifications"
+  ]
 }
diff --git a/app/manifest/v3/_base.json b/app/manifest/v3/_base.json
index 1b9456fd8..3beeb7379 100644
--- a/app/manifest/v3/_base.json
+++ b/app/manifest/v3/_base.json
@@ -65,15 +65,5 @@
   },
   "manifest_version": 3,
   "name": "__MSG_appName__",
-  "permissions": [
-    "activeTab",
-    "alarms",
-    "clipboardWrite",
-    "notifications",
-    "scripting",
-    "storage",
-    "unlimitedStorage",
-    "webRequest"
-  ],
   "short_name": "__MSG_appName__"
 }
diff --git a/app/manifest/v3/chrome.json b/app/manifest/v3/chrome.json
index 486692539..dbb0ee22c 100644
--- a/app/manifest/v3/chrome.json
+++ b/app/manifest/v3/chrome.json
@@ -6,5 +6,19 @@
     "matches": ["https://metamask.io/*"],
     "ids": ["*"]
   },
-  "minimum_chrome_version": "80"
+  "minimum_chrome_version": "80",
+  "permissions": [
+    "storage",
+    "unlimitedStorage",
+    "clipboardWrite",
+    "http://localhost:8545/",
+    "https://*.infura.io/",
+    "https://*.codefi.network/",
+    "https://chainid.network/chains.json",
+    "https://lattice.gridplus.io/*",
+    "activeTab",
+    "webRequest",
+    "*://*.eth/",
+    "notifications"
+  ]
 }
diff --git a/app/manifest/v3/firefox.json b/app/manifest/v3/firefox.json
index 5f0e5672f..67ecf7b09 100644
--- a/app/manifest/v3/firefox.json
+++ b/app/manifest/v3/firefox.json
@@ -22,5 +22,20 @@
     "default_title": "MetaMask",
     "default_popup": "popup.html"
   },
-  "manifest_version": 2
+  "manifest_version": 2,
+  "permissions": [
+    "storage",
+    "unlimitedStorage",
+    "clipboardWrite",
+    "http://localhost:8545/",
+    "https://*.infura.io/",
+    "https://*.codefi.network/",
+    "https://chainid.network/chains.json",
+    "https://lattice.gridplus.io/*",
+    "tabs",
+    "activeTab",
+    "webRequest",
+    "*://*.eth/",
+    "notifications"
+  ]
 }