m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Simplify e2e test transaction navigation (#7816)

Browse Source 
The transaction navigation in the e2e tests has been made simpler with
the addition of data attributes to help with finding the navigation
buttons. Each button is now labelled according to its purpose.
This commit is contained in:
Mark Stacey 2020-01-14 14:53:02 -04:00 committed by GitHub
parent dd4e684f7d
commit 19f10e197e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/e2e/metamask-ui.spec.js
View File

@ -577,46 +577,37 @@ describe('MetaMask', function () {
}) })
it('navigates the transactions', async () => { it('navigates the transactions', async () => {
let navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="next-page"]'))
assert.equal(navigateTxButtons.length, 4, 'navigation button present')
await navigateTxButtons[2].click()
let navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) let navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
let navigationText = await navigationElement.getText() let navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('2'), true, 'changed transaction right') assert.equal(navigationText.includes('2'), true, 'changed transaction right')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="next-page"]'))
await navigateTxButtons[2].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('3'), true, 'changed transaction right') assert.equal(navigationText.includes('3'), true, 'changed transaction right')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="next-page"]'))
await navigateTxButtons[2].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('4'), true, 'changed transaction right') assert.equal(navigationText.includes('4'), true, 'changed transaction right')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="first-page"]'))
await navigateTxButtons[0].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('1'), true, 'navigate to first transaction') assert.equal(navigationText.includes('1'), true, 'navigate to first transaction')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="last-page"]'))
await navigateTxButtons[3].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.split('4').length, 3, 'navigate to last transaction') assert.equal(navigationText.split('4').length, 3, 'navigate to last transaction')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="previous-page"]'))
await navigateTxButtons[1].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('3'), true, 'changed transaction left') assert.equal(navigationText.includes('3'), true, 'changed transaction left')
navigateTxButtons = await driver.findElements(By.css('.confirm-page-container-navigation__arrow')) await driver.clickElement(By.css('[data-testid="previous-page"]'))
await navigateTxButtons[1].click()
navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation')) navigationElement = await driver.findElement(By.css('.confirm-page-container-navigation'))
navigationText = await navigationElement.getText() navigationText = await navigationElement.getText()
assert.equal(navigationText.includes('2'), true, 'changed transaction left') assert.equal(navigationText.includes('2'), true, 'changed transaction left')

4
ui/app/components/app/confirm-page-container/confirm-page-container-navigation/confirm-page-container-navigation.component.js
View File

@ -19,12 +19,14 @@ const ConfirmPageContainerNavigation = props => {
> >
<div <div
className="confirm-page-container-navigation__arrow" className="confirm-page-container-navigation__arrow"
data-testid="first-page"
onClick={() => onNextTx(firstTx)} onClick={() => onNextTx(firstTx)}
> >
<img src="/images/double-arrow.svg" /> <img src="/images/double-arrow.svg" />
</div> </div>
<div <div
className="confirm-page-container-navigation__arrow" className="confirm-page-container-navigation__arrow"
data-testid="previous-page"
onClick={() => onNextTx(prevTxId)} onClick={() => onNextTx(prevTxId)}
> >
<img src="/images/single-arrow.svg" /> <img src="/images/single-arrow.svg" />
@ -46,12 +48,14 @@ const ConfirmPageContainerNavigation = props => {
> >
<div <div
className="confirm-page-container-navigation__arrow" className="confirm-page-container-navigation__arrow"
data-testid="next-page"
onClick={() => onNextTx(nextTxId)} onClick={() => onNextTx(nextTxId)}
> >
<img className="confirm-page-container-navigation__imageflip" src="/images/single-arrow.svg" /> <img className="confirm-page-container-navigation__imageflip" src="/images/single-arrow.svg" />
</div> </div>
<div <div
className="confirm-page-container-navigation__arrow" className="confirm-page-container-navigation__arrow"
data-testid="last-page"
onClick={() => onNextTx(lastTx)} onClick={() => onNextTx(lastTx)}
> >
<img className="confirm-page-container-navigation__imageflip" src="/images/double-arrow.svg" /> <img className="confirm-page-container-navigation__imageflip" src="/images/double-arrow.svg" />