m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Await initializeProvider in network controller tests (#17180)

Browse Source 
The network controller unit tests have been updated to wait until the
network controller is fully initialized before proceeding. This ensures
that the initialization doesn't have any side-effects that affect later
tests.
This commit is contained in:
Mark Stacey 2023-01-13 12:53:39 -03:30 committed by GitHub
parent 72a1df247c
commit 15ee9e1556
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/scripts/controllers/network/network-controller.test.js
View File

@ -80,8 +80,8 @@ describe('NetworkController', () => {
}); });
describe('#provider', () => { describe('#provider', () => {
it('provider should be updatable without reassignment', () => { it('provider should be updatable without reassignment', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
const providerProxy = const providerProxy =
networkController.getProviderAndBlockTracker().provider; networkController.getProviderAndBlockTracker().provider;
expect(providerProxy.test).toBeUndefined(); expect(providerProxy.test).toBeUndefined();
@ -126,15 +126,15 @@ describe('NetworkController', () => {
}); });
describe('#setProviderType', () => { describe('#setProviderType', () => {
it('should update provider.type', () => { it('should update provider.type', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
networkController.setProviderType('mainnet'); networkController.setProviderType('mainnet');
const { type } = networkController.getProviderConfig(); const { type } = networkController.getProviderConfig();
expect(type).toStrictEqual('mainnet'); expect(type).toStrictEqual('mainnet');
}); });
it('should set the network to loading', () => { it('should set the network to loading', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
const spy = sinon.spy(networkController, '_setNetworkState'); const spy = sinon.spy(networkController, '_setNetworkState');
networkController.setProviderType('mainnet'); networkController.setProviderType('mainnet');
@ -146,14 +146,14 @@ describe('NetworkController', () => {
describe('#getEIP1559Compatibility', () => { describe('#getEIP1559Compatibility', () => {
it('should return false when baseFeePerGas is not in the block header', async () => { it('should return false when baseFeePerGas is not in the block header', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
const supportsEIP1559 = const supportsEIP1559 =
await networkController.getEIP1559Compatibility(); await networkController.getEIP1559Compatibility();
expect(supportsEIP1559).toStrictEqual(false); expect(supportsEIP1559).toStrictEqual(false);
}); });
it('should return true when baseFeePerGas is in block header', async () => { it('should return true when baseFeePerGas is in block header', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
getLatestBlockStub.callsFake(() => getLatestBlockStub.callsFake(() =>
Promise.resolve({ baseFeePerGas: '0xa ' }), Promise.resolve({ baseFeePerGas: '0xa ' }),
); );
@ -163,7 +163,7 @@ describe('NetworkController', () => {
}); });
it('should store EIP1559 support in state to reduce calls to _getLatestBlock', async () => { it('should store EIP1559 support in state to reduce calls to _getLatestBlock', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
getLatestBlockStub.callsFake(() => getLatestBlockStub.callsFake(() =>
Promise.resolve({ baseFeePerGas: '0xa ' }), Promise.resolve({ baseFeePerGas: '0xa ' }),
); );
@ -175,7 +175,7 @@ describe('NetworkController', () => {
}); });
it('should clear stored EIP1559 support when changing networks', async () => { it('should clear stored EIP1559 support when changing networks', async () => {
networkController.initializeProvider(); await networkController.initializeProvider();
getLatestBlockStub.callsFake(() => getLatestBlockStub.callsFake(() =>
Promise.resolve({ baseFeePerGas: '0xa ' }), Promise.resolve({ baseFeePerGas: '0xa ' }),
); );