m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

Copy update on Transaction breakdown for ApproveToken (#17296)

Browse Source
This commit is contained in:
Niranjana Binoy 2023-01-25 10:15:58 -05:00 committed by GitHub
parent 47f6d46bb3
commit 129a06cc12
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
24 changed files with 18 additions and 149 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/_locales/de/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Genehmigen"
},
"approveSpendLimit": {
"message": "$1 Ausgabelimit genehmigen",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Dies gestattet es Dritten, ohne weitere Benachrichtigung auf die folgenden NFTs zuzugreifen und diese zu übertragen, bis Sie dieses Zugriffsrecht widerrufen."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Diese Transaktion beschleunigen"
},
"spendLimitAmount": {
"message": "Ausgabelimitbetrag"
},
"spendLimitInsufficient": {
"message": "Ausgabelimit unzureichend"
},

7
app/_locales/el/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Έγκριση"
},
"approveSpendLimit": {
"message": "Έγκριση ορίου δαπανών $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Αυτό επιτρέπει σε τρίτα μέρη να έχουν πρόσβαση και να μεταφέρουν τα ακόλουθα NFT χωρίς περαιτέρω ειδοποίηση μέχρι να ανακαλέσετε την πρόσβασή τους."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Επιτάχυνση αυτής της συναλλαγής"
},
"spendLimitAmount": {
"message": "Ποσό ορίου δαπανών"
},
"spendLimitInsufficient": {
"message": "Ανεπαρκές όριο δαπανών"
},

10
app/_locales/en/messages.json generated
View File

@ -370,8 +370,8 @@
"approveButtonText": {
"message": "Approve"
},
"approveSpendLimit": {
"message": "Approve $1 spend limit",
"approveSpendingCap": {
"message": "Approve $1 spending cap",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
@ -3473,9 +3473,6 @@
"speedUpTransaction": {
"message": "Speed up this transaction"
},
"spendLimitAmount": {
"message": "Spend limit amount"
},
"spendLimitInsufficient": {
"message": "Spend limit insufficient"
},
@ -3492,6 +3489,9 @@
"spendLimitTooLarge": {
"message": "Spend limit too large"
},
"spendingCap": {
"message": "Spending cap"
},
"spendingCapError": {
"message": "Error: Enter numbers only"
},

7
app/_locales/es/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Aprobar"
},
"approveSpendLimit": {
"message": "Aprobar límite de gastos de $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Esto permite que un tercero acceda y transfiera los siguientes NFT sin previo aviso hasta que usted revoque su acceso."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Acelerar esta transacción"
},
"spendLimitAmount": {
"message": "Monto de límite de gastos"
},
"spendLimitInsufficient": {
"message": "Límite de gastos insuficiente"
},

7
app/_locales/es_419/messages.json generated
View File

@ -226,10 +226,6 @@
"approveButtonText": {
"message": "Aprobar"
},
"approveSpendLimit": {
"message": "Aprobar límite de gastos de $1",
"description": "The token symbol that is being approved"
},
"approved": {
"message": "Aprobado"
},
@ -2360,9 +2356,6 @@
"speedUpTransaction": {
"message": "Acelerar esta transacción"
},
"spendLimitAmount": {
"message": "Monto de límite de gastos"
},
"spendLimitInsufficient": {
"message": "Límite de gastos insuficiente"
},

7
app/_locales/fr/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Approuver"
},
"approveSpendLimit": {
"message": "Approuver la limite de dépenses de $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Tant que vous n’aurez pas révoqué cette autorisation, l’autre partie pourra accéder à votre portefeuille et transférer sans préavis les NFT suivants."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Accélérez cette transaction"
},
"spendLimitAmount": {
"message": "Montant limite de dépenses"
},
"spendLimitInsufficient": {
"message": "Limite de dépenses insuffisante"
},

7
app/_locales/hi/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "अनुमोदित करें"
},
"approveSpendLimit": {
"message": "$1 खर्च सीमा अनुमोदित करें",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "यह किसी तीसरे पक्ष को बिना किसी नोटिस के निम्नलिखित NFTs को ऐक्सेस करने और स्थानांतरित करने की अनुमति देता है जब तक कि आप इसकी ऐक्सेस को रद्द नहीं कर देते।"
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "इस लेनदेन को गति दें"
},
"spendLimitAmount": {
"message": "खर्च सीमा राशि"
},
"spendLimitInsufficient": {
"message": "खर्च सीमा अपर्याप्त है"
},

7
app/_locales/id/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Setujui"
},
"approveSpendLimit": {
"message": "Setujui batas penggunaan $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Hal ini memungkinkan pihak ketiga untuk mengakses dan mentransfer NFT berikut tanpa pemberitahuan lebih lanjut sampai Anda mencabut aksesnya."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Percepat transaksi ini"
},
"spendLimitAmount": {
"message": "Jumlah batas penggunaan"
},
"spendLimitInsufficient": {
"message": "Batas penggunaan tidak mencukupi"
},

7
app/_locales/it/messages.json generated
View File

@ -305,10 +305,6 @@
"approveButtonText": {
"message": "Approva"
},
"approveSpendLimit": {
"message": "Approva limite di spesa per $1",
"description": "The token symbol that is being approved"
},
"approved": {
"message": "Approvato"
},
@ -1753,9 +1749,6 @@
"speedUpTransaction": {
"message": "Accelera questa transazione"
},
"spendLimitAmount": {
"message": "Limite di spesa"
},
"spendLimitInsufficient": {
"message": "Limite di spesa insufficiente"
},

7
app/_locales/ja/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "承認"
},
"approveSpendLimit": {
"message": "$1使用限度額の承認",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "これにより、アクセス許可を取り消すまで、第三者が今後通知なしに次の NFT にアクセスし、転送できるようになります。"
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "このトランザクションをスピードアップ"
},
"spendLimitAmount": {
"message": "使用限度額"
},
"spendLimitInsufficient": {
"message": "使用限度額が十分ではありません"
},

7
app/_locales/ko/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "승인"
},
"approveSpendLimit": {
"message": "$1 지출 한도 승인",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "이렇게 하면 사용자가 액세스를 취소할 때까지 제삼자가 가 통지 없이 다음과 같은 NFT에 액세스하고 이를 전송할 수 있습니다."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "이 거래 가속화"
},
"spendLimitAmount": {
"message": "지출 한도 금액"
},
"spendLimitInsufficient": {
"message": "지출 한도 부족"
},

7
app/_locales/ph/messages.json generated
View File

@ -134,10 +134,6 @@
"approveButtonText": {
"message": "Aprubahan"
},
"approveSpendLimit": {
"message": "Aprubahan ang limitasyon sa paggastos na $1",
"description": "The token symbol that is being approved"
},
"approved": {
"message": "Inaprubahan"
},
@ -1555,9 +1551,6 @@
"speedUpTransaction": {
"message": "Pabilisin ang transaksyong ito"
},
"spendLimitAmount": {
"message": "Halaga ng limitasyon sa paggastos"
},
"spendLimitInsufficient": {
"message": "Hindi sapat ang limitasyon sa paggastos"
},

7
app/_locales/pt/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Aprovar"
},
"approveSpendLimit": {
"message": "Aprovar limite de gastos de $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Isso permite que terceiros acessem e transfiram os seguintes NFTs sem aviso prévio até que você revogue o acesso."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Acelerar essa transação"
},
"spendLimitAmount": {
"message": "Valor do limite de gastos"
},
"spendLimitInsufficient": {
"message": "Limite de gastos insuficiente"
},

7
app/_locales/pt_BR/messages.json generated
View File

@ -226,10 +226,6 @@
"approveButtonText": {
"message": "Aprovar"
},
"approveSpendLimit": {
"message": "Aprovar limite de gastos de $1",
"description": "The token symbol that is being approved"
},
"approved": {
"message": "Aprovado"
},
@ -2360,9 +2356,6 @@
"speedUpTransaction": {
"message": "Acelerar essa transação"
},
"spendLimitAmount": {
"message": "Valor do limite de gastos"
},
"spendLimitInsufficient": {
"message": "Limite de gastos insuficiente"
},

7
app/_locales/ru/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Одобрить"
},
"approveSpendLimit": {
"message": "Одобрить предел расходов $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Это позволяет третьей стороне получать доступ и передавать следующие NFT без дополнительного уведомления, пока вы не отзовете ее доступ."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Ускорить эту транзакцию"
},
"spendLimitAmount": {
"message": "Сумма лимита расходов"
},
"spendLimitInsufficient": {
"message": "Недостаточный лимит расходов"
},

7
app/_locales/tl/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Aprubahan"
},
"approveSpendLimit": {
"message": "Aprubahan ang limitasyon sa paggastos na $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Nagbibigay-daan ito sa third party na i-access at ilipat ang mga sumusunod na NFT nang walang karagdagang abiso hanggang sa bawiin mo ang pag-access nito."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Pabilisin ang transaksyong ito"
},
"spendLimitAmount": {
"message": "Halaga ng limitasyon sa paggastos"
},
"spendLimitInsufficient": {
"message": "Hindi sapat ang limitasyon sa paggastos"
},

7
app/_locales/tr/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Onayla"
},
"approveSpendLimit": {
"message": "$1 harcama limitini onayla",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Üçüncü bir tarafın, siz bu erişimi iptal edene kadar başka bildirim yapılmaksızın aşağıdaki NFT'lere erişim sağlamasına ve onları transfer edebilmesine izin verir."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Bu işlemi hızlandır"
},
"spendLimitAmount": {
"message": "Harcama limiti tutarı"
},
"spendLimitInsufficient": {
"message": "Harcama limiti yetersiz"
},

7
app/_locales/vi/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "Phê duyệt"
},
"approveSpendLimit": {
"message": "Phê duyệt giới hạn chi tiêu $1",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "Điều này cho phép bên thứ ba được quyền truy cập và chuyển các NFT sau đây mà không cần thông báo thêm cho đến khi bạn thu hồi quyền truy cập của họ."
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "Tăng tốc giao dịch này"
},
"spendLimitAmount": {
"message": "Khoản tiền giới hạn chi tiêu"
},
"spendLimitInsufficient": {
"message": "Giới hạn chi tiêu không đủ"
},

7
app/_locales/zh_CN/messages.json generated
View File

@ -370,10 +370,6 @@
"approveButtonText": {
"message": "批准"
},
"approveSpendLimit": {
"message": "批准 $1 消费限额",
"description": "The token symbol that is being approved"
},
"approveTokenDescription": {
"message": "这允许第三方访问和转移以下 NFT，而无需另行通知，直到您撤销其访问权限。"
},
@ -3442,9 +3438,6 @@
"speedUpTransaction": {
"message": "加速该交易"
},
"spendLimitAmount": {
"message": "消费限额"
},
"spendLimitInsufficient": {
"message": "消费限额不足"
},

7
app/_locales/zh_TW/messages.json generated
View File

@ -133,10 +133,6 @@
"approveButtonText": {
"message": "批准"
},
"approveSpendLimit": {
"message": "批准 $1 花費限額",
"description": "The token symbol that is being approved"
},
"approved": {
"message": "已許可"
},
@ -1462,9 +1458,6 @@
"speedUpTransaction": {
"message": "加速這筆交易"
},
"spendLimitAmount": {
"message": "花費額度上限"
},
"spendLimitInsufficient": {
"message": "花費額度上限不足"
},

2
test/e2e/tests/collectibles.spec.js
View File

@ -131,7 +131,7 @@ describe('Collectibles', function () {
// Verify transaction
const completedTx = await driver.findElement('.list-item__title');
const completedTxText = await completedTx.getText();
assert.equal(completedTxText, 'Approve Token spend limit');
assert.equal(completedTxText, 'Approve token spending cap');
},
);
});

16
test/e2e/tests/custom-token-add-approve.spec.js
View File

@ -196,11 +196,11 @@ describe('Create token, approve token and approve token without gas', function (
const approveTokenTask = await driver.waitForSelector({
// Selects only the very first transaction list item immediately following the 'Pending' header
css: '.transaction-list__completed-transactions .transaction-list-item:first-child .list-item__heading',
text: 'Approve Token spend limit',
text: 'Approve token spending cap',
});
assert.equal(
await approveTokenTask.getText(),
'Approve Token spend limit',
'Approve token spending cap',
);
},
);
@ -339,11 +339,11 @@ describe('Create token, approve token and approve token without gas', function (
const approveTokenTask = await driver.waitForSelector({
// Select only the heading of the first entry in the transaction list.
css: '.transaction-list__completed-transactions .transaction-list-item:first-child .list-item__heading',
text: 'Approve Token spend limit',
text: 'Approve token spending cap',
});
assert.equal(
await approveTokenTask.getText(),
'Approve Token spend limit',
'Approve token spending cap',
);
},
);
@ -426,11 +426,11 @@ describe('Create token, approve token and approve token without gas', function (
const approveTokenTask = await driver.waitForSelector({
// Select only the heading of the first entry in the transaction list.
css: '.transaction-list__completed-transactions .transaction-list-item:first-child .list-item__heading',
text: 'Approve Token spend limit',
text: 'Approve token spending cap',
});
assert.equal(
await approveTokenTask.getText(),
'Approve Token spend limit',
'Approve token spending cap',
);
},
);
@ -490,11 +490,11 @@ describe('Create token, approve token and approve token without gas', function (
// check transaction in Activity tab
const approveTokenTask = await driver.waitForSelector({
css: '.transaction-list__completed-transactions .transaction-list-item:first-child .list-item__heading',
text: 'Approve Token spend limit',
text: 'Approve token spending cap',
});
assert.equal(
await approveTokenTask.getText(),
'Approve Token spend limit',
'Approve token spending cap',
);
},
);

2
ui/components/app/transaction-breakdown/transaction-breakdown.component.js
View File

@ -74,7 +74,7 @@ export default class TransactionBreakdown extends PureComponent {
)}
</TransactionBreakdownRow>
<TransactionBreakdownRow
title={isTokenApprove ? t('spendLimitAmount') : t('amount')}
title={isTokenApprove ? t('spendingCap') : t('amount')}
>
<span className="transaction-breakdown__value transaction-breakdown__value--amount">
{primaryCurrency}

4
ui/hooks/useTransactionDisplayData.js
View File

@ -222,7 +222,9 @@ export function useTransactionDisplayData(transactionGroup) {
} else if (type === TransactionType.tokenMethodApprove) {
category = TransactionGroupCategory.approval;
prefix = '';
title = t('approveSpendLimit', [token?.symbol || t('token')]);
title = t('approveSpendingCap', [
token?.symbol || t('token').toLowerCase(),
]);
subtitle = origin;
subtitleContainsOrigin = true;
} else if (type === TransactionType.tokenMethodSetApprovalForAll) {