m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Remove unused isPopup state (#8280)

Browse Source 
This property was being set upon each change to background state.
This commit is contained in:
Mark Stacey 2020-04-01 20:01:47 -03:00 committed by GitHub
parent 44effa0d91
commit 12536aa47f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/scripts/background.js
View File

@ -100,7 +100,6 @@ initialize().catch(log.error)
* @property {boolean} isInitialized - Whether the first vault has been created. * @property {boolean} isInitialized - Whether the first vault has been created.
* @property {boolean} isUnlocked - Whether the vault is currently decrypted and accounts are available for selection. * @property {boolean} isUnlocked - Whether the vault is currently decrypted and accounts are available for selection.
* @property {boolean} isAccountMenuOpen - Represents whether the main account selection UI is currently displayed. * @property {boolean} isAccountMenuOpen - Represents whether the main account selection UI is currently displayed.
* @property {boolean} isPopup - Returns true if the current view is an externally-triggered notification.
* @property {string} rpcTarget - DEPRECATED - The URL of the current RPC provider. * @property {string} rpcTarget - DEPRECATED - The URL of the current RPC provider.
* @property {Object} identities - An object matching lower-case hex addresses to Identity objects with "address" and "name" (nickname) keys. * @property {Object} identities - An object matching lower-case hex addresses to Identity objects with "address" and "name" (nickname) keys.
* @property {Object} unapprovedTxs - An object mapping transaction hashes to unapproved transactions. * @property {Object} unapprovedTxs - An object mapping transaction hashes to unapproved transactions.

1
development/states/navigate-txs.json
View File

@ -3,7 +3,6 @@
"isInitialized": true, "isInitialized": true,
"isUnlocked": true, "isUnlocked": true,
"isAccountMenuOpen": false, "isAccountMenuOpen": false,
"isPopup": false,
"rpcTarget": "https://rawtestrpc.metamask.io/", "rpcTarget": "https://rawtestrpc.metamask.io/",
"identities": { "identities": {
"0x8cf82b5aa41ff2282427be151dd328568684007a": { "0x8cf82b5aa41ff2282427be151dd328568684007a": {

3
ui/app/ducks/metamask/metamask.js
View File

@ -1,13 +1,10 @@
import { actionConstants as actions } from '../../store/actions' import { actionConstants as actions } from '../../store/actions'
import { getEnvironmentType } from '../../../../app/scripts/lib/util'
import { ENVIRONMENT_TYPE_POPUP } from '../../../../app/scripts/lib/enums'
export default function reduceMetamask (state = {}, action) { export default function reduceMetamask (state = {}, action) {
const metamaskState = Object.assign({ const metamaskState = Object.assign({
isInitialized: false, isInitialized: false,
isUnlocked: false, isUnlocked: false,
isAccountMenuOpen: false, isAccountMenuOpen: false,
isPopup: getEnvironmentType() === ENVIRONMENT_TYPE_POPUP,
rpcTarget: 'https://rawtestrpc.metamask.io/', rpcTarget: 'https://rawtestrpc.metamask.io/',
identities: {}, identities: {},
unapprovedTxs: {}, unapprovedTxs: {},