m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 04:20:53 +01:00
Code

Fix node/no-unsupported-features/node-builtins issues (#9684)

Browse Source 
Refs #9663

See [`node/no-unsupported-features/node-builtins`][1] for more information.

This change enables `node/no-unsupported-features/node-builtins` and fixes the issue
raised by the rule.

The `engines.node` version is updated to reflect the version specified by the `.nvmrc`
file and the version used by CircleCI:

```bash
$ cat .nvmrc
v10.18.1
```

```bash
$ docker run --rm -it circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88 node --version
v10.18.1
```
This commit is contained in:
Whymarrh Whitby 2020-10-22 16:24:57 -02:30 committed by GitHub
parent 8c87c46601
commit 10227266f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -92,7 +92,6 @@ module.exports = {
'node/no-sync': 'off', 'node/no-sync': 'off',
'node/no-unpublished-import': 'off', 'node/no-unpublished-import': 'off',
'node/no-unpublished-require': 'off', 'node/no-unpublished-require': 'off',
'node/no-unsupported-features/node-builtins': 'off',
'mocha/max-top-level-suites': 'off', 'mocha/max-top-level-suites': 'off',
}, },

2
package.json
View File

@ -289,7 +289,7 @@
"webpack": "^4.41.6" "webpack": "^4.41.6"
}, },
"engines": { "engines": {
"node": "^10.16.0", "node": "^10.18.1",
"yarn": "^1.16.0" "yarn": "^1.16.0"
} }
} }