m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Refactor webdriver method verboseReportOnFailure (#8948)

Browse Source 
The webdriver method `verboseReportOnFailure` had previously taken a
single parameter, `test`, which was an object representing the current
Mocha test. However, only one property was used (`title`).

Instead the `title` is now passed through directly. This was done to
make this function easier to use outside of a Mocha context.
This commit is contained in:
Mark Stacey 2020-07-09 12:01:14 -03:00 committed by GitHub
parent f1bfb84b4b
commit 0e51fb233c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e/address-book.spec.js
View File

@ -43,7 +43,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/ethereum-on.spec.js
View File

@ -42,7 +42,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/from-import-ui.spec.js
View File

@ -46,7 +46,7 @@ describe('Using MetaMask with an existing account', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/incremental-security.spec.js
View File

@ -47,7 +47,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/metamask-responsive-ui.spec.js
View File

@ -37,7 +37,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/metamask-ui.spec.js
View File

@ -38,7 +38,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/permissions.spec.js
View File

@ -42,7 +42,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/send-edit.spec.js
View File

@ -44,7 +44,7 @@ describe('Using MetaMask with an existing account', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/signature-request.spec.js
View File

@ -41,7 +41,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/threebox.spec.js
View File

@ -45,7 +45,7 @@ describe('MetaMask', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

2
test/e2e/web3.spec.js
View File

@ -44,7 +44,7 @@ describe('Using MetaMask with an existing account', function () {
}
}
if (this.currentTest.state === 'failed') {
await driver.verboseReportOnFailure(this.currentTest)
await driver.verboseReportOnFailure(this.currentTest.title)
}
})

4
test/e2e/webdriver/driver.js
View File

@ -172,8 +172,8 @@ class Driver {
// Error handling
async verboseReportOnFailure (test) {
const artifactDir = `./test-artifacts/${this.browser}/${test.title}`
async verboseReportOnFailure (title) {
const artifactDir = `./test-artifacts/${this.browser}/${title}`
const filepathBase = `${artifactDir}/test-failure`
await fs.mkdir(artifactDir, { recursive: true })
const screenshot = await this.driver.takeScreenshot()