From 4f118feaad565d155f7007bf9b212fff4a376df0 Mon Sep 17 00:00:00 2001 From: PeterYinusa <peter.yinusa@consensys.net> Date: Wed, 18 Jan 2023 22:28:31 +0000 Subject: [PATCH 1/3] Update CHANGELOG.md --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 502a2553b..1def3a264 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add Reject Transactions modal to be present in the footer of the Approve screen ([#16832](https://github.com/MetaMask/metamask-extension/pull/16832)) - [FLASK] Add snap alerts and prompts via `snap_dialog` RPC method ([#16048](https://github.com/MetaMask/metamask-extension/pull/16048)) - [FLASK] Expose transaction origin to transaction insight snaps ([#16671](https://github.com/MetaMask/metamask-extension/pull/16671)) +- Toggle option to enable/disable balance and Token rate checking for using third-party API ([#16772](https://github.com/MetaMask/metamask-extension/pull/16772)) +- Onboarding v2: Implement requested metrics ([#17090](https://github.com/MetaMask/metamask-extension/pull/17090)) ### Changed - Update secondary copy and remove the Address component from SetApprovalForAll and NFT Approve screens ([#16292](https://github.com/MetaMask/metamask-extension/pull/16292)) @@ -51,10 +53,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - `ethereum` is an EIP-1193 provider and can be accessed by requesting the `endowment:ethereum-provider` permission - `snap` is always exposed and can be used to access snap specific functions using `snap.request()` - [FLASK] **BREAKING:** Named parameters are now required in all Snaps RPC methods ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) +- Security and Privacy Settings Re-org ([#16756](https://github.com/MetaMask/metamask-extension/pull/16756)) ### Removed - [FLASK] **BREAKING:** Removed `snap_getAppKey` ([#16525](https://github.com/MetaMask/metamask-extension/pull/16525)) - Snaps that need snap-specific entropy can use `snap_getEntropy` instead +- Remove ONBOARDING_V2 flag for release ([#16865](https://github.com/MetaMask/metamask-extension/pull/16865)) ### Fixed - Fix resolving to the Account nickname or contact name when scanning the QR code in the Send screen ([#16204](https://github.com/MetaMask/metamask-extension/pull/16204)) @@ -70,6 +74,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [FLASK] Clear notification state on restore ([#16503](https://github.com/MetaMask/metamask-extension/pull/16503)) - [FLASK] Fix a crash that happens after snap install ([#16526](https://github.com/MetaMask/metamask-extension/pull/16526)) - [FLASK] Fix usage of wrong `ethereum` global for `ethereum` endowment ([#16932](https://github.com/MetaMask/metamask-extension/pull/16932)) +- Validating or restricting the number of digits on token allowance flow ([#17234](https://github.com/MetaMask/metamask-extension/pull/17234)) +- Fixed navigation through multiple unapproved transactions for ERC20 tokens ([#16822](https://github.com/MetaMask/metamask-extension/pull/16822)) +- Display large and small numbers as decimals instead of scientific notation on token allowance confirmation screens ([#16676](https://github.com/MetaMask/metamask-extension/pull/16676)) +- Fix #16959 - Don't allow user to see welcome or password creation screen after a keyring has been created ([#17024](https://github.com/MetaMask/metamask-extension/pull/17024)) +- Fix 'Back' navigation from Restore Vault page when accessed from popup window ([#17095](https://github.com/MetaMask/metamask-extension/pull/17095)) +- Align custom spending cap Max button in approve screen for multiple languages ([#16927](https://github.com/MetaMask/metamask-extension/pull/16927)) ## [10.23.3] ### Removed From f4391bb5c45230aaf4ffeac477d30076bc41d4ee Mon Sep 17 00:00:00 2001 From: Dan J Miller <danjm.com@gmail.com> Date: Thu, 19 Jan 2023 10:44:47 -0330 Subject: [PATCH 2/3] Allow user to scroll network form in onboarding modal (#17291) --- ui/pages/onboarding-flow/add-network-modal/index.js | 1 + ui/pages/settings/networks-tab/index.scss | 5 +++++ .../settings/networks-tab/networks-form/networks-form.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/ui/pages/onboarding-flow/add-network-modal/index.js b/ui/pages/onboarding-flow/add-network-modal/index.js index 45b7ec5b6..bf2c2cf14 100644 --- a/ui/pages/onboarding-flow/add-network-modal/index.js +++ b/ui/pages/onboarding-flow/add-network-modal/index.js @@ -34,6 +34,7 @@ export default function AddNetworkModal() { </Box> <NetworksForm addNewNetwork + restrictHeight networksToRender={[]} cancelCallback={closeCallback} submitCallback={closeCallback} diff --git a/ui/pages/settings/networks-tab/index.scss b/ui/pages/settings/networks-tab/index.scss index d34a749f8..7fbdd6219 100644 --- a/ui/pages/settings/networks-tab/index.scss +++ b/ui/pages/settings/networks-tab/index.scss @@ -234,6 +234,11 @@ } } + &__restrict-height { + max-height: 578px; + overflow-y: auto; + } + &__add-network-form-footer { display: flex; flex-flow: row; diff --git a/ui/pages/settings/networks-tab/networks-form/networks-form.js b/ui/pages/settings/networks-tab/networks-form/networks-form.js index ccc9ebdfa..23466bb27 100644 --- a/ui/pages/settings/networks-tab/networks-form/networks-form.js +++ b/ui/pages/settings/networks-tab/networks-form/networks-form.js @@ -78,6 +78,7 @@ const isValidWhenAppended = (url) => { const NetworksForm = ({ addNewNetwork, + restrictHeight, isCurrentRpcTarget, networksToRender, selectedNetwork, @@ -588,6 +589,7 @@ const NetworksForm = ({ className={classnames({ 'networks-tab__network-form': !addNewNetwork, 'networks-tab__add-network-form': addNewNetwork, + 'networks-tab__restrict-height': restrictHeight, })} > {addNewNetwork ? ( @@ -708,6 +710,7 @@ NetworksForm.propTypes = { selectedNetwork: PropTypes.object, cancelCallback: PropTypes.func, submitCallback: PropTypes.func, + restrictHeight: PropTypes.bool, }; NetworksForm.defaultProps = { From 45fa9238143f20a159b8f699a83ecd83f4583716 Mon Sep 17 00:00:00 2001 From: Dan J Miller <danjm.com@gmail.com> Date: Thu, 19 Jan 2023 11:33:08 -0330 Subject: [PATCH 3/3] Clarify effect of autodetect tokens toggle (#17293) * Clarify effect of autodetect tokens toggle * Fix test Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net> --- app/_locales/en/messages.json | 2 +- .../security-tab/__snapshots__/security-tab.test.js.snap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 5fbdf9481..e2e58aafc 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -431,7 +431,7 @@ "message": "Autodetect tokens" }, "autoDetectTokensDescription": { - "message": "We use third-party APIs to detect and display new tokens sent to your wallet. Turn off if you don’t want the app to pull data from those services. $1", + "message": "We use third-party APIs to detect and display new tokens sent to your wallet. Turn off if you don’t want the app to automatically pull data from those services. $1", "description": "$1 is a link to a support article" }, "autoLockTimeLimit": { diff --git a/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap b/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap index 705bb3827..c77767603 100644 --- a/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap +++ b/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap @@ -438,7 +438,7 @@ exports[`Security Tab should match snapshot 1`] = ` > <span> - We use third-party APIs to detect and display new tokens sent to your wallet. Turn off if you don’t want the app to pull data from those services. + We use third-party APIs to detect and display new tokens sent to your wallet. Turn off if you don’t want the app to automatically pull data from those services. <a href="https://consensys.net/privacy-policy/" rel="noopener noreferrer"