2016-08-24 22:28:24 +02:00
|
|
|
const assert = require('assert')
|
2016-06-25 01:13:27 +02:00
|
|
|
const extend = require('xtend')
|
|
|
|
const STORAGE_KEY = 'metamask-persistance-key'
|
|
|
|
var configManagerGen = require('../lib/mock-config-manager')
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
var configManager
|
2016-07-21 17:47:03 +02:00
|
|
|
const rp = require('request-promise')
|
2016-08-24 22:58:50 +02:00
|
|
|
const nock = require('nock')
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
|
|
|
|
describe('config-manager', function() {
|
|
|
|
|
2016-06-17 00:04:50 +02:00
|
|
|
beforeEach(function() {
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
window.localStorage = {} // Hacking localStorage support into JSDom
|
2016-06-25 01:13:27 +02:00
|
|
|
configManager = configManagerGen()
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
})
|
|
|
|
|
2016-07-21 17:47:03 +02:00
|
|
|
describe('currency conversions', function() {
|
|
|
|
|
|
|
|
describe('#getCurrentFiat', function() {
|
|
|
|
it('should return false if no previous key exists', function() {
|
|
|
|
var result = configManager.getCurrentFiat()
|
|
|
|
assert.ok(!result)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#setCurrentFiat', function() {
|
|
|
|
it('should make getCurrentFiat return true once set', function() {
|
|
|
|
assert.equal(configManager.getCurrentFiat(), false)
|
2016-08-17 00:11:40 +02:00
|
|
|
configManager.setCurrentFiat('USD')
|
2016-07-21 17:47:03 +02:00
|
|
|
var result = configManager.getCurrentFiat()
|
2016-08-17 00:11:40 +02:00
|
|
|
assert.equal(result, 'USD')
|
2016-07-21 17:47:03 +02:00
|
|
|
})
|
|
|
|
|
|
|
|
it('should work with other currencies as well', function() {
|
|
|
|
assert.equal(configManager.getCurrentFiat(), false)
|
2016-08-17 00:11:40 +02:00
|
|
|
configManager.setCurrentFiat('JPY')
|
2016-07-21 17:47:03 +02:00
|
|
|
var result = configManager.getCurrentFiat()
|
2016-08-17 00:11:40 +02:00
|
|
|
assert.equal(result, 'JPY')
|
2016-07-21 17:47:03 +02:00
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#getConversionRate', function() {
|
|
|
|
it('should return false if non-existent', function() {
|
|
|
|
var result = configManager.getConversionRate()
|
|
|
|
assert.ok(!result)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2016-07-22 01:44:50 +02:00
|
|
|
describe('#updateConversionRate', function() {
|
2016-07-21 17:47:03 +02:00
|
|
|
it('should retrieve an update for ETH to USD and set it in memory', function(done) {
|
|
|
|
this.timeout(15000)
|
2016-08-24 22:58:50 +02:00
|
|
|
var usdMock = nock('https://www.cryptonator.com')
|
|
|
|
.get('/api/ticker/eth-USD')
|
|
|
|
.reply(200, '{"ticker":{"base":"ETH","target":"USD","price":"11.02456145","volume":"44948.91745289","change":"-0.01472534"},"timestamp":1472072136,"success":true,"error":""}')
|
2016-08-24 22:28:24 +02:00
|
|
|
|
2016-07-21 17:47:03 +02:00
|
|
|
assert.equal(configManager.getConversionRate(), false)
|
|
|
|
var promise = new Promise(
|
|
|
|
function (resolve, reject) {
|
2016-08-17 00:11:40 +02:00
|
|
|
configManager.setCurrentFiat('USD')
|
2016-08-24 22:58:50 +02:00
|
|
|
configManager.updateConversionRate().then(function() {
|
2016-07-21 17:47:03 +02:00
|
|
|
resolve()
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
promise.then(function() {
|
|
|
|
var result = configManager.getConversionRate()
|
|
|
|
assert.equal(typeof result, 'number')
|
|
|
|
done()
|
|
|
|
}).catch(function(err) {
|
|
|
|
console.log(err)
|
|
|
|
})
|
|
|
|
|
|
|
|
})
|
|
|
|
|
|
|
|
it('should work for JPY as well.', function() {
|
|
|
|
this.timeout(15000)
|
|
|
|
assert.equal(configManager.getConversionRate(), false)
|
2016-08-24 22:28:24 +02:00
|
|
|
|
2016-08-24 23:02:51 +02:00
|
|
|
var jpyMock = nock('https://www.cryptonator.com')
|
2016-08-24 22:58:50 +02:00
|
|
|
.get('/api/ticker/eth-JPY')
|
|
|
|
.reply(200, '{"ticker":{"base":"ETH","target":"JPY","price":"11.02456145","volume":"44948.91745289","change":"-0.01472534"},"timestamp":1472072136,"success":true,"error":""}')
|
|
|
|
|
|
|
|
|
2016-07-21 17:47:03 +02:00
|
|
|
var promise = new Promise(
|
|
|
|
function (resolve, reject) {
|
2016-08-17 00:11:40 +02:00
|
|
|
configManager.setCurrentFiat('JPY')
|
2016-08-24 22:58:50 +02:00
|
|
|
configManager.updateConversionRate().then(function() {
|
2016-07-21 17:47:03 +02:00
|
|
|
resolve()
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
promise.then(function() {
|
|
|
|
var result = configManager.getConversionRate()
|
|
|
|
assert.equal(typeof result, 'number')
|
|
|
|
}).catch(function(err) {
|
|
|
|
console.log(err)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2016-06-17 00:04:50 +02:00
|
|
|
describe('confirmation', function() {
|
|
|
|
|
|
|
|
describe('#getConfirmed', function() {
|
|
|
|
it('should return false if no previous key exists', function() {
|
|
|
|
var result = configManager.getConfirmed()
|
|
|
|
assert.ok(!result)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#setConfirmed', function() {
|
|
|
|
it('should make getConfirmed return true once set', function() {
|
2016-06-30 20:30:46 +02:00
|
|
|
assert.equal(configManager.getConfirmed(), false)
|
2016-06-17 00:04:50 +02:00
|
|
|
configManager.setConfirmed(true)
|
|
|
|
var result = configManager.getConfirmed()
|
|
|
|
assert.equal(result, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
it('should be able to set false', function() {
|
|
|
|
configManager.setConfirmed(false)
|
|
|
|
var result = configManager.getConfirmed()
|
|
|
|
assert.equal(result, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
it('should persist to local storage', function() {
|
|
|
|
configManager.setConfirmed(true)
|
|
|
|
var data = configManager.getData()
|
|
|
|
assert.equal(data.isConfirmed, true)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
describe('#setConfig', function() {
|
|
|
|
window.localStorage = {} // Hacking localStorage support into JSDom
|
|
|
|
|
|
|
|
it('should set the config key', function () {
|
|
|
|
var testConfig = {
|
|
|
|
provider: {
|
|
|
|
type: 'rpc',
|
|
|
|
rpcTarget: 'foobar'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
configManager.setConfig(testConfig)
|
|
|
|
var result = configManager.getData()
|
|
|
|
|
|
|
|
assert.equal(result.config.provider.type, testConfig.provider.type)
|
|
|
|
assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
|
|
|
|
})
|
|
|
|
|
|
|
|
it('setting wallet should not overwrite config', function() {
|
|
|
|
var testConfig = {
|
|
|
|
provider: {
|
|
|
|
type: 'rpc',
|
|
|
|
rpcTarget: 'foobar'
|
2016-06-30 20:30:46 +02:00
|
|
|
},
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
}
|
2016-06-30 20:30:46 +02:00
|
|
|
configManager.setConfirmed(true)
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
configManager.setConfig(testConfig)
|
|
|
|
|
|
|
|
var testWallet = {
|
|
|
|
name: 'this is my fake wallet'
|
|
|
|
}
|
|
|
|
configManager.setWallet(testWallet)
|
|
|
|
|
|
|
|
var result = configManager.getData()
|
|
|
|
assert.equal(result.wallet.name, testWallet.name, 'wallet name is set')
|
|
|
|
assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
|
2016-06-30 20:30:46 +02:00
|
|
|
assert.equal(configManager.getConfirmed(), true)
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
|
|
|
|
testConfig.provider.type = 'something else!'
|
|
|
|
configManager.setConfig(testConfig)
|
|
|
|
|
|
|
|
result = configManager.getData()
|
|
|
|
assert.equal(result.wallet.name, testWallet.name, 'wallet name is set')
|
|
|
|
assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget)
|
|
|
|
assert.equal(result.config.provider.type, testConfig.provider.type)
|
2016-06-30 20:30:46 +02:00
|
|
|
assert.equal(configManager.getConfirmed(), true)
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2016-05-21 01:18:54 +02:00
|
|
|
describe('wallet nicknames', function() {
|
|
|
|
it('should return null when no nicknames are saved', function() {
|
|
|
|
var nick = configManager.nicknameForWallet('0x0')
|
|
|
|
assert.equal(nick, null, 'no nickname returned')
|
|
|
|
})
|
|
|
|
|
|
|
|
it('should persist nicknames', function() {
|
|
|
|
var account = '0x0'
|
|
|
|
var nick1 = 'foo'
|
|
|
|
var nick2 = 'bar'
|
|
|
|
configManager.setNicknameForWallet(account, nick1)
|
|
|
|
|
|
|
|
var result1 = configManager.nicknameForWallet(account)
|
|
|
|
assert.equal(result1, nick1)
|
|
|
|
|
|
|
|
configManager.setNicknameForWallet(account, nick2)
|
|
|
|
var result2 = configManager.nicknameForWallet(account)
|
|
|
|
assert.equal(result2, nick2)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
describe('rpc manipulations', function() {
|
|
|
|
it('changing rpc should return a different rpc', function() {
|
|
|
|
var firstRpc = 'first'
|
|
|
|
var secondRpc = 'second'
|
|
|
|
|
|
|
|
configManager.setRpcTarget(firstRpc)
|
|
|
|
var firstResult = configManager.getCurrentRpcAddress()
|
|
|
|
assert.equal(firstResult, firstRpc)
|
|
|
|
|
|
|
|
configManager.setRpcTarget(secondRpc)
|
|
|
|
var secondResult = configManager.getCurrentRpcAddress()
|
|
|
|
assert.equal(secondResult, secondRpc)
|
|
|
|
})
|
|
|
|
})
|
2016-04-19 01:39:35 +02:00
|
|
|
|
|
|
|
describe('transactions', function() {
|
|
|
|
beforeEach(function() {
|
|
|
|
configManager._saveTxList([])
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#getTxList', function() {
|
|
|
|
it('when new should return empty array', function() {
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.ok(Array.isArray(result))
|
|
|
|
assert.equal(result.length, 0)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#_saveTxList', function() {
|
|
|
|
it('saves the submitted data to the tx list', function() {
|
|
|
|
var target = [{ foo: 'bar' }]
|
|
|
|
configManager._saveTxList(target)
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.equal(result[0].foo, 'bar')
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#addTx', function() {
|
|
|
|
it('adds a tx returned in getTxList', function() {
|
|
|
|
var tx = { id: 1 }
|
|
|
|
configManager.addTx(tx)
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.ok(Array.isArray(result))
|
|
|
|
assert.equal(result.length, 1)
|
|
|
|
assert.equal(result[0].id, 1)
|
|
|
|
})
|
2016-08-19 00:40:56 +02:00
|
|
|
|
|
|
|
it('cuts off early txs beyond a limit', function() {
|
|
|
|
const limit = configManager.txLimit
|
|
|
|
for (let i = 0; i < limit + 1; i++) {
|
|
|
|
let tx = { id: i }
|
|
|
|
configManager.addTx(tx)
|
|
|
|
}
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.equal(result.length, limit, `limit of ${limit} txs enforced`)
|
|
|
|
assert.equal(result[0].id, 1, 'early txs truncted')
|
|
|
|
})
|
2016-04-19 01:39:35 +02:00
|
|
|
})
|
|
|
|
|
|
|
|
describe('#confirmTx', function() {
|
|
|
|
it('sets the tx status to confirmed', function() {
|
|
|
|
var tx = { id: 1, status: 'unconfirmed' }
|
|
|
|
configManager.addTx(tx)
|
|
|
|
configManager.confirmTx(1)
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.ok(Array.isArray(result))
|
|
|
|
assert.equal(result.length, 1)
|
|
|
|
assert.equal(result[0].status, 'confirmed')
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#rejectTx', function() {
|
|
|
|
it('sets the tx status to rejected', function() {
|
|
|
|
var tx = { id: 1, status: 'unconfirmed' }
|
|
|
|
configManager.addTx(tx)
|
|
|
|
configManager.rejectTx(1)
|
|
|
|
var result = configManager.getTxList()
|
|
|
|
assert.ok(Array.isArray(result))
|
|
|
|
assert.equal(result.length, 1)
|
|
|
|
assert.equal(result[0].status, 'rejected')
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2016-04-20 02:32:09 +02:00
|
|
|
describe('#updateTx', function() {
|
|
|
|
it('replaces the tx with the same id', function() {
|
|
|
|
configManager.addTx({ id: '1', status: 'unconfirmed' })
|
|
|
|
configManager.addTx({ id: '2', status: 'confirmed' })
|
|
|
|
configManager.updateTx({ id: '1', status: 'blah', hash: 'foo' })
|
|
|
|
var result = configManager.getTx('1')
|
|
|
|
assert.equal(result.hash, 'foo')
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2016-04-19 01:39:35 +02:00
|
|
|
describe('#unconfirmedTxs', function() {
|
|
|
|
it('returns unconfirmed txs in a hash', function() {
|
|
|
|
configManager.addTx({ id: '1', status: 'unconfirmed' })
|
|
|
|
configManager.addTx({ id: '2', status: 'confirmed' })
|
|
|
|
let result = configManager.unconfirmedTxs()
|
|
|
|
assert.equal(typeof result, 'object')
|
|
|
|
assert.equal(result['1'].status, 'unconfirmed')
|
|
|
|
assert.equal(result['0'], undefined)
|
|
|
|
assert.equal(result['2'], undefined)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('#getTx', function() {
|
|
|
|
it('returns a tx with the requested id', function() {
|
|
|
|
configManager.addTx({ id: '1', status: 'unconfirmed' })
|
|
|
|
configManager.addTx({ id: '2', status: 'confirmed' })
|
|
|
|
assert.equal(configManager.getTx('1').status, 'unconfirmed')
|
|
|
|
assert.equal(configManager.getTx('2').status, 'confirmed')
|
|
|
|
})
|
|
|
|
})
|
|
|
|
})
|
Made configuration migrateable
Abstract all configuration data into a singleton called `configManager`, who is responsible for reading and writing to the persisted storage (localStorage, in our case).
Uses my new module [pojo-migrator](https://www.npmjs.com/package/pojo-migrator), and wraps it with the `ConfigManager` class, which we can hang any state setting or getting methods we need.
By keeping all the persisted state in one place, we can stabilize its outward-facing API, making the interactions increasingly atomic, which will allow us to add features that require restructuring the persisted data in the long term without having to rewrite UI or even `background.js` code.
All the restructuring and data-type management is kept in one neat little place.
This should make it very easy to add new configuration options like user-configured providers, per-domain vaults, and more!
I know this doesn't seem like a big user-facing feature, but we have a big laundry list of features that I think this will really help streamline.
2016-03-31 04:15:49 +02:00
|
|
|
})
|