m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-15 14:17:11 +01:00
Code
53efc53a40
metamask-extension/ui/lib/tx-helper.js

18 lines
834 B
JavaScript
Raw Normal View History

Add UI for Signing Messages Calls to `eth.sign` are now transiently persisted in memory, and displayed in a chronological stack with pending transactions (which are still persisted to disk). This allows the user a method to sign/cancel transactions even if they miss the Chrome notification. Improved a lot of the view routing, to avoid cases where routes would show an empty account view, or transition to the accounts list when it shouldn't. Broke the transaction approval view into a couple components so messages and transactions could have their own templates.
2016-05-03 23:32:22 +02:00
const valuesFor = require('../app/util').valuesFor
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
module.exports = function (unapprovedTxs, unapprovedMsgs, personalMsgs, network) {
Fix UI Dev Mode for Tx Approval The state object had been changed, but our mock states for tx approval were using the old keys. Rather than try to muck about and figure out each and every change, I've re-generated a UI dev state for tx approval, which should help @zanibas on his current project. We can continue adding new dev states as needed from here. If anyone catches a state that doesn't render correctly, it's worth checking if a new snapshot doesn't solve things. Debugged by adding new debugging loggers, and I've left them in place for easier future debugging.
2017-02-21 08:33:21 +01:00
log.debug('tx-helper called with params:')
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
log.debug({ unapprovedTxs, unapprovedMsgs, personalMsgs, network })
Fix UI Dev Mode for Tx Approval The state object had been changed, but our mock states for tx approval were using the old keys. Rather than try to muck about and figure out each and every change, I've re-generated a UI dev state for tx approval, which should help @zanibas on his current project. We can continue adding new dev states as needed from here. If anyone catches a state that doesn't render correctly, it's worth checking if a new snapshot doesn't solve things. Debugged by adding new debugging loggers, and I've left them in place for easier future debugging.
2017-02-21 08:33:21 +01:00
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
const txValues = network ? valuesFor(unapprovedTxs).filter(tx => tx.txParams.metamaskNetworkId === network) : valuesFor(unapprovedTxs)
Fix UI Dev Mode for Tx Approval The state object had been changed, but our mock states for tx approval were using the old keys. Rather than try to muck about and figure out each and every change, I've re-generated a UI dev state for tx approval, which should help @zanibas on his current project. We can continue adding new dev states as needed from here. If anyone catches a state that doesn't render correctly, it's worth checking if a new snapshot doesn't solve things. Debugged by adding new debugging loggers, and I've left them in place for easier future debugging.
2017-02-21 08:33:21 +01:00
log.debug(`tx helper found ${txValues.length} unapproved txs`)
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
const msgValues = valuesFor(unapprovedMsgs)
Fix UI Dev Mode for Tx Approval The state object had been changed, but our mock states for tx approval were using the old keys. Rather than try to muck about and figure out each and every change, I've re-generated a UI dev state for tx approval, which should help @zanibas on his current project. We can continue adding new dev states as needed from here. If anyone catches a state that doesn't render correctly, it's worth checking if a new snapshot doesn't solve things. Debugged by adding new debugging loggers, and I've left them in place for easier future debugging.
2017-02-21 08:33:21 +01:00
log.debug(`tx helper found ${msgValues.length} unsigned messages`)
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
let allValues = txValues.concat(msgValues)
const personalValues = valuesFor(personalMsgs)
Got personal_sign working Also fixed bug where signing would not close popup.
2017-02-23 23:23:45 +01:00
log.debug(`tx helper found ${personalValues.length} unsigned personal messages`)
Add personal sign actions and template
2017-02-23 01:23:13 +01:00
allValues = allValues.concat(personalValues)
Add UI for Signing Messages Calls to `eth.sign` are now transiently persisted in memory, and displayed in a chronological stack with pending transactions (which are still persisted to disk). This allows the user a method to sign/cancel transactions even if they miss the Chrome notification. Improved a lot of the view routing, to avoid cases where routes would show an empty account view, or transition to the accounts list when it shouldn't. Broke the transaction approval view into a couple components so messages and transactions could have their own templates.
2016-05-03 23:32:22 +02:00
return allValues.sort(tx => tx.time)
}
Copy Permalink