m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 10:30:04 +01:00
Code
1a2dc850a3
metamask-extension/stylelint.config.js

135 lines
4.8 KiB
JavaScript
Raw Normal View History

Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
module.exports = {
Move stylelint ignore patterns into config (#9391)
2020-09-10 19:00:30 +02:00
ignoreFiles: [
'/app',
'/development',
'/dist',
'/docs',
'/fonts',
'/images',
'/node_modules',
'/notices',
'/test',
],
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
rules: {
// stylelint-config-standard
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'at-rule-empty-line-before': [
'always',
{
except: ['blockless-after-same-name-blockless', 'first-nested'],
ignore: ['after-comment'],
},
],
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'at-rule-name-case': 'lower',
'at-rule-name-space-after': 'always-single-line',
'at-rule-semicolon-newline-after': 'always',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'block-closing-brace-empty-line-before': 'never',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'block-closing-brace-newline-after': 'always',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'block-closing-brace-newline-before': 'always-multi-line',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'block-closing-brace-space-before': 'always-single-line',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'block-opening-brace-newline-after': 'always-multi-line',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'block-opening-brace-space-after': 'always-single-line',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'block-opening-brace-space-before': 'always',
'color-hex-case': 'lower',
'color-hex-length': 'short',
'comment-empty-line-before': [
'always',
{
except: ['first-nested'],
ignore: ['stylelint-commands'],
},
],
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
// 'comment-whitespace-inside': 'always',
'custom-property-empty-line-before': [
'always',
{
except: ['after-custom-property', 'first-nested'],
ignore: ['after-comment', 'inside-single-line-block'],
},
],
'declaration-bang-space-after': 'never',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'declaration-bang-space-before': 'always',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'declaration-block-semicolon-newline-after': 'always-multi-line',
'declaration-block-semicolon-space-after': 'always-single-line',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'declaration-block-semicolon-space-before': 'never',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'declaration-block-single-line-max-declarations': 1,
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'declaration-block-trailing-semicolon': 'always',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'declaration-colon-newline-after': 'always-multi-line',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'declaration-colon-space-after': 'always-single-line',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'declaration-colon-space-before': 'never',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'declaration-empty-line-before': [
'always',
{
except: ['after-declaration', 'first-nested'],
ignore: ['after-comment', 'inside-single-line-block'],
},
],
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'function-comma-newline-after': 'always-multi-line',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'function-comma-space-after': 'always-single-line',
'function-comma-space-before': 'never',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'function-max-empty-lines': 0,
'function-name-case': 'lower',
'function-parentheses-newline-inside': 'always-multi-line',
'function-parentheses-space-inside': 'never-single-line',
'function-whitespace-after': 'always',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
indentation: 2,
'length-zero-no-unit': true,
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
// 'max-empty-lines': 1,
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'media-feature-colon-space-after': 'always',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'media-feature-colon-space-before': 'never',
'media-feature-name-case': 'lower',
'media-feature-parentheses-space-inside': 'never',
'media-feature-range-operator-space-after': 'always',
'media-feature-range-operator-space-before': 'always',
'media-query-list-comma-newline-after': 'always-multi-line',
'media-query-list-comma-space-after': 'always-single-line',
'media-query-list-comma-space-before': 'never',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'no-eol-whitespace': true,
'no-missing-end-of-source-newline': true,
'number-leading-zero': 'always',
'number-no-trailing-zeros': true,
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'property-case': 'lower',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'rule-empty-line-before': [
'always-multi-line',
{
except: ['first-nested'],
ignore: ['after-comment'],
},
],
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'selector-attribute-brackets-space-inside': 'never',
'selector-attribute-operator-space-after': 'never',
'selector-attribute-operator-space-before': 'never',
'selector-combinator-space-after': 'always',
'selector-combinator-space-before': 'always',
'selector-descendant-combinator-no-non-space': true,
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'selector-list-comma-newline-after': 'always',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'selector-list-comma-space-before': 'never',
'selector-max-empty-lines': 0,
'selector-pseudo-class-case': 'lower',
'selector-pseudo-class-parentheses-space-inside': 'never',
'selector-pseudo-element-case': 'lower',
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
'selector-pseudo-element-colon-notation': 'double',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'selector-type-case': 'lower',
'unit-case': 'lower',
// 'value-keyword-case': 'lower',
'value-list-comma-newline-after': 'always-multi-line',
Uncomment stylelint rules (#8988) These rules were commented out in #8169 because they had existing violations. However, these were all due to the inlining of vendored CSS, which was removed in #8986. These rules no longer have any violations.
2020-07-15 02:21:14 +02:00
'value-list-comma-space-after': 'always-single-line',
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
'value-list-comma-space-before': 'never',
'value-list-max-empty-lines': 0,
// custom rules
Uncomment and fix all auto-fixable stylelint rules (#8989) All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
2020-07-15 15:13:40 +02:00
Fix stylelint (#8169) * Stylelint: Ignore only top-level directories The `.stylelintignore` entries lacked leading slashes, so most of the UI code was ignored (because it fell under the `ui/app` directory, and `app/` was ignored. The leading slashes ensure only the intended top-level directories are ignored. * Simplify stylelint rules We use the `stylelint-config-standard` rule-set, so most commonly-used stylelint rules are inherited from that. Some of the removed rules were redundant, some of them were more strict than the rules in `standard` and we hadn't been following them in practice, and some were obsolete. * Convert stylelint config to JavaScript JavaScript is a bit easier than JSON to work with, as it allows comments. This was also done to make it easier to merge in the `stylelint-config- standard`, which is also in JavaScript. * Inline `stylelint-config-standard` I intend to go through each of these rules one-by-one, which is easier with all of these rules inlined. Selectively overriding/disabling them would have been messy. * Comment out rules that aren't current working These rules have been temporarily disabled. They will be re-renabled one-by-one as they are fixed. This was done to make it easier to split these changes among separate PRs, as many of the rules require extensive functional changes. * Add `stylelint` to `lint` script `stylelint` is now run as part of the `lint` script. There is also a separate `lint:styles` script for running just `stylelint`.
2020-07-14 21:12:53 +02:00
// 'color-named': 'never',
// 'font-family-name-quotes': 'always-where-recommended',
// 'font-weight-notation': 'numeric',
// 'function-url-quotes': 'always',
'value-no-vendor-prefix': true,
'value-list-comma-newline-before': 'never-multi-line',
// 'selector-attribute-quotes': 'always',
// 'selector-max-specificity': '0,5,2',
// 'max-nesting-depth': 3,
'no-unknown-animations': true,
},
@metamask/eslint config@5.0.0 (#10358) * @metamask/eslint-config@5.0.0 * Update eslintrc and prettierrc * yarn lint:fix
2021-02-04 19:15:23 +01:00
};
Copy Permalink