From b22cf39aa28f4033f6e70ea7e523b5e8de8c1add Mon Sep 17 00:00:00 2001
From: Scott Sadler <scott@alphanode.co>
Date: Fri, 23 Jun 2017 10:30:08 +0200
Subject: [PATCH] public_keys array is a set

---
 src/transaction/makeOutput.js             |  4 +++-
 test/transaction/test_cryptoconditions.js | 22 +++++++++++++++-------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/src/transaction/makeOutput.js b/src/transaction/makeOutput.js
index 3e48895..bbd628e 100644
--- a/src/transaction/makeOutput.js
+++ b/src/transaction/makeOutput.js
@@ -13,7 +13,9 @@ export default function makeOutput(condition, amount = '1') {
     const publicKeys = []
     const getPublicKeys = details => {
         if (details.type === 'ed25519-sha-256') {
-            publicKeys.push(details.public_key)
+            if (publicKeys.indexOf(details.public_key) === -1) {
+                publicKeys.push(details.public_key)
+            }
         } else if (details.type === 'threshold-sha-256') {
             details.subfulfillments.map(getPublicKeys)
         }
diff --git a/test/transaction/test_cryptoconditions.js b/test/transaction/test_cryptoconditions.js
index 34288e9..4419451 100644
--- a/test/transaction/test_cryptoconditions.js
+++ b/test/transaction/test_cryptoconditions.js
@@ -19,21 +19,29 @@ test('Ed25519 condition encoding', t => {
 
 test('Threshold condition encoding', t => {
     const publicKey = '4zvwRjXUKGfvwnParsHAS3HuSVzV5cA4McphgmoCtajS'
+    const ed25519 = Transaction.makeEd25519Condition(publicKey, false)
     const condition = Transaction.makeThresholdCondition(
-            1, [Transaction.makeEd25519Condition(publicKey, false)])
+            1, [ed25519, ed25519])
     const output = Transaction.makeOutput(condition)
     const target = {
         condition: {
             details: {
                 type: 'threshold-sha-256',
                 threshold: 1,
-                subfulfillments: [{
-                    type: 'ed25519-sha-256',
-                    public_key: publicKey,
-                    signature: null,
-                }]
+                subfulfillments: [
+                    {
+                        type: 'ed25519-sha-256',
+                        public_key: publicKey,
+                        signature: null,
+                    },
+                    {
+                        type: 'ed25519-sha-256',
+                        public_key: publicKey,
+                        signature: null,
+                    }
+                ]
             },
-            uri: 'ni:///sha-256;VBIfZSoBprUQy-LVNAzaZ2q-eyWbrcPKtBg1PuNXIpQ?fpt=threshold-sha-256&cost=132096&subtypes=ed25519-sha-256',
+            uri: 'ni:///sha-256;xTeBhQj7ae5Tym7cp83fwtkesQnhdwNwDEMIYwnf2g0?fpt=threshold-sha-256&cost=133120&subtypes=ed25519-sha-256',
         },
         amount: '1',
         public_keys: [publicKey]