From 1f27cd23008f47f6407ba1d738d104ef9f31fa15 Mon Sep 17 00:00:00 2001
From: getlarge <ed@getlarge.eu>
Date: Tue, 9 Mar 2021 07:52:03 +0100
Subject: [PATCH] fix: improve request errors

---
 src/baseRequest.js | 24 ++++++++++++------------
 src/transport.js   | 35 ++++++++++++++---------------------
 2 files changed, 26 insertions(+), 33 deletions(-)

diff --git a/src/baseRequest.js b/src/baseRequest.js
index 147a2a9..20d11ab 100644
--- a/src/baseRequest.js
+++ b/src/baseRequest.js
@@ -2,19 +2,24 @@
 // SPDX-License-Identifier: (Apache-2.0 AND CC-BY-4.0)
 // Code is Apache-2.0 and docs are CC-BY-4.0
 
-import {
-    Promise
-} from 'es6-promise'
+import { Promise } from 'es6-promise'
 import fetchPonyfill from 'fetch-ponyfill'
-import {
-    vsprintf
-} from 'sprintf-js'
+import { vsprintf } from 'sprintf-js'
 
 import formatText from './format_text'
 import stringifyAsQueryParam from './stringify_as_query_param'
 
 const fetch = fetchPonyfill(Promise)
 
+export function ResponseError(message,  status, requestURI) {
+    this.name = 'ResponseError'
+    this.message = message
+    this.status = status
+    this.requestURI = requestURI
+    this.stack = (new Error()).stack
+}
+
+ResponseError.prototype = new Error;
 
 /**
  * @private
@@ -45,12 +50,7 @@ function handleResponse(res) {
     // If status is not a 2xx (based on Response.ok), assume it's an error
     // See https://developer.mozilla.org/en-US/docs/Web/API/GlobalFetch/fetch
     if (!(res && res.ok)) {
-        const errorObject = {
-            message: 'HTTP Error: Requested page not reachable',
-            status: `${res.status} ${res.statusText}`,
-            requestURI: res.url
-        }
-        throw errorObject
+        throw new ResponseError('HTTP Error: Requested page not reachable', `${res.status} ${res.statusText}`, res.url)
     }
     return res
 }
diff --git a/src/transport.js b/src/transport.js
index 2136595..3c411b3 100644
--- a/src/transport.js
+++ b/src/transport.js
@@ -46,28 +46,21 @@ export default class Transport {
             connection = this.pickConnection()
             // Date in milliseconds
             const startTime = Date.now()
-            try {
-                // eslint-disable-next-line no-await-in-loop
-                response = await connection.request(
-                    path,
-                    headers,
-                    this.timeout,
-                    this.maxBackoffTime
-                )
-                const elapsed = Date.now() - startTime
-                if (connection.backoffTime > 0 && this.timeout > 0) {
-                    this.timeout -= elapsed
-                } else {
-                    // No connection error, the response is valid
-                    return response
-                }
-            } catch (err) {
-                throw err
+            // eslint-disable-next-line no-await-in-loop
+            response = await connection.request(
+                path,
+                headers,
+                this.timeout,
+                this.maxBackoffTime
+            )
+            const elapsed = Date.now() - startTime
+            if (connection.backoffTime > 0 && this.timeout > 0) {
+                this.timeout -= elapsed
+            } else {
+                // No connection error, the response is valid
+                return response
             }
         }
-        const errorObject = {
-            message: 'TimeoutError',
-        }
-        throw errorObject
+        throw new Error('TimeoutError')
     }
 }