ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2024-12-22 17:33:14 +01:00
Code Issues Releases Wiki Activity

Small cosmetic changes

Browse Source
This commit is contained in:
Brett Sun 2016-01-18 10:17:49 +01:00
parent 08cc88c699
commit bc17dd4bad
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/actions/edition_list_actions.js
View File

@ -18,7 +18,7 @@ class EditionListActions {
} }
fetchEditionList(pieceId, page, pageSize, orderBy, orderAsc, filterBy, maxEdition) { fetchEditionList(pieceId, page, pageSize, orderBy, orderAsc, filterBy, maxEdition) {
if((!orderBy && typeof orderAsc === 'undefined') || !orderAsc) { if ((!orderBy && typeof orderAsc === 'undefined') || !orderAsc) {
orderBy = 'edition_number'; orderBy = 'edition_number';
orderAsc = true; orderAsc = true;
} }

15
js/stores/edition_list_store.js
View File

@ -12,7 +12,7 @@ class EditionListStore {
this.bindActions(EditionsListActions); this.bindActions(EditionsListActions);
} }
onUpdateEditionList({pieceId, editionListOfPiece, page, pageSize, orderBy, orderAsc, count, filterBy, maxEdition}) { onUpdateEditionList({ pieceId, editionListOfPiece, page, pageSize, orderBy, orderAsc, count, filterBy, maxEdition }) {
// if editionList for a specific piece does not exist yet, // if editionList for a specific piece does not exist yet,
// just initialize a new array // just initialize a new array
const pieceEditionList = this.editionList[pieceId] || []; const pieceEditionList = this.editionList[pieceId] || [];
@ -29,8 +29,8 @@ class EditionListStore {
const storeEditionIndex = (page - 1) * pageSize + index; const storeEditionIndex = (page - 1) * pageSize + index;
// if edition already exists, just merge // if edition already exists, just merge
if(pieceEditionList[storeEditionIndex]) { if (pieceEditionList[storeEditionIndex]) {
pieceEditionList[storeEditionIndex] = React.addons.update(pieceEditionList[storeEditionIndex], {$merge: updatedEdition}); pieceEditionList[storeEditionIndex] = React.addons.update(pieceEditionList[storeEditionIndex], { $merge: updatedEdition });
} else { } else {
// if does not exist, assign // if does not exist, assign
pieceEditionList[storeEditionIndex] = updatedEdition; pieceEditionList[storeEditionIndex] = updatedEdition;
@ -85,7 +85,7 @@ class EditionListStore {
* We often just have to refresh the edition list for a certain pieceId, * We often just have to refresh the edition list for a certain pieceId,
* this method provides exactly that functionality without any side effects * this method provides exactly that functionality without any side effects
*/ */
onRefreshEditionList({pieceId, filterBy}) { onRefreshEditionList({ pieceId, filterBy }) {
const pieceEditionList = this.editionList[pieceId]; const pieceEditionList = this.editionList[pieceId];
// It may happen that the user enters the site logged in already // It may happen that the user enters the site logged in already
@ -93,7 +93,7 @@ class EditionListStore {
// If he then tries to delete a piece/edition and this method is called, // If he then tries to delete a piece/edition and this method is called,
// we'll not be able to refresh his edition list since its not yet there. // we'll not be able to refresh his edition list since its not yet there.
// Therefore we can just return, since there is no data to be refreshed // Therefore we can just return, since there is no data to be refreshed
if(!this.editionList[pieceId]) { if (!this.editionList[pieceId]) {
return; return;
} }
@ -116,7 +116,7 @@ class EditionListStore {
this.editionList[pieceId].forEach((edition) => { this.editionList[pieceId].forEach((edition) => {
// Taken from: http://stackoverflow.com/a/519157/1263876 // Taken from: http://stackoverflow.com/a/519157/1263876
if(typeof toValue !== 'undefined' && edition.id === editionId) { if (typeof toValue !== 'undefined' && edition.id === editionId) {
edition.selected = toValue; edition.selected = toValue;
} else if(edition.id === editionId) { } else if(edition.id === editionId) {
if(edition.selected) { if(edition.selected) {
@ -142,7 +142,6 @@ class EditionListStore {
} }
onToggleEditionList(pieceId) { onToggleEditionList(pieceId) {
this.isEditionListOpenForPieceId[pieceId] = { this.isEditionListOpenForPieceId[pieceId] = {
show: this.isEditionListOpenForPieceId[pieceId] ? !this.isEditionListOpenForPieceId[pieceId].show : true show: this.isEditionListOpenForPieceId[pieceId] ? !this.isEditionListOpenForPieceId[pieceId].show : true
}; };
@ -151,7 +150,7 @@ class EditionListStore {
// the merge fails, as the edition list is not refreshed when closed. // the merge fails, as the edition list is not refreshed when closed.
// Therefore in the case of a filter application when closed, we need to reload the // Therefore in the case of a filter application when closed, we need to reload the
// edition list // edition list
if(!this.isEditionListOpenForPieceId[pieceId].show) { if (!this.isEditionListOpenForPieceId[pieceId].show) {
// to clear an array, david walsh recommends to just set it's length to zero // to clear an array, david walsh recommends to just set it's length to zero
// http://davidwalsh.name/empty-array // http://davidwalsh.name/empty-array