ascribe/onion
1
0
Fork 0
mirror of https://github.com/ascribe/onion.git synced 2024-12-22 09:23:13 +01:00
Code Issues Releases Wiki Activity

Simplify example in naming conventions for sources

Browse Source
This commit is contained in:
Brett Sun 2016-01-15 13:58:15 +01:00
parent f4eef6b7c8
commit b3d6620f73
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/sources/NAMING_CONVENTIONS.md
View File

@ -22,12 +22,8 @@ refreshApplicationToken
we cannot repeat this for a sources' methods as patterns like this would emerge in the stores: we cannot repeat this for a sources' methods as patterns like this would emerge in the stores:
```javascript ```javascript
onFetchCurrentUser(invalidateCache) { onFetchCurrentUser() {
this.invalidateCache = invalidateCache; this.getInstance().fetchCurrentUser(); // does not call a flux "action" but a method in user_source.js - which is confusing
if(!this.getInstance().isLoading()) {
this.getInstance().fetchCurrentUser(); // does not call a flux "action" but a method in user_source.js - which is confusing
}
} }
``` ```
@ -67,4 +63,4 @@ lookupCurrentUser: {
UserActions.logoutCurrentUser UserActions.logoutCurrentUser
UserStore.onLogoutCurrentUser UserStore.onLogoutCurrentUser
UserSource.performLogoutCurrentUser UserSource.performLogoutCurrentUser
``` ```