From 784098f22539d54916267436c000337f51c4ec98 Mon Sep 17 00:00:00 2001 From: Brett Sun Date: Wed, 28 Oct 2015 18:37:09 +0100 Subject: [PATCH] Fix PropType warnings for components in ascribe_detail --- js/components/ascribe_detail/detail_property.js | 7 ++++++- js/components/ascribe_detail/edition_container.js | 1 + .../ascribe_detail/further_details_fileuploader.js | 2 +- js/components/ascribe_detail/piece.js | 5 ++++- js/components/ascribe_detail/piece_container.js | 1 + 5 files changed, 13 insertions(+), 3 deletions(-) diff --git a/js/components/ascribe_detail/detail_property.js b/js/components/ascribe_detail/detail_property.js index 828ed81a..12054996 100644 --- a/js/components/ascribe_detail/detail_property.js +++ b/js/components/ascribe_detail/detail_property.js @@ -6,13 +6,18 @@ let DetailProperty = React.createClass({ propTypes: { label: React.PropTypes.string, value: React.PropTypes.oneOfType([ + React.PropTypes.number, React.PropTypes.string, React.PropTypes.element ]), separator: React.PropTypes.string, labelClassName: React.PropTypes.string, valueClassName: React.PropTypes.string, - ellipsis: React.PropTypes.bool + ellipsis: React.PropTypes.bool, + children: React.PropTypes.oneOfType([ + React.PropTypes.arrayOf(React.PropTypes.element), + React.PropTypes.element + ]) }, getDefaultProps() { diff --git a/js/components/ascribe_detail/edition_container.js b/js/components/ascribe_detail/edition_container.js index 66704816..3bab238d 100644 --- a/js/components/ascribe_detail/edition_container.js +++ b/js/components/ascribe_detail/edition_container.js @@ -19,6 +19,7 @@ let EditionContainer = React.createClass({ propTypes: { actionPanelButtonListType: React.PropTypes.func, furtherDetailsType: React.PropTypes.func, + params: React.PropTypes.object, location: React.PropTypes.object }, diff --git a/js/components/ascribe_detail/further_details_fileuploader.js b/js/components/ascribe_detail/further_details_fileuploader.js index 6f9abca4..af465330 100644 --- a/js/components/ascribe_detail/further_details_fileuploader.js +++ b/js/components/ascribe_detail/further_details_fileuploader.js @@ -27,7 +27,7 @@ let FurtherDetailsFileuploader = React.createClass({ getDefaultProps() { return { - label: "Additional files", + label: 'Additional files', multiple: false }; }, diff --git a/js/components/ascribe_detail/piece.js b/js/components/ascribe_detail/piece.js index ed312f5f..7481d1fb 100644 --- a/js/components/ascribe_detail/piece.js +++ b/js/components/ascribe_detail/piece.js @@ -20,7 +20,10 @@ let Piece = React.createClass({ subheader: React.PropTypes.object, buttons: React.PropTypes.object, loadPiece: React.PropTypes.func, - children: React.PropTypes.object + children: React.PropTypes.oneOfType([ + React.PropTypes.arrayOf(React.PropTypes.element), + React.PropTypes.element + ]) }, diff --git a/js/components/ascribe_detail/piece_container.js b/js/components/ascribe_detail/piece_container.js index 9a8e994d..879f7b32 100644 --- a/js/components/ascribe_detail/piece_container.js +++ b/js/components/ascribe_detail/piece_container.js @@ -46,6 +46,7 @@ import { setDocumentTitle } from '../../utils/dom_utils'; */ let PieceContainer = React.createClass({ propTypes: { + params: React.PropTypes.object, furtherDetailsType: React.PropTypes.func, location: React.PropTypes.object },